1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-04 14:46:57 -05:00
gitea/templates/user/auth
wxiaoguang 027014d7de
Fix webauthn regression and improve code (#25113)
Follow:

* #22697

There are some bugs in #22697:

* https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966
* the webauthn failure message is never shown and causes console error
* The `document.getElementById('register-button')` and
`document.getElementById('login-button')` is wrong
    * there is no such element in code
    * it causes JS error when a browser doesn't provide webauthn
    * the end user can't see the real error message

These bugs are fixed in this PR.

Other changes:

* Use simple HTML/CSS layouts, no need to use too many `gt-` patches
* Make the webauthn page have correct "page-content" layout
* The "data-webauthn-error-msg" elements are only used to provide locale
texts, so move them into a single "gt-hidden", then no need to repeat a
lot of "gt-hidden" in code
* The `{{.CsrfTokenHtml}}`  is a no-op because there is no form
* Many `hideElem('#webauthn-error')` in code is no-op because the
`webauthn-error` already has "gt-hidden" by default
* Make the tests for "URLEncodedBase64" really test with concrete cases.


Screenshots:

* Error message when webauthn fails (before, there is no error message):

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b)

</details>

* Error message when webauthn is unavailable 

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2)

</details>
2023-06-07 19:20:18 +08:00
..
activate.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
captcha.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
change_passwd_inner.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
change_passwd.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
finalize_openid.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
forgot_passwd.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
grant_error.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
grant.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
link_account.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
oidc_wellknown.tmpl Add groups scope/claim to OIDC/OAuth2 Provider (#17367) 2021-10-22 17:19:24 +08:00
prohibit_login.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
reset_passwd.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
signin_inner.tmpl Fix OAuth loading state (#24788) 2023-05-18 11:50:11 +00:00
signin_navbar.tmpl Optimize html templates (#22080) 2022-12-09 21:34:51 +08:00
signin_openid.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
signin.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
signup_inner.tmpl Add option to enable CAPTCHA validation for login (#21638) 2022-11-22 21:13:18 +00:00
signup_openid_connect.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
signup_openid_navbar.tmpl Improve "new-menu" (#24465) 2023-05-01 12:08:37 -04:00
signup_openid_register.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
signup.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
twofa_scratch.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
twofa.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
webauthn_error.tmpl Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00
webauthn.tmpl Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00