14 Commits

Author	SHA1	Message	Date
Lunny Xiao	e8860ef4f9	Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments (#9996) ... * Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments * fix test * fix lint * Change error log to warn	2020-01-28 08:02:03 +00:00
David Svantesson	25531c71a7	Mark PR reviews as stale at push and allow to dismiss stale approvals (#9532) ... Fix #5997. If a push causes the patch/diff of a PR towards target branch to change, all existing reviews for the PR will be set and shown as stale. New branch protection option to dismiss stale approvals are added. To show that a review is not based on the latest PR changes, an hourglass is shown	2020-01-09 01:47:45 +00:00
Lunny Xiao	43ada65571	remove unused method and rename createcommentWithNoAction (#9367)	2019-12-16 11:54:24 +08:00
David Svantesson	bac4b78e09	Branch protection: Possibility to not use whitelist but allow anyone with write access (#9055) ... * Possibility to not use whitelist but allow anyone with write access * fix existing test * rename migration function * Try to give a better name for migration step * Clear settings if higher level setting is not set * Move official reviews to db instead of counting approvals each time * migration * fix * fix migration * fix migration * Remove NOT NULL from EnableWhitelist as migration isn't possible * Fix migration, reviews are connected to issues. * Fix SQL query issues in GetReviewersByPullID. * Simplify function GetReviewersByIssueID * Handle reviewers that has been deleted * Ensure reviews for test is in a well defined order * Only clear and set official reviews when it is an approve or reject.	2019-12-03 20:08:56 -05:00
Lunny Xiao	2011a5b818	Extract createComment (#9125) ... * Extract createComment * fix lint * fix lint	2019-11-30 21:44:39 -05:00
guillep2k	d779deef6e	Fix show single review comments in the PR page (#9143)	2019-11-24 00:46:16 -05:00
Lunny Xiao	dad67cae54	Refactor pull request review (#8954) ... * refactor submit review * remove unnecessary code * remove unused comment * fix lint * remove duplicated actions * remove duplicated actions * fix typo * fix comment content	2019-11-14 10:57:36 +08:00
guillep2k	8282f26250	Don't send notification on pending reviews (#8943)	2019-11-13 18:36:04 +00:00
Lunny Xiao	aaeef295bb	Move pull webhook to notification (#8805) ... * Move pull webhook to notification * fix fmt	2019-11-05 19:04:08 +08:00
Lunny Xiao	f518fe6662	Rename HookQueue to hookQueue (#8778) ... * Rename HookQueue to hookQueue * fix lint	2019-11-02 10:35:12 +08:00
Lunny Xiao	0e7f7df3cf	Move webhook to a standalone package under modules (#8747) ... * Move webhook to a standalone package under modules * fix test * fix comments	2019-11-01 22:51:22 +00:00
John Olheiser	0a004a69cd	Improve webhooks (#8583) ... * Improve webhooks Signed-off-by: jolheiser <john.olheiser@gmail.com> * Update MSTeams and ReviewPayload comment Signed-off-by: jolheiser <john.olheiser@gmail.com> * Add repo.FullName to comments Signed-off-by: jolheiser <john.olheiser@gmail.com>	2019-10-18 23:42:04 +01:00
John Olheiser	7c4c01c0fd	Fix review webhooks (#8570) ... Signed-off-by: jolheiser <john.olheiser@gmail.com>	2019-10-18 16:33:19 +08:00
Lunny Xiao	eb11ca6847	Extract actions on new pull request from models to pulls service and move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull (#8218) ... * extract actions on new pull request from models to pulls service * improve code * move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull * fix fmt * Rename pulls.go to pull.go	2019-09-27 08:22:36 +08:00