2014-03-22 13:50:50 -04:00
|
|
|
// Copyright 2014 The Gogs Authors. All rights reserved.
|
2018-11-28 06:26:14 -05:00
|
|
|
// Copyright 2018 The Gitea Authors. All rights reserved.
|
2014-03-22 13:50:50 -04:00
|
|
|
// Use of this source code is governed by a MIT-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
package repo
|
|
|
|
|
2014-07-26 02:28:04 -04:00
|
|
|
import (
|
2017-01-24 21:43:02 -05:00
|
|
|
"bytes"
|
2014-07-26 02:28:04 -04:00
|
|
|
"errors"
|
|
|
|
"fmt"
|
2021-09-22 01:38:34 -04:00
|
|
|
"io"
|
2018-07-17 17:23:58 -04:00
|
|
|
"net/http"
|
2020-09-11 10:48:39 -04:00
|
|
|
"path"
|
2017-03-14 21:10:35 -04:00
|
|
|
"strconv"
|
2014-07-26 02:28:04 -04:00
|
|
|
"strings"
|
|
|
|
|
2016-11-10 11:24:48 -05:00
|
|
|
"code.gitea.io/gitea/models"
|
|
|
|
"code.gitea.io/gitea/modules/base"
|
|
|
|
"code.gitea.io/gitea/modules/context"
|
2020-10-17 00:23:08 -04:00
|
|
|
"code.gitea.io/gitea/modules/convert"
|
2019-03-27 05:33:00 -04:00
|
|
|
"code.gitea.io/gitea/modules/git"
|
2019-02-20 19:54:05 -05:00
|
|
|
issue_indexer "code.gitea.io/gitea/modules/indexer/issues"
|
2016-11-10 11:24:48 -05:00
|
|
|
"code.gitea.io/gitea/modules/log"
|
2019-12-06 23:21:18 -05:00
|
|
|
"code.gitea.io/gitea/modules/markup"
|
2017-09-21 01:20:14 -04:00
|
|
|
"code.gitea.io/gitea/modules/markup/markdown"
|
2016-11-10 11:24:48 -05:00
|
|
|
"code.gitea.io/gitea/modules/setting"
|
2019-06-05 20:37:45 -04:00
|
|
|
api "code.gitea.io/gitea/modules/structs"
|
2020-10-05 01:49:33 -04:00
|
|
|
"code.gitea.io/gitea/modules/upload"
|
2017-01-24 21:43:02 -05:00
|
|
|
"code.gitea.io/gitea/modules/util"
|
2021-01-26 10:36:53 -05:00
|
|
|
"code.gitea.io/gitea/modules/web"
|
2019-09-24 13:39:50 -04:00
|
|
|
comment_service "code.gitea.io/gitea/services/comments"
|
2021-04-06 15:44:05 -04:00
|
|
|
"code.gitea.io/gitea/services/forms"
|
2019-09-30 09:50:44 -04:00
|
|
|
issue_service "code.gitea.io/gitea/services/issue"
|
2019-12-06 21:44:10 -05:00
|
|
|
pull_service "code.gitea.io/gitea/services/pull"
|
2019-03-27 05:33:00 -04:00
|
|
|
|
2019-08-23 12:40:30 -04:00
|
|
|
"github.com/unknwon/com"
|
2014-07-26 02:28:04 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
const (
|
2019-10-15 08:19:32 -04:00
|
|
|
tplAttachment base.TplName = "repo/issue/view_content/attachments"
|
|
|
|
|
2020-09-11 10:48:39 -04:00
|
|
|
tplIssues base.TplName = "repo/issue/list"
|
|
|
|
tplIssueNew base.TplName = "repo/issue/new"
|
|
|
|
tplIssueChoose base.TplName = "repo/issue/choose"
|
|
|
|
tplIssueView base.TplName = "repo/issue/view"
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2017-12-03 18:14:26 -05:00
|
|
|
tplReactions base.TplName = "repo/issue/view_content/reactions"
|
|
|
|
|
2020-09-11 10:48:39 -04:00
|
|
|
issueTemplateKey = "IssueTemplate"
|
|
|
|
issueTemplateTitleKey = "IssueTemplateTitle"
|
2014-07-26 02:28:04 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2016-11-24 02:04:31 -05:00
|
|
|
// IssueTemplateCandidates issue templates
|
2016-02-17 17:21:31 -05:00
|
|
|
IssueTemplateCandidates = []string{
|
|
|
|
"ISSUE_TEMPLATE.md",
|
2017-01-04 19:48:23 -05:00
|
|
|
"issue_template.md",
|
|
|
|
".gitea/ISSUE_TEMPLATE.md",
|
|
|
|
".gitea/issue_template.md",
|
2016-02-17 17:21:31 -05:00
|
|
|
".github/ISSUE_TEMPLATE.md",
|
2017-01-04 19:48:23 -05:00
|
|
|
".github/issue_template.md",
|
2016-02-17 17:21:31 -05:00
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
)
|
|
|
|
|
2019-02-18 15:55:04 -05:00
|
|
|
// MustAllowUserComment checks to make sure if an issue is locked.
|
|
|
|
// If locked and user has permissions to write to the repository,
|
|
|
|
// then the comment is allowed, else it is blocked
|
|
|
|
func MustAllowUserComment(ctx *context.Context) {
|
|
|
|
issue := GetActionIssue(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-01-20 07:00:32 -05:00
|
|
|
if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.User.IsAdmin {
|
2019-02-18 15:55:04 -05:00
|
|
|
ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))
|
|
|
|
ctx.Redirect(issue.HTMLURL())
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// MustEnableIssues check if repository enable internal issues
|
2016-03-11 11:56:52 -05:00
|
|
|
func MustEnableIssues(ctx *context.Context) {
|
2018-11-28 06:26:14 -05:00
|
|
|
if !ctx.Repo.CanRead(models.UnitTypeIssues) &&
|
|
|
|
!ctx.Repo.CanRead(models.UnitTypeExternalTracker) {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound("MustEnableIssues", nil)
|
2016-03-06 23:57:46 -05:00
|
|
|
return
|
2015-12-04 21:30:33 -05:00
|
|
|
}
|
2016-11-04 04:06:54 -04:00
|
|
|
|
2017-02-04 10:53:46 -05:00
|
|
|
unit, err := ctx.Repo.Repository.GetUnit(models.UnitTypeExternalTracker)
|
|
|
|
if err == nil {
|
|
|
|
ctx.Redirect(unit.ExternalTrackerConfig().ExternalTrackerURL)
|
2016-11-04 04:06:54 -04:00
|
|
|
return
|
|
|
|
}
|
2015-12-04 21:30:33 -05:00
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
// MustAllowPulls check if repository enable pull requests and user have right to do that
|
2016-03-11 11:56:52 -05:00
|
|
|
func MustAllowPulls(ctx *context.Context) {
|
2018-11-28 06:26:14 -05:00
|
|
|
if !ctx.Repo.Repository.CanEnablePulls() || !ctx.Repo.CanRead(models.UnitTypePullRequests) {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound("MustAllowPulls", nil)
|
2016-03-06 23:57:46 -05:00
|
|
|
return
|
2015-12-04 21:30:33 -05:00
|
|
|
}
|
2015-12-19 22:07:06 -05:00
|
|
|
|
2016-03-06 23:57:46 -05:00
|
|
|
// User can send pull request if owns a forked repository.
|
|
|
|
if ctx.IsSigned && ctx.User.HasForkedRepo(ctx.Repo.Repository.ID) {
|
|
|
|
ctx.Repo.PullRequest.Allowed = true
|
|
|
|
ctx.Repo.PullRequest.HeadInfo = ctx.User.Name + ":" + ctx.Repo.BranchName
|
|
|
|
}
|
2015-12-04 21:30:33 -05:00
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
func issues(ctx *context.Context, milestoneID, projectID int64, isPullOption util.OptionalBool) {
|
2018-11-28 20:46:30 -05:00
|
|
|
var err error
|
2021-08-10 20:31:13 -04:00
|
|
|
viewType := ctx.FormString("type")
|
|
|
|
sortType := ctx.FormString("sort")
|
2021-01-17 11:34:19 -05:00
|
|
|
types := []string{"all", "your_repositories", "assigned", "created_by", "mentioned", "review_requested"}
|
2020-12-25 04:59:32 -05:00
|
|
|
if !util.IsStringInSlice(viewType, types, true) {
|
2014-07-26 02:28:04 -04:00
|
|
|
viewType = "all"
|
|
|
|
}
|
|
|
|
|
2015-08-15 00:07:08 -04:00
|
|
|
var (
|
2021-07-28 21:42:15 -04:00
|
|
|
assigneeID = ctx.FormInt64("assignee")
|
2021-01-17 11:34:19 -05:00
|
|
|
posterID int64
|
|
|
|
mentionedID int64
|
|
|
|
reviewRequestedID int64
|
|
|
|
forceEmpty bool
|
2015-08-15 00:07:08 -04:00
|
|
|
)
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2017-06-14 23:09:03 -04:00
|
|
|
if ctx.IsSigned {
|
|
|
|
switch viewType {
|
|
|
|
case "created_by":
|
|
|
|
posterID = ctx.User.ID
|
|
|
|
case "mentioned":
|
|
|
|
mentionedID = ctx.User.ID
|
2020-11-19 16:39:55 -05:00
|
|
|
case "assigned":
|
|
|
|
assigneeID = ctx.User.ID
|
2021-01-17 11:34:19 -05:00
|
|
|
case "review_requested":
|
|
|
|
reviewRequestedID = ctx.User.ID
|
2017-06-14 23:09:03 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-07-24 14:52:25 -04:00
|
|
|
repo := ctx.Repo.Repository
|
2019-01-22 23:10:38 -05:00
|
|
|
var labelIDs []int64
|
2021-08-10 20:31:13 -04:00
|
|
|
selectLabels := ctx.FormString("labels")
|
2019-01-22 23:10:38 -05:00
|
|
|
if len(selectLabels) > 0 && selectLabels != "0" {
|
|
|
|
labelIDs, err = base.StringsToInt64s(strings.Split(selectLabels, ","))
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("StringsToInt64s", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2016-12-24 05:33:21 -05:00
|
|
|
|
2021-08-10 20:31:13 -04:00
|
|
|
keyword := strings.Trim(ctx.FormString("q"), " ")
|
2017-01-24 21:43:02 -05:00
|
|
|
if bytes.Contains([]byte(keyword), []byte{0x00}) {
|
|
|
|
keyword = ""
|
|
|
|
}
|
|
|
|
|
|
|
|
var issueIDs []int64
|
|
|
|
if len(keyword) > 0 {
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 01:06:10 -04:00
|
|
|
issueIDs, err = issue_indexer.SearchIssuesByKeyword([]int64{repo.ID}, keyword)
|
2019-02-19 09:39:39 -05:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("issueIndexer.Search", err)
|
|
|
|
return
|
|
|
|
}
|
2017-01-24 21:43:02 -05:00
|
|
|
if len(issueIDs) == 0 {
|
|
|
|
forceEmpty = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-24 05:33:21 -05:00
|
|
|
var issueStats *models.IssueStats
|
|
|
|
if forceEmpty {
|
|
|
|
issueStats = &models.IssueStats{}
|
|
|
|
} else {
|
2017-01-24 21:43:02 -05:00
|
|
|
issueStats, err = models.GetIssueStats(&models.IssueStatsOptions{
|
2021-01-17 11:34:19 -05:00
|
|
|
RepoID: repo.ID,
|
|
|
|
Labels: selectLabels,
|
|
|
|
MilestoneID: milestoneID,
|
|
|
|
AssigneeID: assigneeID,
|
|
|
|
MentionedID: mentionedID,
|
|
|
|
PosterID: posterID,
|
|
|
|
ReviewRequestedID: reviewRequestedID,
|
|
|
|
IsPull: isPullOption,
|
|
|
|
IssueIDs: issueIDs,
|
2016-12-24 05:33:21 -05:00
|
|
|
})
|
2017-01-24 21:43:02 -05:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetIssueStats", err)
|
2017-01-24 21:43:02 -05:00
|
|
|
return
|
|
|
|
}
|
2016-12-24 05:33:21 -05:00
|
|
|
}
|
2020-07-09 17:13:06 -04:00
|
|
|
|
2021-08-10 20:31:13 -04:00
|
|
|
isShowClosed := ctx.FormString("state") == "closed"
|
2020-07-09 17:13:06 -04:00
|
|
|
// if open issues are zero and close don't, use closed as default
|
2021-08-10 20:31:13 -04:00
|
|
|
if len(ctx.FormString("state")) == 0 && issueStats.OpenCount == 0 && issueStats.ClosedCount != 0 {
|
2020-07-09 17:13:06 -04:00
|
|
|
isShowClosed = true
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
page := ctx.FormInt("page")
|
2015-07-24 04:42:47 -04:00
|
|
|
if page <= 1 {
|
|
|
|
page = 1
|
|
|
|
}
|
2015-07-27 15:14:37 -04:00
|
|
|
|
|
|
|
var total int
|
|
|
|
if !isShowClosed {
|
|
|
|
total = int(issueStats.OpenCount)
|
|
|
|
} else {
|
|
|
|
total = int(issueStats.ClosedCount)
|
2015-07-24 04:42:47 -04:00
|
|
|
}
|
2019-04-20 00:15:19 -04:00
|
|
|
pager := context.NewPagination(total, setting.UI.IssuePagingNum, page, 5)
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2020-04-30 00:15:39 -04:00
|
|
|
var mileIDs []int64
|
|
|
|
if milestoneID > 0 {
|
|
|
|
mileIDs = []int64{milestoneID}
|
|
|
|
}
|
|
|
|
|
2016-12-24 05:33:21 -05:00
|
|
|
var issues []*models.Issue
|
|
|
|
if forceEmpty {
|
|
|
|
issues = []*models.Issue{}
|
|
|
|
} else {
|
|
|
|
issues, err = models.Issues(&models.IssuesOptions{
|
2020-01-24 14:00:29 -05:00
|
|
|
ListOptions: models.ListOptions{
|
|
|
|
Page: pager.Paginater.Current(),
|
|
|
|
PageSize: setting.UI.IssuePagingNum,
|
|
|
|
},
|
2021-01-17 11:34:19 -05:00
|
|
|
RepoIDs: []int64{repo.ID},
|
|
|
|
AssigneeID: assigneeID,
|
|
|
|
PosterID: posterID,
|
|
|
|
MentionedID: mentionedID,
|
|
|
|
ReviewRequestedID: reviewRequestedID,
|
|
|
|
MilestoneIDs: mileIDs,
|
|
|
|
ProjectID: projectID,
|
|
|
|
IsClosed: util.OptionalBoolOf(isShowClosed),
|
|
|
|
IsPull: isPullOption,
|
|
|
|
LabelIDs: labelIDs,
|
|
|
|
SortType: sortType,
|
|
|
|
IssueIDs: issueIDs,
|
2016-12-24 05:33:21 -05:00
|
|
|
})
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("Issues", err)
|
2016-12-24 05:33:21 -05:00
|
|
|
return
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2021-04-15 13:34:43 -04:00
|
|
|
var issueList = models.IssueList(issues)
|
|
|
|
approvalCounts, err := issueList.GetApprovalCounts()
|
2020-03-05 22:44:06 -05:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("ApprovalCounts", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2014-07-26 02:28:04 -04:00
|
|
|
// Get posters.
|
|
|
|
for i := range issues {
|
2017-02-03 02:22:39 -05:00
|
|
|
// Check read status
|
2015-07-24 14:52:25 -04:00
|
|
|
if !ctx.IsSigned {
|
|
|
|
issues[i].IsRead = true
|
2017-02-03 02:22:39 -05:00
|
|
|
} else if err = issues[i].GetIsRead(ctx.User.ID); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetIsRead", err)
|
2017-02-03 02:22:39 -05:00
|
|
|
return
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
2021-04-15 13:34:43 -04:00
|
|
|
}
|
2019-04-02 15:54:29 -04:00
|
|
|
|
2021-04-15 13:34:43 -04:00
|
|
|
commitStatus, err := pull_service.GetIssuesLastCommitStatus(issues)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetIssuesLastCommitStatus", err)
|
|
|
|
return
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
2019-04-02 15:54:29 -04:00
|
|
|
|
2015-08-05 08:23:08 -04:00
|
|
|
ctx.Data["Issues"] = issues
|
2019-04-02 15:54:29 -04:00
|
|
|
ctx.Data["CommitStatus"] = commitStatus
|
2015-08-05 08:23:08 -04:00
|
|
|
|
2018-11-28 20:46:30 -05:00
|
|
|
// Get assignees.
|
|
|
|
ctx.Data["Assignees"], err = repo.GetAssignees()
|
2015-08-05 08:23:08 -04:00
|
|
|
if err != nil {
|
2018-11-28 20:46:30 -05:00
|
|
|
ctx.ServerError("GetAssignees", err)
|
2015-08-05 08:23:08 -04:00
|
|
|
return
|
|
|
|
}
|
2015-08-14 23:24:41 -04:00
|
|
|
|
2020-12-21 10:39:28 -05:00
|
|
|
handleTeamMentions(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-01-24 14:00:29 -05:00
|
|
|
labels, err := models.GetLabelsByRepoID(repo.ID, "", models.ListOptions{})
|
2015-08-14 23:24:41 -04:00
|
|
|
if err != nil {
|
2018-11-28 20:46:30 -05:00
|
|
|
ctx.ServerError("GetLabelsByRepoID", err)
|
2015-08-14 23:24:41 -04:00
|
|
|
return
|
|
|
|
}
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
|
|
|
|
if repo.Owner.IsOrganization() {
|
2021-08-10 20:31:13 -04:00
|
|
|
orgLabels, err := models.GetLabelsByOrgID(repo.Owner.ID, ctx.FormString("sort"), models.ListOptions{})
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetLabelsByOrgID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["OrgLabels"] = orgLabels
|
|
|
|
labels = append(labels, orgLabels...)
|
|
|
|
}
|
|
|
|
|
2019-01-22 23:10:38 -05:00
|
|
|
for _, l := range labels {
|
|
|
|
l.LoadSelectedLabelsAfterClick(labelIDs)
|
|
|
|
}
|
2018-11-28 20:46:30 -05:00
|
|
|
ctx.Data["Labels"] = labels
|
2019-01-22 23:10:38 -05:00
|
|
|
ctx.Data["NumLabels"] = len(labels)
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
if ctx.FormInt64("assignee") == 0 {
|
2016-07-16 21:25:30 -04:00
|
|
|
assigneeID = 0 // Reset ID to prevent unexpected selection of assignee.
|
|
|
|
}
|
|
|
|
|
2020-05-14 18:55:43 -04:00
|
|
|
ctx.Data["IssueRefEndNames"], ctx.Data["IssueRefURLs"] =
|
|
|
|
issue_service.GetRefEndNamesAndURLs(issues, ctx.Repo.RepoLink)
|
|
|
|
|
2020-03-05 22:44:06 -05:00
|
|
|
ctx.Data["ApprovalCounts"] = func(issueID int64, typ string) int64 {
|
|
|
|
counts, ok := approvalCounts[issueID]
|
|
|
|
if !ok || len(counts) == 0 {
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
reviewTyp := models.ReviewTypeApprove
|
|
|
|
if typ == "reject" {
|
|
|
|
reviewTyp = models.ReviewTypeReject
|
2020-04-06 12:33:34 -04:00
|
|
|
} else if typ == "waiting" {
|
|
|
|
reviewTyp = models.ReviewTypeRequest
|
2020-03-05 22:44:06 -05:00
|
|
|
}
|
|
|
|
for _, count := range counts {
|
|
|
|
if count.Type == reviewTyp {
|
|
|
|
return count.Count
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
ctx.Data["IssueStats"] = issueStats
|
2019-12-28 09:43:46 -05:00
|
|
|
ctx.Data["SelLabelIDs"] = labelIDs
|
|
|
|
ctx.Data["SelectLabels"] = selectLabels
|
2014-07-26 02:28:04 -04:00
|
|
|
ctx.Data["ViewType"] = viewType
|
2015-08-15 00:07:08 -04:00
|
|
|
ctx.Data["SortType"] = sortType
|
2015-08-05 08:23:08 -04:00
|
|
|
ctx.Data["MilestoneID"] = milestoneID
|
2015-08-14 23:24:41 -04:00
|
|
|
ctx.Data["AssigneeID"] = assigneeID
|
2014-07-26 02:28:04 -04:00
|
|
|
ctx.Data["IsShowClosed"] = isShowClosed
|
2017-01-24 21:43:02 -05:00
|
|
|
ctx.Data["Keyword"] = keyword
|
2014-07-26 02:28:04 -04:00
|
|
|
if isShowClosed {
|
|
|
|
ctx.Data["State"] = "closed"
|
|
|
|
} else {
|
2015-07-24 14:52:25 -04:00
|
|
|
ctx.Data["State"] = "open"
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
2019-04-20 00:15:19 -04:00
|
|
|
|
|
|
|
pager.AddParam(ctx, "q", "Keyword")
|
|
|
|
pager.AddParam(ctx, "type", "ViewType")
|
|
|
|
pager.AddParam(ctx, "sort", "SortType")
|
|
|
|
pager.AddParam(ctx, "state", "State")
|
|
|
|
pager.AddParam(ctx, "labels", "SelectLabels")
|
|
|
|
pager.AddParam(ctx, "milestone", "MilestoneID")
|
|
|
|
pager.AddParam(ctx, "assignee", "AssigneeID")
|
|
|
|
ctx.Data["Page"] = pager
|
2018-11-28 20:46:30 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// Issues render issues page
|
|
|
|
func Issues(ctx *context.Context) {
|
|
|
|
isPullList := ctx.Params(":type") == "pulls"
|
|
|
|
if isPullList {
|
|
|
|
MustAllowPulls(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["Title"] = ctx.Tr("repo.pulls")
|
|
|
|
ctx.Data["PageIsPullList"] = true
|
|
|
|
} else {
|
|
|
|
MustEnableIssues(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["Title"] = ctx.Tr("repo.issues")
|
|
|
|
ctx.Data["PageIsIssueList"] = true
|
2020-09-11 10:48:39 -04:00
|
|
|
ctx.Data["NewIssueChooseTemplate"] = len(ctx.IssueTemplatesFromDefaultBranch()) > 0
|
2018-11-28 20:46:30 -05:00
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
issues(ctx, ctx.FormInt64("milestone"), ctx.FormInt64("project"), util.OptionalBoolOf(isPullList))
|
2021-05-08 22:33:49 -04:00
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
2018-11-28 20:46:30 -05:00
|
|
|
|
|
|
|
var err error
|
2020-07-28 07:30:40 -04:00
|
|
|
// Get milestones
|
2021-08-12 08:43:08 -04:00
|
|
|
ctx.Data["Milestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
2020-07-28 07:30:40 -04:00
|
|
|
RepoID: ctx.Repo.Repository.ID,
|
2021-08-10 20:31:13 -04:00
|
|
|
State: api.StateType(ctx.FormString("state")),
|
2020-07-28 07:30:40 -04:00
|
|
|
})
|
2018-11-28 20:46:30 -05:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetAllRepoMilestones", err)
|
|
|
|
return
|
|
|
|
}
|
2015-07-24 14:52:25 -04:00
|
|
|
|
2020-01-16 09:18:30 -05:00
|
|
|
ctx.Data["CanWriteIssuesOrPulls"] = ctx.Repo.CanWriteIssuesOrPulls(isPullList)
|
2019-02-19 18:09:47 -05:00
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.HTML(http.StatusOK, tplIssues)
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// RetrieveRepoMilestonesAndAssignees find all the milestones and assignees of a repository
|
2016-03-11 11:56:52 -05:00
|
|
|
func RetrieveRepoMilestonesAndAssignees(ctx *context.Context, repo *models.Repository) {
|
2015-09-01 19:07:02 -04:00
|
|
|
var err error
|
2021-08-12 08:43:08 -04:00
|
|
|
ctx.Data["OpenMilestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
2020-07-28 07:30:40 -04:00
|
|
|
RepoID: repo.ID,
|
|
|
|
State: api.StateOpen,
|
|
|
|
})
|
2015-09-01 19:07:02 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetMilestones", err)
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
}
|
2021-08-12 08:43:08 -04:00
|
|
|
ctx.Data["ClosedMilestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
2020-07-28 07:30:40 -04:00
|
|
|
RepoID: repo.ID,
|
|
|
|
State: api.StateClosed,
|
|
|
|
})
|
2015-09-01 19:07:02 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetMilestones", err)
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["Assignees"], err = repo.GetAssignees()
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetAssignees", err)
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
}
|
2020-12-21 10:39:28 -05:00
|
|
|
|
|
|
|
handleTeamMentions(ctx)
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
func retrieveProjects(ctx *context.Context, repo *models.Repository) {
|
|
|
|
|
|
|
|
var err error
|
|
|
|
|
|
|
|
ctx.Data["OpenProjects"], _, err = models.GetProjects(models.ProjectSearchOptions{
|
|
|
|
RepoID: repo.ID,
|
|
|
|
Page: -1,
|
|
|
|
IsClosed: util.OptionalBoolFalse,
|
|
|
|
Type: models.ProjectTypeRepository,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetProjects", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["ClosedProjects"], _, err = models.GetProjects(models.ProjectSearchOptions{
|
|
|
|
RepoID: repo.ID,
|
|
|
|
Page: -1,
|
|
|
|
IsClosed: util.OptionalBoolTrue,
|
|
|
|
Type: models.ProjectTypeRepository,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetProjects", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
// repoReviewerSelection items to bee shown
|
|
|
|
type repoReviewerSelection struct {
|
|
|
|
IsTeam bool
|
|
|
|
Team *models.Team
|
|
|
|
User *models.User
|
|
|
|
Review *models.Review
|
|
|
|
CanChange bool
|
|
|
|
Checked bool
|
|
|
|
ItemID int64
|
|
|
|
}
|
|
|
|
|
2020-04-06 12:33:34 -04:00
|
|
|
// RetrieveRepoReviewers find all reviewers of a repository
|
2020-10-12 15:55:13 -04:00
|
|
|
func RetrieveRepoReviewers(ctx *context.Context, repo *models.Repository, issue *models.Issue, canChooseReviewer bool) {
|
|
|
|
ctx.Data["CanChooseReviewer"] = canChooseReviewer
|
|
|
|
|
2020-10-14 08:11:11 -04:00
|
|
|
originalAuthorReviews, err := models.GetReviewersFromOriginalAuthorsByIssueID(issue.ID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetReviewersFromOriginalAuthorsByIssueID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["OriginalReviews"] = originalAuthorReviews
|
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
reviews, err := models.GetReviewersByIssueID(issue.ID)
|
2020-04-06 12:33:34 -04:00
|
|
|
if err != nil {
|
2020-10-12 15:55:13 -04:00
|
|
|
ctx.ServerError("GetReviewersByIssueID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(reviews) == 0 && !canChooseReviewer {
|
2020-04-06 12:33:34 -04:00
|
|
|
return
|
|
|
|
}
|
2020-10-12 15:55:13 -04:00
|
|
|
|
|
|
|
var (
|
|
|
|
pullReviews []*repoReviewerSelection
|
|
|
|
reviewersResult []*repoReviewerSelection
|
|
|
|
teamReviewersResult []*repoReviewerSelection
|
|
|
|
teamReviewers []*models.Team
|
|
|
|
reviewers []*models.User
|
|
|
|
)
|
|
|
|
|
|
|
|
if canChooseReviewer {
|
|
|
|
posterID := issue.PosterID
|
|
|
|
if issue.OriginalAuthorID > 0 {
|
|
|
|
posterID = 0
|
|
|
|
}
|
|
|
|
|
|
|
|
reviewers, err = repo.GetReviewers(ctx.User.ID, posterID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetReviewers", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
teamReviewers, err = repo.GetReviewerTeams()
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetReviewerTeams", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(reviewers) > 0 {
|
|
|
|
reviewersResult = make([]*repoReviewerSelection, 0, len(reviewers))
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(teamReviewers) > 0 {
|
|
|
|
teamReviewersResult = make([]*repoReviewerSelection, 0, len(teamReviewers))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pullReviews = make([]*repoReviewerSelection, 0, len(reviews))
|
|
|
|
|
|
|
|
for _, review := range reviews {
|
|
|
|
tmp := &repoReviewerSelection{
|
|
|
|
Checked: review.Type == models.ReviewTypeRequest,
|
|
|
|
Review: review,
|
|
|
|
ItemID: review.ReviewerID,
|
|
|
|
}
|
|
|
|
if review.ReviewerTeamID > 0 {
|
|
|
|
tmp.IsTeam = true
|
|
|
|
tmp.ItemID = -review.ReviewerTeamID
|
|
|
|
}
|
|
|
|
|
|
|
|
if ctx.Repo.IsAdmin() {
|
|
|
|
// Admin can dismiss or re-request any review requests
|
|
|
|
tmp.CanChange = true
|
|
|
|
} else if ctx.User != nil && ctx.User.ID == review.ReviewerID && review.Type == models.ReviewTypeRequest {
|
|
|
|
// A user can refuse review requests
|
|
|
|
tmp.CanChange = true
|
|
|
|
} else if (canChooseReviewer || (ctx.User != nil && ctx.User.ID == issue.PosterID)) && review.Type != models.ReviewTypeRequest &&
|
|
|
|
ctx.User.ID != review.ReviewerID {
|
|
|
|
// The poster of the PR, a manager, or official reviewers can re-request review from other reviewers
|
|
|
|
tmp.CanChange = true
|
|
|
|
}
|
|
|
|
|
|
|
|
pullReviews = append(pullReviews, tmp)
|
|
|
|
|
|
|
|
if canChooseReviewer {
|
|
|
|
if tmp.IsTeam {
|
|
|
|
teamReviewersResult = append(teamReviewersResult, tmp)
|
|
|
|
} else {
|
|
|
|
reviewersResult = append(reviewersResult, tmp)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(pullReviews) > 0 {
|
|
|
|
// Drop all non-existing users and teams from the reviews
|
|
|
|
currentPullReviewers := make([]*repoReviewerSelection, 0, len(pullReviews))
|
|
|
|
for _, item := range pullReviews {
|
|
|
|
if item.Review.ReviewerID > 0 {
|
|
|
|
if err = item.Review.LoadReviewer(); err != nil {
|
|
|
|
if models.IsErrUserNotExist(err) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
ctx.ServerError("LoadReviewer", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
item.User = item.Review.Reviewer
|
|
|
|
} else if item.Review.ReviewerTeamID > 0 {
|
|
|
|
if err = item.Review.LoadReviewerTeam(); err != nil {
|
|
|
|
if models.IsErrTeamNotExist(err) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
ctx.ServerError("LoadReviewerTeam", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
item.Team = item.Review.ReviewerTeam
|
|
|
|
} else {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
currentPullReviewers = append(currentPullReviewers, item)
|
|
|
|
}
|
|
|
|
ctx.Data["PullReviewers"] = currentPullReviewers
|
|
|
|
}
|
|
|
|
|
|
|
|
if canChooseReviewer && reviewersResult != nil {
|
|
|
|
preadded := len(reviewersResult)
|
|
|
|
for _, reviewer := range reviewers {
|
|
|
|
found := false
|
|
|
|
reviewAddLoop:
|
|
|
|
for _, tmp := range reviewersResult[:preadded] {
|
|
|
|
if tmp.ItemID == reviewer.ID {
|
|
|
|
tmp.User = reviewer
|
|
|
|
found = true
|
|
|
|
break reviewAddLoop
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if found {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
reviewersResult = append(reviewersResult, &repoReviewerSelection{
|
|
|
|
IsTeam: false,
|
|
|
|
CanChange: true,
|
|
|
|
User: reviewer,
|
|
|
|
ItemID: reviewer.ID,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["Reviewers"] = reviewersResult
|
|
|
|
}
|
|
|
|
|
|
|
|
if canChooseReviewer && teamReviewersResult != nil {
|
|
|
|
preadded := len(teamReviewersResult)
|
|
|
|
for _, team := range teamReviewers {
|
|
|
|
found := false
|
|
|
|
teamReviewAddLoop:
|
|
|
|
for _, tmp := range teamReviewersResult[:preadded] {
|
|
|
|
if tmp.ItemID == -team.ID {
|
|
|
|
tmp.Team = team
|
|
|
|
found = true
|
|
|
|
break teamReviewAddLoop
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if found {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
teamReviewersResult = append(teamReviewersResult, &repoReviewerSelection{
|
|
|
|
IsTeam: true,
|
|
|
|
CanChange: true,
|
|
|
|
Team: team,
|
|
|
|
ItemID: -team.ID,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["TeamReviewers"] = teamReviewersResult
|
|
|
|
}
|
2020-04-06 12:33:34 -04:00
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// RetrieveRepoMetas find all the meta information of a repository
|
2020-01-19 01:43:38 -05:00
|
|
|
func RetrieveRepoMetas(ctx *context.Context, repo *models.Repository, isPull bool) []*models.Label {
|
2020-01-20 07:00:32 -05:00
|
|
|
if !ctx.Repo.CanWriteIssuesOrPulls(isPull) {
|
2015-08-31 03:24:28 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-01-24 14:00:29 -05:00
|
|
|
labels, err := models.GetLabelsByRepoID(repo.ID, "", models.ListOptions{})
|
2015-08-31 03:24:28 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetLabelsByRepoID", err)
|
2015-08-31 03:24:28 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ctx.Data["Labels"] = labels
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
if repo.Owner.IsOrganization() {
|
2021-08-10 20:31:13 -04:00
|
|
|
orgLabels, err := models.GetLabelsByOrgID(repo.Owner.ID, ctx.FormString("sort"), models.ListOptions{})
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
if err != nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["OrgLabels"] = orgLabels
|
|
|
|
labels = append(labels, orgLabels...)
|
|
|
|
}
|
2015-08-31 03:24:28 -04:00
|
|
|
|
2015-09-01 19:07:02 -04:00
|
|
|
RetrieveRepoMilestonesAndAssignees(ctx, repo)
|
|
|
|
if ctx.Written() {
|
2015-08-31 03:24:28 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
retrieveProjects(ctx, repo)
|
|
|
|
if ctx.Written() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-02-03 14:06:13 -05:00
|
|
|
brs, _, err := ctx.Repo.GitRepo.GetBranches(0, 0)
|
2017-08-24 08:30:27 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetBranches", err)
|
2017-08-24 08:30:27 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ctx.Data["Branches"] = brs
|
|
|
|
|
2018-07-17 17:23:58 -04:00
|
|
|
// Contains true if the user can create issue dependencies
|
2020-01-19 01:43:38 -05:00
|
|
|
ctx.Data["CanCreateIssueDependencies"] = ctx.Repo.CanCreateIssueDependencies(ctx.User, isPull)
|
2018-07-17 17:23:58 -04:00
|
|
|
|
2015-08-31 03:24:28 -04:00
|
|
|
return labels
|
|
|
|
}
|
|
|
|
|
2016-03-11 11:56:52 -05:00
|
|
|
func getFileContentFromDefaultBranch(ctx *context.Context, filename string) (string, bool) {
|
2016-02-17 17:21:31 -05:00
|
|
|
var bytes []byte
|
|
|
|
|
|
|
|
if ctx.Repo.Commit == nil {
|
|
|
|
var err error
|
|
|
|
ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)
|
|
|
|
if err != nil {
|
|
|
|
return "", false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
entry, err := ctx.Repo.Commit.GetTreeEntryByPath(filename)
|
|
|
|
if err != nil {
|
|
|
|
return "", false
|
|
|
|
}
|
2017-11-28 20:50:39 -05:00
|
|
|
if entry.Blob().Size() >= setting.UI.MaxDisplayFileSize {
|
|
|
|
return "", false
|
|
|
|
}
|
2019-04-19 08:17:27 -04:00
|
|
|
r, err := entry.Blob().DataAsync()
|
2016-02-17 17:21:31 -05:00
|
|
|
if err != nil {
|
|
|
|
return "", false
|
|
|
|
}
|
2019-04-19 08:17:27 -04:00
|
|
|
defer r.Close()
|
2021-09-22 01:38:34 -04:00
|
|
|
bytes, err = io.ReadAll(r)
|
2016-02-17 17:21:31 -05:00
|
|
|
if err != nil {
|
|
|
|
return "", false
|
|
|
|
}
|
|
|
|
return string(bytes), true
|
|
|
|
}
|
|
|
|
|
2020-09-11 10:48:39 -04:00
|
|
|
func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleDirs []string, possibleFiles []string) {
|
|
|
|
templateCandidates := make([]string, 0, len(possibleFiles))
|
2021-08-10 20:31:13 -04:00
|
|
|
if ctx.FormString("template") != "" {
|
2020-09-11 10:48:39 -04:00
|
|
|
for _, dirName := range possibleDirs {
|
2021-08-10 20:31:13 -04:00
|
|
|
templateCandidates = append(templateCandidates, path.Join(dirName, ctx.FormString("template")))
|
2020-09-11 10:48:39 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
templateCandidates = append(templateCandidates, possibleFiles...) // Append files to the end because they should be fallback
|
|
|
|
for _, filename := range templateCandidates {
|
|
|
|
templateContent, found := getFileContentFromDefaultBranch(ctx, filename)
|
2016-02-17 17:21:31 -05:00
|
|
|
if found {
|
2020-09-11 10:48:39 -04:00
|
|
|
var meta api.IssueTemplate
|
|
|
|
templateBody, err := markdown.ExtractMetadata(templateContent, &meta)
|
|
|
|
if err != nil {
|
|
|
|
log.Debug("could not extract metadata from %s [%s]: %v", filename, ctx.Repo.Repository.FullName(), err)
|
|
|
|
ctx.Data[ctxDataKey] = templateContent
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data[issueTemplateTitleKey] = meta.Title
|
|
|
|
ctx.Data[ctxDataKey] = templateBody
|
|
|
|
labelIDs := make([]string, 0, len(meta.Labels))
|
|
|
|
if repoLabels, err := models.GetLabelsByRepoID(ctx.Repo.Repository.ID, "", models.ListOptions{}); err == nil {
|
2021-02-10 12:18:22 -05:00
|
|
|
ctx.Data["Labels"] = repoLabels
|
|
|
|
if ctx.Repo.Owner.IsOrganization() {
|
2021-08-10 20:31:13 -04:00
|
|
|
if orgLabels, err := models.GetLabelsByOrgID(ctx.Repo.Owner.ID, ctx.FormString("sort"), models.ListOptions{}); err == nil {
|
2021-02-10 12:18:22 -05:00
|
|
|
ctx.Data["OrgLabels"] = orgLabels
|
|
|
|
repoLabels = append(repoLabels, orgLabels...)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-09-11 10:48:39 -04:00
|
|
|
for _, metaLabel := range meta.Labels {
|
|
|
|
for _, repoLabel := range repoLabels {
|
|
|
|
if strings.EqualFold(repoLabel.Name, metaLabel) {
|
|
|
|
repoLabel.IsChecked = true
|
|
|
|
labelIDs = append(labelIDs, fmt.Sprintf("%d", repoLabel.ID))
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0
|
|
|
|
ctx.Data["label_ids"] = strings.Join(labelIDs, ",")
|
2016-02-17 17:21:31 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-01-21 06:45:32 -05:00
|
|
|
// NewIssue render creating issue page
|
2016-03-11 11:56:52 -05:00
|
|
|
func NewIssue(ctx *context.Context) {
|
2015-08-09 03:23:02 -04:00
|
|
|
ctx.Data["Title"] = ctx.Tr("repo.issues.new")
|
|
|
|
ctx.Data["PageIsIssueList"] = true
|
2020-09-11 10:48:39 -04:00
|
|
|
ctx.Data["NewIssueChooseTemplate"] = len(ctx.IssueTemplatesFromDefaultBranch()) > 0
|
2016-08-25 00:35:03 -04:00
|
|
|
ctx.Data["RequireHighlightJS"] = true
|
|
|
|
ctx.Data["RequireSimpleMDE"] = true
|
2017-12-11 01:03:04 -05:00
|
|
|
ctx.Data["RequireTribute"] = true
|
2018-08-13 15:04:39 -04:00
|
|
|
ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes
|
2021-08-10 20:31:13 -04:00
|
|
|
title := ctx.FormString("title")
|
2020-09-11 10:48:39 -04:00
|
|
|
ctx.Data["TitleQuery"] = title
|
2021-08-10 20:31:13 -04:00
|
|
|
body := ctx.FormString("body")
|
2019-01-28 10:23:59 -05:00
|
|
|
ctx.Data["BodyQuery"] = body
|
2021-03-17 22:02:38 -04:00
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
ctx.Data["IsProjectsEnabled"] = ctx.Repo.CanRead(models.UnitTypeProjects)
|
2020-10-05 01:49:33 -04:00
|
|
|
ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled
|
|
|
|
upload.AddUploadContext(ctx, "comment")
|
2018-11-28 20:46:30 -05:00
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
milestoneID := ctx.FormInt64("milestone")
|
2019-06-10 10:16:02 -04:00
|
|
|
if milestoneID > 0 {
|
|
|
|
milestone, err := models.GetMilestoneByID(milestoneID)
|
|
|
|
if err != nil {
|
|
|
|
log.Error("GetMilestoneByID: %d: %v", milestoneID, err)
|
|
|
|
} else {
|
|
|
|
ctx.Data["milestone_id"] = milestoneID
|
|
|
|
ctx.Data["Milestone"] = milestone
|
|
|
|
}
|
2018-11-28 20:46:30 -05:00
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
projectID := ctx.FormInt64("project")
|
2020-08-16 23:07:38 -04:00
|
|
|
if projectID > 0 {
|
|
|
|
project, err := models.GetProjectByID(projectID)
|
|
|
|
if err != nil {
|
|
|
|
log.Error("GetProjectByID: %d: %v", projectID, err)
|
|
|
|
} else if project.RepoID != ctx.Repo.Repository.ID {
|
|
|
|
log.Error("GetProjectByID: %d: %v", projectID, fmt.Errorf("project[%d] not in repo [%d]", project.ID, ctx.Repo.Repository.ID))
|
|
|
|
} else {
|
|
|
|
ctx.Data["project_id"] = projectID
|
|
|
|
ctx.Data["Project"] = project
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2020-01-19 01:43:38 -05:00
|
|
|
RetrieveRepoMetas(ctx, ctx.Repo.Repository, false)
|
2020-09-11 10:48:39 -04:00
|
|
|
setTemplateIfExists(ctx, issueTemplateKey, context.IssueTemplateDirCandidates, IssueTemplateCandidates)
|
2015-08-31 03:24:28 -04:00
|
|
|
if ctx.Written() {
|
|
|
|
return
|
2015-08-10 06:57:57 -04:00
|
|
|
}
|
2015-08-09 03:23:02 -04:00
|
|
|
|
2020-04-04 01:39:48 -04:00
|
|
|
ctx.Data["HasIssuesOrPullsWritePermission"] = ctx.Repo.CanWrite(models.UnitTypeIssues)
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.HTML(http.StatusOK, tplIssueNew)
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2020-09-11 10:48:39 -04:00
|
|
|
// NewIssueChooseTemplate render creating issue from template page
|
|
|
|
func NewIssueChooseTemplate(ctx *context.Context) {
|
|
|
|
ctx.Data["Title"] = ctx.Tr("repo.issues.new")
|
|
|
|
ctx.Data["PageIsIssueList"] = true
|
2021-07-28 21:42:15 -04:00
|
|
|
ctx.Data["milestone"] = ctx.FormInt64("milestone")
|
2020-09-11 10:48:39 -04:00
|
|
|
|
|
|
|
issueTemplates := ctx.IssueTemplatesFromDefaultBranch()
|
|
|
|
ctx.Data["NewIssueChooseTemplate"] = len(issueTemplates) > 0
|
|
|
|
ctx.Data["IssueTemplates"] = issueTemplates
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.HTML(http.StatusOK, tplIssueChoose)
|
2020-09-11 10:48:39 -04:00
|
|
|
}
|
|
|
|
|
2021-07-08 07:38:13 -04:00
|
|
|
// ValidateRepoMetas check and returns repository's meta information
|
2021-04-06 15:44:05 -04:00
|
|
|
func ValidateRepoMetas(ctx *context.Context, form forms.CreateIssueForm, isPull bool) ([]int64, []int64, int64, int64) {
|
2015-09-01 19:07:02 -04:00
|
|
|
var (
|
|
|
|
repo = ctx.Repo.Repository
|
|
|
|
err error
|
|
|
|
)
|
|
|
|
|
2020-01-19 01:43:38 -05:00
|
|
|
labels := RetrieveRepoMetas(ctx, ctx.Repo.Repository, isPull)
|
2015-09-01 19:07:02 -04:00
|
|
|
if ctx.Written() {
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
|
2017-01-31 21:36:08 -05:00
|
|
|
var labelIDs []int64
|
2015-09-01 19:07:02 -04:00
|
|
|
hasSelected := false
|
2017-01-31 21:36:08 -05:00
|
|
|
// Check labels.
|
|
|
|
if len(form.LabelIDs) > 0 {
|
|
|
|
labelIDs, err = base.StringsToInt64s(strings.Split(form.LabelIDs, ","))
|
|
|
|
if err != nil {
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2017-01-31 21:36:08 -05:00
|
|
|
}
|
|
|
|
labelIDMark := base.Int64sToMap(labelIDs)
|
|
|
|
|
|
|
|
for i := range labels {
|
|
|
|
if labelIDMark[labels[i].ID] {
|
|
|
|
labels[i].IsChecked = true
|
|
|
|
hasSelected = true
|
|
|
|
}
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
}
|
2017-01-31 21:36:08 -05:00
|
|
|
|
|
|
|
ctx.Data["Labels"] = labels
|
2015-09-01 19:07:02 -04:00
|
|
|
ctx.Data["HasSelectedLabel"] = hasSelected
|
|
|
|
ctx.Data["label_ids"] = form.LabelIDs
|
|
|
|
|
|
|
|
// Check milestone.
|
|
|
|
milestoneID := form.MilestoneID
|
|
|
|
if milestoneID > 0 {
|
|
|
|
ctx.Data["Milestone"], err = repo.GetMilestoneByID(milestoneID)
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetMilestoneByID", err)
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
ctx.Data["milestone_id"] = milestoneID
|
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
if form.ProjectID > 0 {
|
|
|
|
p, err := models.GetProjectByID(form.ProjectID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetProjectByID", err)
|
|
|
|
return nil, nil, 0, 0
|
|
|
|
}
|
|
|
|
if p.RepoID != ctx.Repo.Repository.ID {
|
|
|
|
ctx.NotFound("", nil)
|
|
|
|
return nil, nil, 0, 0
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["Project"] = p
|
|
|
|
ctx.Data["project_id"] = form.ProjectID
|
|
|
|
}
|
|
|
|
|
2018-05-09 12:29:04 -04:00
|
|
|
// Check assignees
|
|
|
|
var assigneeIDs []int64
|
|
|
|
if len(form.AssigneeIDs) > 0 {
|
|
|
|
assigneeIDs, err = base.StringsToInt64s(strings.Split(form.AssigneeIDs, ","))
|
2015-09-01 19:07:02 -04:00
|
|
|
if err != nil {
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2018-05-09 12:29:04 -04:00
|
|
|
}
|
|
|
|
|
2019-10-25 10:46:37 -04:00
|
|
|
// Check if the passed assignees actually exists and is assignable
|
2018-05-09 12:29:04 -04:00
|
|
|
for _, aID := range assigneeIDs {
|
2019-10-25 10:46:37 -04:00
|
|
|
assignee, err := models.GetUserByID(aID)
|
2018-11-28 06:26:14 -05:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetUserByID", err)
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2018-11-28 06:26:14 -05:00
|
|
|
}
|
|
|
|
|
2019-10-25 10:46:37 -04:00
|
|
|
valid, err := models.CanBeAssigned(assignee, repo, isPull)
|
2018-05-09 12:29:04 -04:00
|
|
|
if err != nil {
|
2020-08-16 23:07:38 -04:00
|
|
|
ctx.ServerError("CanBeAssigned", err)
|
|
|
|
return nil, nil, 0, 0
|
2018-11-28 06:26:14 -05:00
|
|
|
}
|
2020-08-16 23:07:38 -04:00
|
|
|
|
2019-10-25 10:46:37 -04:00
|
|
|
if !valid {
|
|
|
|
ctx.ServerError("canBeAssigned", models.ErrUserDoesNotHaveAccessToRepo{UserID: aID, RepoName: repo.Name})
|
2020-08-16 23:07:38 -04:00
|
|
|
return nil, nil, 0, 0
|
2018-05-09 12:29:04 -04:00
|
|
|
}
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-09 12:29:04 -04:00
|
|
|
// Keep the old assignee id thingy for compatibility reasons
|
|
|
|
if form.AssigneeID > 0 {
|
|
|
|
assigneeIDs = append(assigneeIDs, form.AssigneeID)
|
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
return labelIDs, assigneeIDs, milestoneID, form.ProjectID
|
2015-09-01 19:07:02 -04:00
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// NewIssuePost response for creating new issue
|
2021-01-26 10:36:53 -05:00
|
|
|
func NewIssuePost(ctx *context.Context) {
|
2021-04-06 15:44:05 -04:00
|
|
|
form := web.GetForm(ctx).(*forms.CreateIssueForm)
|
2015-08-09 03:23:02 -04:00
|
|
|
ctx.Data["Title"] = ctx.Tr("repo.issues.new")
|
|
|
|
ctx.Data["PageIsIssueList"] = true
|
2020-09-11 10:48:39 -04:00
|
|
|
ctx.Data["NewIssueChooseTemplate"] = len(ctx.IssueTemplatesFromDefaultBranch()) > 0
|
2016-08-11 08:48:08 -04:00
|
|
|
ctx.Data["RequireHighlightJS"] = true
|
|
|
|
ctx.Data["RequireSimpleMDE"] = true
|
2017-08-24 08:30:27 -04:00
|
|
|
ctx.Data["ReadOnly"] = false
|
2018-08-13 15:04:39 -04:00
|
|
|
ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes
|
2020-10-05 01:49:33 -04:00
|
|
|
ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled
|
|
|
|
upload.AddUploadContext(ctx, "comment")
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2015-08-10 04:52:08 -04:00
|
|
|
var (
|
2015-08-10 06:57:57 -04:00
|
|
|
repo = ctx.Repo.Repository
|
2015-08-11 11:24:40 -04:00
|
|
|
attachments []string
|
2015-08-10 04:52:08 -04:00
|
|
|
)
|
2015-08-31 03:24:28 -04:00
|
|
|
|
2021-01-26 10:36:53 -05:00
|
|
|
labelIDs, assigneeIDs, milestoneID, projectID := ValidateRepoMetas(ctx, *form, false)
|
2015-09-01 19:07:02 -04:00
|
|
|
if ctx.Written() {
|
|
|
|
return
|
2015-08-10 04:52:08 -04:00
|
|
|
}
|
|
|
|
|
2020-08-18 00:23:45 -04:00
|
|
|
if setting.Attachment.Enabled {
|
2016-08-11 08:48:08 -04:00
|
|
|
attachments = form.Files
|
2015-08-11 11:24:40 -04:00
|
|
|
}
|
|
|
|
|
2014-07-26 02:28:04 -04:00
|
|
|
if ctx.HasError() {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.HTML(http.StatusOK, tplIssueNew)
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2019-01-21 06:45:32 -05:00
|
|
|
if util.IsEmptyString(form.Title) {
|
|
|
|
ctx.RenderWithErr(ctx.Tr("repo.issues.new.title_empty"), tplIssueNew, form)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2014-07-26 02:28:04 -04:00
|
|
|
issue := &models.Issue{
|
2016-03-13 23:20:22 -04:00
|
|
|
RepoID: repo.ID,
|
2016-08-14 06:32:24 -04:00
|
|
|
Title: form.Title,
|
2016-07-23 13:08:22 -04:00
|
|
|
PosterID: ctx.User.ID,
|
2015-08-10 11:31:59 -04:00
|
|
|
Poster: ctx.User,
|
2015-08-10 06:57:57 -04:00
|
|
|
MilestoneID: milestoneID,
|
2015-08-10 09:47:23 -04:00
|
|
|
Content: form.Content,
|
2017-08-24 08:30:27 -04:00
|
|
|
Ref: form.Ref,
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
|
2019-10-28 12:45:43 -04:00
|
|
|
if err := issue_service.NewIssue(repo, issue, labelIDs, attachments, assigneeIDs); err != nil {
|
2018-05-09 12:29:04 -04:00
|
|
|
if models.IsErrUserDoesNotHaveAccessToRepo(err) {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusBadRequest, "UserDoesNotHaveAccessToRepo", err.Error())
|
2018-05-09 12:29:04 -04:00
|
|
|
return
|
|
|
|
}
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("NewIssue", err)
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
2015-08-10 11:31:59 -04:00
|
|
|
}
|
|
|
|
|
2020-08-16 23:07:38 -04:00
|
|
|
if projectID > 0 {
|
|
|
|
if err := models.ChangeProjectAssign(issue, ctx.User, projectID); err != nil {
|
|
|
|
ctx.ServerError("ChangeProjectAssign", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-09-01 19:07:02 -04:00
|
|
|
log.Trace("Issue created: %d/%d", repo.ID, issue.ID)
|
2020-12-25 04:59:32 -05:00
|
|
|
ctx.Redirect(ctx.Repo.RepoLink + "/issues/" + fmt.Sprint(issue.Index))
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2017-12-21 02:43:26 -05:00
|
|
|
// commentTag returns the CommentTag for a comment in/with the given repo, poster and issue
|
|
|
|
func commentTag(repo *models.Repository, poster *models.User, issue *models.Issue) (models.CommentTag, error) {
|
2018-11-28 06:26:14 -05:00
|
|
|
perm, err := models.GetUserRepoPermission(repo, poster)
|
|
|
|
if err != nil {
|
|
|
|
return models.CommentTagNone, err
|
2017-12-21 02:43:26 -05:00
|
|
|
}
|
2018-11-28 06:26:14 -05:00
|
|
|
if perm.IsOwner() {
|
2020-11-28 10:52:29 -05:00
|
|
|
if !poster.IsAdmin {
|
|
|
|
return models.CommentTagOwner, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ok, err := models.IsUserRealRepoAdmin(repo, poster)
|
|
|
|
if err != nil {
|
|
|
|
return models.CommentTagNone, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if ok {
|
|
|
|
return models.CommentTagOwner, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if ok, err = repo.IsCollaborator(poster.ID); ok && err == nil {
|
|
|
|
return models.CommentTagWriter, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
return models.CommentTagNone, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if perm.CanWrite(models.UnitTypeCode) {
|
2018-11-28 06:26:14 -05:00
|
|
|
return models.CommentTagWriter, nil
|
2017-12-21 02:43:26 -05:00
|
|
|
}
|
2018-11-28 06:26:14 -05:00
|
|
|
|
2017-12-21 02:43:26 -05:00
|
|
|
return models.CommentTagNone, nil
|
|
|
|
}
|
|
|
|
|
2019-12-16 01:20:25 -05:00
|
|
|
func getBranchData(ctx *context.Context, issue *models.Issue) {
|
|
|
|
ctx.Data["BaseBranch"] = nil
|
|
|
|
ctx.Data["HeadBranch"] = nil
|
|
|
|
ctx.Data["HeadUserName"] = nil
|
|
|
|
ctx.Data["BaseName"] = ctx.Repo.Repository.OwnerName
|
|
|
|
if issue.IsPull {
|
|
|
|
pull := issue.PullRequest
|
|
|
|
ctx.Data["BaseBranch"] = pull.BaseBranch
|
|
|
|
ctx.Data["HeadBranch"] = pull.HeadBranch
|
|
|
|
ctx.Data["HeadUserName"] = pull.MustHeadUserName()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// ViewIssue render issue view page
|
2016-03-11 11:56:52 -05:00
|
|
|
func ViewIssue(ctx *context.Context) {
|
2019-12-13 19:53:32 -05:00
|
|
|
if ctx.Params(":type") == "issues" {
|
|
|
|
// If issue was requested we check if repo has external tracker and redirect
|
|
|
|
extIssueUnit, err := ctx.Repo.Repository.GetUnit(models.UnitTypeExternalTracker)
|
|
|
|
if err == nil && extIssueUnit != nil {
|
|
|
|
if extIssueUnit.ExternalTrackerConfig().ExternalTrackerStyle == markup.IssueNameStyleNumeric || extIssueUnit.ExternalTrackerConfig().ExternalTrackerStyle == "" {
|
|
|
|
metas := ctx.Repo.Repository.ComposeMetas()
|
|
|
|
metas["index"] = ctx.Params(":index")
|
|
|
|
ctx.Redirect(com.Expand(extIssueUnit.ExternalTrackerConfig().ExternalTrackerFormat, metas))
|
|
|
|
return
|
|
|
|
}
|
|
|
|
} else if err != nil && !models.IsErrUnitTypeNotExist(err) {
|
|
|
|
ctx.ServerError("GetUnit", err)
|
2019-12-06 23:21:18 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-12 05:04:23 -04:00
|
|
|
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
|
2014-07-26 02:28:04 -04:00
|
|
|
if err != nil {
|
2015-08-12 05:04:23 -04:00
|
|
|
if models.IsErrIssueNotExist(err) {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound("GetIssueByIndex", err)
|
2014-07-26 02:28:04 -04:00
|
|
|
} else {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetIssueByIndex", err)
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
2017-03-29 19:31:47 -04:00
|
|
|
|
2015-09-01 19:07:02 -04:00
|
|
|
// Make sure type and URL matches.
|
|
|
|
if ctx.Params(":type") == "issues" && issue.IsPull {
|
2020-12-25 04:59:32 -05:00
|
|
|
ctx.Redirect(ctx.Repo.RepoLink + "/pulls/" + fmt.Sprint(issue.Index))
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
} else if ctx.Params(":type") == "pulls" && !issue.IsPull {
|
2020-12-25 04:59:32 -05:00
|
|
|
ctx.Redirect(ctx.Repo.RepoLink + "/issues/" + fmt.Sprint(issue.Index))
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2015-09-02 04:08:05 -04:00
|
|
|
if issue.IsPull {
|
2016-03-06 23:57:46 -05:00
|
|
|
MustAllowPulls(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["PageIsPullList"] = true
|
2015-09-02 04:08:05 -04:00
|
|
|
ctx.Data["PageIsPullConversation"] = true
|
|
|
|
} else {
|
2015-12-04 21:30:33 -05:00
|
|
|
MustEnableIssues(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
2015-09-02 04:08:05 -04:00
|
|
|
ctx.Data["PageIsIssueList"] = true
|
2020-09-11 10:48:39 -04:00
|
|
|
ctx.Data["NewIssueChooseTemplate"] = len(ctx.IssueTemplatesFromDefaultBranch()) > 0
|
2015-09-02 04:08:05 -04:00
|
|
|
}
|
|
|
|
|
2020-01-19 01:43:38 -05:00
|
|
|
if issue.IsPull && !ctx.Repo.CanRead(models.UnitTypeIssues) {
|
|
|
|
ctx.Data["IssueType"] = "pulls"
|
|
|
|
} else if !issue.IsPull && !ctx.Repo.CanRead(models.UnitTypePullRequests) {
|
|
|
|
ctx.Data["IssueType"] = "issues"
|
|
|
|
} else {
|
|
|
|
ctx.Data["IssueType"] = "all"
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
ctx.Data["RequireHighlightJS"] = true
|
|
|
|
ctx.Data["RequireTribute"] = true
|
2019-12-16 10:56:35 -05:00
|
|
|
ctx.Data["RequireSimpleMDE"] = true
|
2020-08-16 23:07:38 -04:00
|
|
|
ctx.Data["IsProjectsEnabled"] = ctx.Repo.CanRead(models.UnitTypeProjects)
|
2020-10-05 01:49:33 -04:00
|
|
|
ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled
|
|
|
|
upload.AddUploadContext(ctx, "comment")
|
2018-11-28 06:26:14 -05:00
|
|
|
|
2019-09-20 01:45:38 -04:00
|
|
|
if err = issue.LoadAttributes(); err != nil {
|
|
|
|
ctx.ServerError("LoadAttributes", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if err = filterXRefComments(ctx, issue); err != nil {
|
|
|
|
ctx.ServerError("filterXRefComments", err)
|
2018-12-13 10:55:43 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
ctx.Data["Title"] = fmt.Sprintf("#%d - %s", issue.Index, issue.Title)
|
|
|
|
|
2020-04-21 09:48:53 -04:00
|
|
|
iw := new(models.IssueWatch)
|
2018-11-28 06:26:14 -05:00
|
|
|
if ctx.User != nil {
|
2020-04-21 09:48:53 -04:00
|
|
|
iw.UserID = ctx.User.ID
|
|
|
|
iw.IssueID = issue.ID
|
|
|
|
iw.IsWatching, err = models.CheckIssueWatch(ctx.User, issue)
|
2018-11-28 06:26:14 -05:00
|
|
|
if err != nil {
|
2021-01-14 15:27:22 -05:00
|
|
|
ctx.ServerError("CheckIssueWatch", err)
|
2018-11-28 06:26:14 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ctx.Data["IssueWatch"] = iw
|
|
|
|
|
2021-04-19 18:25:08 -04:00
|
|
|
issue.RenderedContent, err = markdown.RenderString(&markup.RenderContext{
|
|
|
|
URLPrefix: ctx.Repo.RepoLink,
|
|
|
|
Metas: ctx.Repo.Repository.ComposeMetas(),
|
2021-06-20 18:39:12 -04:00
|
|
|
GitRepo: ctx.Repo.GitRepo,
|
2021-08-28 16:15:56 -04:00
|
|
|
Ctx: ctx,
|
2021-04-19 18:25:08 -04:00
|
|
|
}, issue.Content)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("RenderString", err)
|
|
|
|
return
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2015-08-14 12:42:43 -04:00
|
|
|
repo := ctx.Repo.Repository
|
|
|
|
|
2015-09-01 19:07:02 -04:00
|
|
|
// Get more information if it's a pull request.
|
|
|
|
if issue.IsPull {
|
2016-08-16 13:19:09 -04:00
|
|
|
if issue.PullRequest.HasMerged {
|
|
|
|
ctx.Data["DisableStatusChange"] = issue.PullRequest.HasMerged
|
2015-09-02 09:26:56 -04:00
|
|
|
PrepareMergedViewPullInfo(ctx, issue)
|
|
|
|
} else {
|
|
|
|
PrepareViewPullInfo(ctx, issue)
|
2019-04-20 16:50:34 -04:00
|
|
|
ctx.Data["DisableStatusChange"] = ctx.Data["IsPullRequestBroken"] == true && issue.IsClosed
|
2015-09-02 09:26:56 -04:00
|
|
|
}
|
2015-09-02 04:08:05 -04:00
|
|
|
if ctx.Written() {
|
2015-09-01 19:07:02 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-12 05:04:23 -04:00
|
|
|
// Metas.
|
2015-08-14 12:42:43 -04:00
|
|
|
// Check labels.
|
|
|
|
labelIDMark := make(map[int64]bool)
|
|
|
|
for i := range issue.Labels {
|
|
|
|
labelIDMark[issue.Labels[i].ID] = true
|
|
|
|
}
|
2020-01-24 14:00:29 -05:00
|
|
|
labels, err := models.GetLabelsByRepoID(repo.ID, "", models.ListOptions{})
|
2015-08-14 12:42:43 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetLabelsByRepoID", err)
|
2015-08-14 12:42:43 -04:00
|
|
|
return
|
|
|
|
}
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
ctx.Data["Labels"] = labels
|
|
|
|
|
|
|
|
if repo.Owner.IsOrganization() {
|
2021-08-10 20:31:13 -04:00
|
|
|
orgLabels, err := models.GetLabelsByOrgID(repo.Owner.ID, ctx.FormString("sort"), models.ListOptions{})
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 00:14:46 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetLabelsByOrgID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["OrgLabels"] = orgLabels
|
|
|
|
|
|
|
|
labels = append(labels, orgLabels...)
|
|
|
|
}
|
|
|
|
|
2015-08-14 12:42:43 -04:00
|
|
|
hasSelected := false
|
|
|
|
for i := range labels {
|
|
|
|
if labelIDMark[labels[i].ID] {
|
|
|
|
labels[i].IsChecked = true
|
|
|
|
hasSelected = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ctx.Data["HasSelectedLabel"] = hasSelected
|
|
|
|
|
|
|
|
// Check milestone and assignee.
|
2018-11-28 06:26:14 -05:00
|
|
|
if ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) {
|
2015-09-01 19:07:02 -04:00
|
|
|
RetrieveRepoMilestonesAndAssignees(ctx, repo)
|
2020-08-16 23:07:38 -04:00
|
|
|
retrieveProjects(ctx, repo)
|
|
|
|
|
2015-09-01 19:07:02 -04:00
|
|
|
if ctx.Written() {
|
2015-08-14 12:42:43 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2020-04-06 12:33:34 -04:00
|
|
|
if issue.IsPull {
|
|
|
|
canChooseReviewer := ctx.Repo.CanWrite(models.UnitTypePullRequests)
|
|
|
|
if !canChooseReviewer && ctx.User != nil && ctx.IsSigned {
|
|
|
|
canChooseReviewer, err = models.IsOfficialReviewer(issue, ctx.User)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("IsOfficialReviewer", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
RetrieveRepoReviewers(ctx, repo, issue, canChooseReviewer)
|
2020-04-06 12:33:34 -04:00
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-12 05:04:23 -04:00
|
|
|
if ctx.IsSigned {
|
2015-08-12 06:44:09 -04:00
|
|
|
// Update issue-user.
|
2016-07-23 13:08:22 -04:00
|
|
|
if err = issue.ReadBy(ctx.User.ID); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ReadBy", err)
|
2015-08-12 06:44:09 -04:00
|
|
|
return
|
|
|
|
}
|
2015-08-12 05:04:23 -04:00
|
|
|
}
|
|
|
|
|
2015-08-13 14:43:40 -04:00
|
|
|
var (
|
2016-01-19 08:04:24 -05:00
|
|
|
tag models.CommentTag
|
|
|
|
ok bool
|
|
|
|
marked = make(map[int64]models.CommentTag)
|
|
|
|
comment *models.Comment
|
2016-02-01 20:55:12 -05:00
|
|
|
participants = make([]*models.User, 1, 10)
|
2015-08-13 14:43:40 -04:00
|
|
|
)
|
2017-09-12 02:48:13 -04:00
|
|
|
if ctx.Repo.Repository.IsTimetrackerEnabled() {
|
|
|
|
if ctx.IsSigned {
|
|
|
|
// Deal with the stopwatch
|
|
|
|
ctx.Data["IsStopwatchRunning"] = models.StopwatchExists(ctx.User.ID, issue.ID)
|
|
|
|
if !ctx.Data["IsStopwatchRunning"].(bool) {
|
|
|
|
var exists bool
|
|
|
|
var sw *models.Stopwatch
|
|
|
|
if exists, sw, err = models.HasUserStopwatch(ctx.User.ID); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("HasUserStopwatch", err)
|
2017-09-12 02:48:13 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["HasUserStopwatch"] = exists
|
|
|
|
if exists {
|
|
|
|
// Add warning if the user has already a stopwatch
|
|
|
|
var otherIssue *models.Issue
|
|
|
|
if otherIssue, err = models.GetIssueByID(sw.IssueID); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetIssueByID", err)
|
2017-09-12 02:48:13 -04:00
|
|
|
return
|
|
|
|
}
|
2018-12-13 10:55:43 -05:00
|
|
|
if err = otherIssue.LoadRepo(); err != nil {
|
|
|
|
ctx.ServerError("LoadRepo", err)
|
|
|
|
return
|
|
|
|
}
|
2017-09-12 02:48:13 -04:00
|
|
|
// Add link to the issue of the already running stopwatch
|
|
|
|
ctx.Data["OtherStopwatchURL"] = otherIssue.HTMLURL()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ctx.Data["CanUseTimetracker"] = ctx.Repo.CanUseTimetracker(issue, ctx.User)
|
|
|
|
} else {
|
|
|
|
ctx.Data["CanUseTimetracker"] = false
|
|
|
|
}
|
2021-08-12 08:43:08 -04:00
|
|
|
if ctx.Data["WorkingUsers"], err = models.TotalTimes(&models.FindTrackedTimesOptions{IssueID: issue.ID}); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("TotalTimes", err)
|
2017-09-12 02:48:13 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2016-02-01 20:55:12 -05:00
|
|
|
|
2018-07-17 17:23:58 -04:00
|
|
|
// Check if the user can use the dependencies
|
2020-01-19 01:43:38 -05:00
|
|
|
ctx.Data["CanCreateIssueDependencies"] = ctx.Repo.CanCreateIssueDependencies(ctx.User, issue.IsPull)
|
2018-07-17 17:23:58 -04:00
|
|
|
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 01:06:10 -04:00
|
|
|
// check if dependencies can be created across repositories
|
|
|
|
ctx.Data["AllowCrossRepositoryDependencies"] = setting.Service.AllowCrossRepositoryDependencies
|
|
|
|
|
2020-09-10 14:09:14 -04:00
|
|
|
if issue.ShowTag, err = commentTag(repo, issue.Poster, issue); err != nil {
|
|
|
|
ctx.ServerError("commentTag", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
marked[issue.PosterID] = issue.ShowTag
|
|
|
|
|
2016-02-01 20:55:12 -05:00
|
|
|
// Render comments and and fetch participants.
|
|
|
|
participants[0] = issue.Poster
|
2015-08-13 14:43:40 -04:00
|
|
|
for _, comment = range issue.Comments {
|
2019-05-06 08:09:31 -04:00
|
|
|
comment.Issue = issue
|
|
|
|
|
2018-12-13 10:55:43 -05:00
|
|
|
if err := comment.LoadPoster(); err != nil {
|
|
|
|
ctx.ServerError("LoadPoster", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2016-11-07 11:30:04 -05:00
|
|
|
if comment.Type == models.CommentTypeComment {
|
2018-12-13 10:55:43 -05:00
|
|
|
if err := comment.LoadAttachments(); err != nil {
|
|
|
|
ctx.ServerError("LoadAttachments", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-04-19 18:25:08 -04:00
|
|
|
comment.RenderedContent, err = markdown.RenderString(&markup.RenderContext{
|
|
|
|
URLPrefix: ctx.Repo.RepoLink,
|
|
|
|
Metas: ctx.Repo.Repository.ComposeMetas(),
|
2021-06-20 18:39:12 -04:00
|
|
|
GitRepo: ctx.Repo.GitRepo,
|
2021-08-28 16:15:56 -04:00
|
|
|
Ctx: ctx,
|
2021-04-19 18:25:08 -04:00
|
|
|
}, comment.Content)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("RenderString", err)
|
|
|
|
return
|
|
|
|
}
|
2015-08-13 14:43:40 -04:00
|
|
|
// Check tag.
|
|
|
|
tag, ok = marked[comment.PosterID]
|
|
|
|
if ok {
|
|
|
|
comment.ShowTag = tag
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2017-12-21 02:43:26 -05:00
|
|
|
comment.ShowTag, err = commentTag(repo, comment.Poster, issue)
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("commentTag", err)
|
2017-12-21 02:43:26 -05:00
|
|
|
return
|
2015-08-13 14:43:40 -04:00
|
|
|
}
|
|
|
|
marked[comment.PosterID] = comment.ShowTag
|
2019-09-07 10:53:35 -04:00
|
|
|
participants = addParticipant(comment.Poster, participants)
|
2017-01-30 07:46:45 -05:00
|
|
|
} else if comment.Type == models.CommentTypeLabel {
|
|
|
|
if err = comment.LoadLabel(); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("LoadLabel", err)
|
2017-01-30 07:46:45 -05:00
|
|
|
return
|
|
|
|
}
|
2017-01-31 21:36:08 -05:00
|
|
|
} else if comment.Type == models.CommentTypeMilestone {
|
|
|
|
if err = comment.LoadMilestone(); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("LoadMilestone", err)
|
2017-01-31 21:36:08 -05:00
|
|
|
return
|
|
|
|
}
|
2017-06-17 00:51:28 -04:00
|
|
|
ghostMilestone := &models.Milestone{
|
|
|
|
ID: -1,
|
|
|
|
Name: ctx.Tr("repo.issues.deleted_milestone"),
|
|
|
|
}
|
|
|
|
if comment.OldMilestoneID > 0 && comment.OldMilestone == nil {
|
|
|
|
comment.OldMilestone = ghostMilestone
|
|
|
|
}
|
|
|
|
if comment.MilestoneID > 0 && comment.Milestone == nil {
|
|
|
|
comment.Milestone = ghostMilestone
|
|
|
|
}
|
2020-08-16 23:07:38 -04:00
|
|
|
} else if comment.Type == models.CommentTypeProject {
|
|
|
|
|
|
|
|
if err = comment.LoadProject(); err != nil {
|
|
|
|
ctx.ServerError("LoadProject", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ghostProject := &models.Project{
|
|
|
|
ID: -1,
|
|
|
|
Title: ctx.Tr("repo.issues.deleted_project"),
|
|
|
|
}
|
|
|
|
|
|
|
|
if comment.OldProjectID > 0 && comment.OldProject == nil {
|
|
|
|
comment.OldProject = ghostProject
|
|
|
|
}
|
|
|
|
|
|
|
|
if comment.ProjectID > 0 && comment.Project == nil {
|
|
|
|
comment.Project = ghostProject
|
|
|
|
}
|
|
|
|
|
2020-04-06 12:33:34 -04:00
|
|
|
} else if comment.Type == models.CommentTypeAssignees || comment.Type == models.CommentTypeReviewRequest {
|
2020-10-12 15:55:13 -04:00
|
|
|
if err = comment.LoadAssigneeUserAndTeam(); err != nil {
|
|
|
|
ctx.ServerError("LoadAssigneeUserAndTeam", err)
|
2017-02-03 10:09:10 -05:00
|
|
|
return
|
|
|
|
}
|
2018-07-17 17:23:58 -04:00
|
|
|
} else if comment.Type == models.CommentTypeRemoveDependency || comment.Type == models.CommentTypeAddDependency {
|
|
|
|
if err = comment.LoadDepIssueDetails(); err != nil {
|
2020-09-03 21:36:56 -04:00
|
|
|
if !models.IsErrIssueNotExist(err) {
|
|
|
|
ctx.ServerError("LoadDepIssueDetails", err)
|
|
|
|
return
|
|
|
|
}
|
2018-07-17 17:23:58 -04:00
|
|
|
}
|
2021-02-11 12:32:25 -05:00
|
|
|
} else if comment.Type == models.CommentTypeCode || comment.Type == models.CommentTypeReview || comment.Type == models.CommentTypeDismissReview {
|
2021-04-19 18:25:08 -04:00
|
|
|
comment.RenderedContent, err = markdown.RenderString(&markup.RenderContext{
|
|
|
|
URLPrefix: ctx.Repo.RepoLink,
|
|
|
|
Metas: ctx.Repo.Repository.ComposeMetas(),
|
2021-06-20 18:39:12 -04:00
|
|
|
GitRepo: ctx.Repo.GitRepo,
|
2021-08-28 16:15:56 -04:00
|
|
|
Ctx: ctx,
|
2021-04-19 18:25:08 -04:00
|
|
|
}, comment.Content)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("RenderString", err)
|
|
|
|
return
|
|
|
|
}
|
2018-08-06 00:43:22 -04:00
|
|
|
if err = comment.LoadReview(); err != nil && !models.IsErrReviewNotExist(err) {
|
|
|
|
ctx.ServerError("LoadReview", err)
|
|
|
|
return
|
|
|
|
}
|
2019-09-07 10:53:35 -04:00
|
|
|
participants = addParticipant(comment.Poster, participants)
|
2018-08-06 00:43:22 -04:00
|
|
|
if comment.Review == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
if err = comment.Review.LoadAttributes(); err != nil {
|
2019-05-06 08:09:31 -04:00
|
|
|
if !models.IsErrUserNotExist(err) {
|
|
|
|
ctx.ServerError("Review.LoadAttributes", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
comment.Review.Reviewer = models.NewGhostUser()
|
2018-08-06 00:43:22 -04:00
|
|
|
}
|
|
|
|
if err = comment.Review.LoadCodeComments(); err != nil {
|
|
|
|
ctx.ServerError("Review.LoadCodeComments", err)
|
|
|
|
return
|
|
|
|
}
|
2021-01-17 12:29:10 -05:00
|
|
|
for _, codeComments := range comment.Review.CodeComments {
|
|
|
|
for _, lineComments := range codeComments {
|
|
|
|
for _, c := range lineComments {
|
|
|
|
// Check tag.
|
|
|
|
tag, ok = marked[c.PosterID]
|
|
|
|
if ok {
|
|
|
|
c.ShowTag = tag
|
|
|
|
continue
|
|
|
|
}
|
2020-04-18 09:50:25 -04:00
|
|
|
|
2021-01-17 12:29:10 -05:00
|
|
|
c.ShowTag, err = commentTag(repo, c.Poster, issue)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("commentTag", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
marked[c.PosterID] = c.ShowTag
|
|
|
|
participants = addParticipant(c.Poster, participants)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-04-18 09:50:25 -04:00
|
|
|
if err = comment.LoadResolveDoer(); err != nil {
|
|
|
|
ctx.ServerError("LoadResolveDoer", err)
|
|
|
|
return
|
|
|
|
}
|
2020-05-20 08:47:24 -04:00
|
|
|
} else if comment.Type == models.CommentTypePullPush {
|
|
|
|
participants = addParticipant(comment.Poster, participants)
|
|
|
|
if err = comment.LoadPushCommits(); err != nil {
|
|
|
|
ctx.ServerError("LoadPushCommits", err)
|
|
|
|
return
|
|
|
|
}
|
2021-02-19 05:52:11 -05:00
|
|
|
} else if comment.Type == models.CommentTypeAddTimeManual ||
|
|
|
|
comment.Type == models.CommentTypeStopTracking {
|
|
|
|
// drop error since times could be pruned from DB..
|
|
|
|
_ = comment.LoadTime()
|
2015-08-13 04:07:11 -04:00
|
|
|
}
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2020-10-25 17:49:48 -04:00
|
|
|
// Combine multiple label assignments into a single comment
|
|
|
|
combineLabelComments(issue)
|
|
|
|
|
2019-12-16 01:20:25 -05:00
|
|
|
getBranchData(ctx, issue)
|
2016-12-25 10:27:25 -05:00
|
|
|
if issue.IsPull {
|
|
|
|
pull := issue.PullRequest
|
2018-12-11 18:49:33 -05:00
|
|
|
pull.Issue = issue
|
2016-12-25 11:19:25 -05:00
|
|
|
canDelete := false
|
2020-01-11 02:29:34 -05:00
|
|
|
ctx.Data["AllowMerge"] = false
|
2016-12-25 11:19:25 -05:00
|
|
|
|
2017-06-20 21:00:03 -04:00
|
|
|
if ctx.IsSigned {
|
2020-03-02 17:31:55 -05:00
|
|
|
if err := pull.LoadHeadRepo(); err != nil {
|
|
|
|
log.Error("LoadHeadRepo: %v", err)
|
2018-11-28 06:26:14 -05:00
|
|
|
} else if pull.HeadRepo != nil && pull.HeadBranch != pull.HeadRepo.DefaultBranch {
|
|
|
|
perm, err := models.GetUserRepoPermission(pull.HeadRepo, ctx.User)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetUserRepoPermission", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if perm.CanWrite(models.UnitTypeCode) {
|
|
|
|
// Check if branch is not protected
|
2021-06-23 15:38:19 -04:00
|
|
|
if protected, err := pull.HeadRepo.IsProtectedBranch(pull.HeadBranch); err != nil {
|
2019-04-02 03:48:31 -04:00
|
|
|
log.Error("IsProtectedBranch: %v", err)
|
2018-11-28 06:26:14 -05:00
|
|
|
} else if !protected {
|
|
|
|
canDelete = true
|
2020-12-25 04:59:32 -05:00
|
|
|
ctx.Data["DeleteBranchLink"] = ctx.Repo.RepoLink + "/pulls/" + fmt.Sprint(issue.Index) + "/cleanup"
|
2018-11-28 06:26:14 -05:00
|
|
|
}
|
2017-06-20 21:00:03 -04:00
|
|
|
}
|
2016-12-25 11:19:25 -05:00
|
|
|
}
|
2020-01-11 02:29:34 -05:00
|
|
|
|
2020-03-02 17:31:55 -05:00
|
|
|
if err := pull.LoadBaseRepo(); err != nil {
|
|
|
|
log.Error("LoadBaseRepo: %v", err)
|
2020-01-11 02:29:34 -05:00
|
|
|
}
|
|
|
|
perm, err := models.GetUserRepoPermission(pull.BaseRepo, ctx.User)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetUserRepoPermission", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Data["AllowMerge"], err = pull_service.IsUserAllowedToMerge(pull, perm, ctx.User)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("IsUserAllowedToMerge", err)
|
|
|
|
return
|
|
|
|
}
|
2020-04-18 09:50:25 -04:00
|
|
|
|
|
|
|
if ctx.Data["CanMarkConversation"], err = models.CanMarkConversation(issue, ctx.User); err != nil {
|
|
|
|
ctx.ServerError("CanMarkConversation", err)
|
|
|
|
return
|
|
|
|
}
|
2016-12-25 11:19:25 -05:00
|
|
|
}
|
2016-12-25 10:27:25 -05:00
|
|
|
|
2018-01-05 13:56:50 -05:00
|
|
|
prUnit, err := repo.GetUnit(models.UnitTypePullRequests)
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetUnit", err)
|
2018-01-05 13:56:50 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
prConfig := prUnit.PullRequestsConfig()
|
|
|
|
|
|
|
|
// Check correct values and select default
|
|
|
|
if ms, ok := ctx.Data["MergeStyle"].(models.MergeStyle); !ok ||
|
|
|
|
!prConfig.IsMergeStyleAllowed(ms) {
|
2021-03-27 10:55:40 -04:00
|
|
|
defaultMergeStyle := prConfig.GetDefaultMergeStyle()
|
|
|
|
if prConfig.IsMergeStyleAllowed(defaultMergeStyle) && !ok {
|
|
|
|
ctx.Data["MergeStyle"] = defaultMergeStyle
|
|
|
|
} else if prConfig.AllowMerge {
|
2018-01-05 13:56:50 -05:00
|
|
|
ctx.Data["MergeStyle"] = models.MergeStyleMerge
|
|
|
|
} else if prConfig.AllowRebase {
|
|
|
|
ctx.Data["MergeStyle"] = models.MergeStyleRebase
|
2018-12-27 05:27:08 -05:00
|
|
|
} else if prConfig.AllowRebaseMerge {
|
|
|
|
ctx.Data["MergeStyle"] = models.MergeStyleRebaseMerge
|
2018-01-05 13:56:50 -05:00
|
|
|
} else if prConfig.AllowSquash {
|
|
|
|
ctx.Data["MergeStyle"] = models.MergeStyleSquash
|
2021-03-03 22:41:23 -05:00
|
|
|
} else if prConfig.AllowManualMerge {
|
|
|
|
ctx.Data["MergeStyle"] = models.MergeStyleManuallyMerged
|
2018-01-05 13:56:50 -05:00
|
|
|
} else {
|
|
|
|
ctx.Data["MergeStyle"] = ""
|
|
|
|
}
|
|
|
|
}
|
2018-12-11 06:28:37 -05:00
|
|
|
if err = pull.LoadProtectedBranch(); err != nil {
|
|
|
|
ctx.ServerError("LoadProtectedBranch", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if pull.ProtectedBranch != nil {
|
2018-12-11 18:49:33 -05:00
|
|
|
cnt := pull.ProtectedBranch.GetGrantedApprovalsCount(pull)
|
2020-01-03 12:47:10 -05:00
|
|
|
ctx.Data["IsBlockedByApprovals"] = !pull.ProtectedBranch.HasEnoughApprovals(pull)
|
|
|
|
ctx.Data["IsBlockedByRejection"] = pull.ProtectedBranch.MergeBlockedByRejectedReview(pull)
|
2020-11-28 14:30:46 -05:00
|
|
|
ctx.Data["IsBlockedByOfficialReviewRequests"] = pull.ProtectedBranch.MergeBlockedByOfficialReviewRequests(pull)
|
2020-04-16 21:00:36 -04:00
|
|
|
ctx.Data["IsBlockedByOutdatedBranch"] = pull.ProtectedBranch.MergeBlockedByOutdatedBranch(pull)
|
2018-12-11 18:49:33 -05:00
|
|
|
ctx.Data["GrantedApprovals"] = cnt
|
2020-01-15 03:32:57 -05:00
|
|
|
ctx.Data["RequireSigned"] = pull.ProtectedBranch.RequireSignedCommits
|
2020-10-13 14:50:57 -04:00
|
|
|
ctx.Data["ChangedProtectedFiles"] = pull.ChangedProtectedFiles
|
|
|
|
ctx.Data["IsBlockedByChangedProtectedFiles"] = len(pull.ChangedProtectedFiles) != 0
|
|
|
|
ctx.Data["ChangedProtectedFilesNum"] = len(pull.ChangedProtectedFiles)
|
2020-01-15 03:32:57 -05:00
|
|
|
}
|
|
|
|
ctx.Data["WillSign"] = false
|
|
|
|
if ctx.User != nil {
|
2020-09-19 12:44:55 -04:00
|
|
|
sign, key, _, err := pull.SignMerge(ctx.User, pull.BaseRepo.RepoPath(), pull.BaseBranch, pull.GetGitRefName())
|
2020-01-15 03:32:57 -05:00
|
|
|
ctx.Data["WillSign"] = sign
|
|
|
|
ctx.Data["SigningKey"] = key
|
|
|
|
if err != nil {
|
|
|
|
if models.IsErrWontSign(err) {
|
|
|
|
ctx.Data["WontSignReason"] = err.(*models.ErrWontSign).Reason
|
|
|
|
} else {
|
|
|
|
ctx.Data["WontSignReason"] = "error"
|
|
|
|
log.Error("Error whilst checking if could sign pr %d in repo %s. Error: %v", pull.ID, pull.BaseRepo.FullName(), err)
|
|
|
|
}
|
|
|
|
}
|
2020-08-23 17:59:41 -04:00
|
|
|
} else {
|
|
|
|
ctx.Data["WontSignReason"] = "not_signed_in"
|
2018-12-11 06:28:37 -05:00
|
|
|
}
|
2020-01-07 12:06:14 -05:00
|
|
|
ctx.Data["IsPullBranchDeletable"] = canDelete &&
|
|
|
|
pull.HeadRepo != nil &&
|
|
|
|
git.IsBranchExist(pull.HeadRepo.RepoPath(), pull.HeadBranch) &&
|
|
|
|
(!pull.HasMerged || ctx.Data["HeadBranchCommitID"] == ctx.Data["PullHeadCommitID"])
|
2021-03-03 22:41:23 -05:00
|
|
|
|
|
|
|
stillCanManualMerge := func() bool {
|
|
|
|
if pull.HasMerged || issue.IsClosed || !ctx.IsSigned {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
if pull.CanAutoMerge() || pull.IsWorkInProgress() || pull.IsChecking() {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
if (ctx.User.IsAdmin || ctx.Repo.IsAdmin()) && prConfig.AllowManualMerge {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["StillCanManualMerge"] = stillCanManualMerge()
|
2016-12-25 10:27:25 -05:00
|
|
|
}
|
|
|
|
|
2018-07-17 17:23:58 -04:00
|
|
|
// Get Dependencies
|
|
|
|
ctx.Data["BlockedByDependencies"], err = issue.BlockedByDependencies()
|
2019-06-12 15:41:28 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("BlockedByDependencies", err)
|
|
|
|
return
|
|
|
|
}
|
2018-07-17 17:23:58 -04:00
|
|
|
ctx.Data["BlockingDependencies"], err = issue.BlockingDependencies()
|
2019-06-12 15:41:28 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("BlockingDependencies", err)
|
|
|
|
return
|
|
|
|
}
|
2018-07-17 17:23:58 -04:00
|
|
|
|
2016-01-19 08:04:24 -05:00
|
|
|
ctx.Data["Participants"] = participants
|
2016-02-01 20:55:12 -05:00
|
|
|
ctx.Data["NumParticipants"] = len(participants)
|
2014-07-26 02:28:04 -04:00
|
|
|
ctx.Data["Issue"] = issue
|
2020-09-08 12:29:51 -04:00
|
|
|
ctx.Data["ReadOnly"] = false
|
2016-11-27 05:14:25 -05:00
|
|
|
ctx.Data["SignInLink"] = setting.AppSubURL + "/user/login?redirect_to=" + ctx.Data["Link"].(string)
|
2018-11-28 06:26:14 -05:00
|
|
|
ctx.Data["IsIssuePoster"] = ctx.IsSigned && issue.IsPoster(ctx.User.ID)
|
2020-04-04 01:39:48 -04:00
|
|
|
ctx.Data["HasIssuesOrPullsWritePermission"] = ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)
|
2020-08-16 23:07:38 -04:00
|
|
|
ctx.Data["HasProjectsWritePermission"] = ctx.Repo.CanWrite(models.UnitTypeProjects)
|
2019-02-18 15:55:04 -05:00
|
|
|
ctx.Data["IsRepoAdmin"] = ctx.IsSigned && (ctx.Repo.IsAdmin() || ctx.User.IsAdmin)
|
|
|
|
ctx.Data["LockReasons"] = setting.Repository.Issue.LockReasons
|
2020-05-14 18:55:43 -04:00
|
|
|
ctx.Data["RefEndName"] = git.RefEndName(issue.Ref)
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.HTML(http.StatusOK, tplIssueView)
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2017-09-12 02:48:13 -04:00
|
|
|
// GetActionIssue will return the issue which is used in the context.
|
|
|
|
func GetActionIssue(ctx *context.Context) *models.Issue {
|
2015-08-19 11:14:57 -04:00
|
|
|
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
|
2014-07-26 02:28:04 -04:00
|
|
|
if err != nil {
|
2017-10-16 03:55:43 -04:00
|
|
|
ctx.NotFoundOrServerError("GetIssueByIndex", models.IsErrIssueNotExist, err)
|
|
|
|
return nil
|
|
|
|
}
|
2018-12-13 10:55:43 -05:00
|
|
|
issue.Repo = ctx.Repo.Repository
|
2017-12-03 18:14:26 -05:00
|
|
|
checkIssueRights(ctx, issue)
|
|
|
|
if ctx.Written() {
|
2017-10-16 03:55:43 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if err = issue.LoadAttributes(); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("LoadAttributes", nil)
|
2015-08-19 11:14:57 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return issue
|
|
|
|
}
|
|
|
|
|
2017-12-03 18:14:26 -05:00
|
|
|
func checkIssueRights(ctx *context.Context, issue *models.Issue) {
|
2018-11-28 06:26:14 -05:00
|
|
|
if issue.IsPull && !ctx.Repo.CanRead(models.UnitTypePullRequests) ||
|
|
|
|
!issue.IsPull && !ctx.Repo.CanRead(models.UnitTypeIssues) {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound("IssueOrPullRequestUnitNotAllowed", nil)
|
2017-12-03 18:14:26 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-03-14 21:10:35 -04:00
|
|
|
func getActionIssues(ctx *context.Context) []*models.Issue {
|
2021-08-10 20:31:13 -04:00
|
|
|
commaSeparatedIssueIDs := ctx.FormString("issue_ids")
|
2017-03-14 21:10:35 -04:00
|
|
|
if len(commaSeparatedIssueIDs) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
issueIDs := make([]int64, 0, 10)
|
|
|
|
for _, stringIssueID := range strings.Split(commaSeparatedIssueIDs, ",") {
|
|
|
|
issueID, err := strconv.ParseInt(stringIssueID, 10, 64)
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ParseInt", err)
|
2017-03-14 21:10:35 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
issueIDs = append(issueIDs, issueID)
|
|
|
|
}
|
|
|
|
issues, err := models.GetIssuesByIDs(issueIDs)
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetIssuesByIDs", err)
|
2017-03-14 21:10:35 -04:00
|
|
|
return nil
|
|
|
|
}
|
2017-10-16 03:55:43 -04:00
|
|
|
// Check access rights for all issues
|
2018-11-28 06:26:14 -05:00
|
|
|
issueUnitEnabled := ctx.Repo.CanRead(models.UnitTypeIssues)
|
|
|
|
prUnitEnabled := ctx.Repo.CanRead(models.UnitTypePullRequests)
|
2017-10-16 03:55:43 -04:00
|
|
|
for _, issue := range issues {
|
|
|
|
if issue.IsPull && !prUnitEnabled || !issue.IsPull && !issueUnitEnabled {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound("IssueOrPullRequestUnitNotAllowed", nil)
|
2017-10-16 03:55:43 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if err = issue.LoadAttributes(); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("LoadAttributes", err)
|
2017-10-16 03:55:43 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
2017-03-14 21:10:35 -04:00
|
|
|
return issues
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// UpdateIssueTitle change issue's title
|
2016-03-11 11:56:52 -05:00
|
|
|
func UpdateIssueTitle(ctx *context.Context) {
|
2017-09-12 02:48:13 -04:00
|
|
|
issue := GetActionIssue(ctx)
|
2015-08-19 11:14:57 -04:00
|
|
|
if ctx.Written() {
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if !ctx.IsSigned || (!issue.IsPoster(ctx.User.ID) && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)) {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
title := ctx.FormTrim("title")
|
2016-08-14 06:32:24 -04:00
|
|
|
if len(title) == 0 {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusNoContent)
|
2015-08-19 11:14:57 -04:00
|
|
|
return
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
2015-08-19 11:14:57 -04:00
|
|
|
|
2019-10-11 02:44:43 -04:00
|
|
|
if err := issue_service.ChangeTitle(issue, ctx.User, title); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeTitle", err)
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2016-08-14 06:32:24 -04:00
|
|
|
"title": issue.Title,
|
2014-07-26 02:28:04 -04:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2020-09-08 12:29:51 -04:00
|
|
|
// UpdateIssueRef change issue's ref (branch)
|
|
|
|
func UpdateIssueRef(ctx *context.Context) {
|
|
|
|
issue := GetActionIssue(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !ctx.IsSigned || (!issue.IsPoster(ctx.User.ID) && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)) || issue.IsPull {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2020-09-08 12:29:51 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
ref := ctx.FormTrim("ref")
|
2020-09-08 12:29:51 -04:00
|
|
|
|
|
|
|
if err := issue_service.ChangeIssueRef(issue, ctx.User, ref); err != nil {
|
|
|
|
ctx.ServerError("ChangeRef", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2020-09-08 12:29:51 -04:00
|
|
|
"ref": ref,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// UpdateIssueContent change issue's content
|
2016-03-11 11:56:52 -05:00
|
|
|
func UpdateIssueContent(ctx *context.Context) {
|
2017-09-12 02:48:13 -04:00
|
|
|
issue := GetActionIssue(ctx)
|
2015-08-19 16:31:28 -04:00
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if !ctx.IsSigned || (ctx.User.ID != issue.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)) {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-08-11 11:08:52 -04:00
|
|
|
if err := issue_service.ChangeContent(issue, ctx.User, ctx.Req.FormValue("content")); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeContent", err)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-08-21 09:04:47 -04:00
|
|
|
// when update the request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates
|
|
|
|
if !ctx.FormBool("ignore_attachments") {
|
|
|
|
if err := updateAttachments(issue, ctx.FormStrings("files[]")); err != nil {
|
|
|
|
ctx.ServerError("UpdateAttachments", err)
|
|
|
|
return
|
|
|
|
}
|
2021-04-19 18:25:08 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
content, err := markdown.RenderString(&markup.RenderContext{
|
2021-08-10 20:31:13 -04:00
|
|
|
URLPrefix: ctx.FormString("context"),
|
2021-04-19 18:25:08 -04:00
|
|
|
Metas: ctx.Repo.Repository.ComposeMetas(),
|
2021-06-20 18:39:12 -04:00
|
|
|
GitRepo: ctx.Repo.GitRepo,
|
2021-08-28 16:15:56 -04:00
|
|
|
Ctx: ctx,
|
2021-04-19 18:25:08 -04:00
|
|
|
}, issue.Content)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("RenderString", err)
|
|
|
|
return
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2021-04-19 18:25:08 -04:00
|
|
|
"content": content,
|
2020-12-13 14:12:27 -05:00
|
|
|
"attachments": attachmentsHTML(ctx, issue.Attachments, issue.Content),
|
2015-08-19 16:31:28 -04:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// UpdateIssueMilestone change issue's milestone
|
2016-03-11 11:56:52 -05:00
|
|
|
func UpdateIssueMilestone(ctx *context.Context) {
|
2017-03-14 21:10:35 -04:00
|
|
|
issues := getActionIssues(ctx)
|
2015-08-14 12:42:43 -04:00
|
|
|
if ctx.Written() {
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
milestoneID := ctx.FormInt64("id")
|
2017-03-14 21:10:35 -04:00
|
|
|
for _, issue := range issues {
|
|
|
|
oldMilestoneID := issue.MilestoneID
|
|
|
|
if oldMilestoneID == milestoneID {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
issue.MilestoneID = milestoneID
|
2019-11-01 23:33:20 -04:00
|
|
|
if err := issue_service.ChangeMilestoneAssign(issue, ctx.User, oldMilestoneID); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeMilestoneAssign", err)
|
2017-03-14 21:10:35 -04:00
|
|
|
return
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2014-07-26 02:28:04 -04:00
|
|
|
"ok": true,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2019-10-25 10:46:37 -04:00
|
|
|
// UpdateIssueAssignee change issue's or pull's assignee
|
2016-03-11 11:56:52 -05:00
|
|
|
func UpdateIssueAssignee(ctx *context.Context) {
|
2017-03-14 21:10:35 -04:00
|
|
|
issues := getActionIssues(ctx)
|
2015-08-14 12:42:43 -04:00
|
|
|
if ctx.Written() {
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
assigneeID := ctx.FormInt64("id")
|
2021-08-10 20:31:13 -04:00
|
|
|
action := ctx.FormString("action")
|
2018-05-09 12:29:04 -04:00
|
|
|
|
2017-03-14 21:10:35 -04:00
|
|
|
for _, issue := range issues {
|
2018-05-09 12:29:04 -04:00
|
|
|
switch action {
|
|
|
|
case "clear":
|
2019-10-27 22:11:50 -04:00
|
|
|
if err := issue_service.DeleteNotPassedAssignee(issue, ctx.User, []*models.User{}); err != nil {
|
2018-05-09 12:29:04 -04:00
|
|
|
ctx.ServerError("ClearAssignees", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
default:
|
2019-10-25 10:46:37 -04:00
|
|
|
assignee, err := models.GetUserByID(assigneeID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetUserByID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
valid, err := models.CanBeAssigned(assignee, issue.Repo, issue.IsPull)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("canBeAssigned", err)
|
2018-05-09 12:29:04 -04:00
|
|
|
return
|
|
|
|
}
|
2019-10-25 10:46:37 -04:00
|
|
|
if !valid {
|
|
|
|
ctx.ServerError("canBeAssigned", models.ErrUserDoesNotHaveAccessToRepo{UserID: assigneeID, RepoName: issue.Repo.Name})
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-01-01 21:07:15 -05:00
|
|
|
_, _, err = issue_service.ToggleAssignee(issue, ctx.User, assigneeID)
|
2019-10-25 10:46:37 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("ToggleAssignee", err)
|
|
|
|
return
|
|
|
|
}
|
2017-03-14 21:10:35 -04:00
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2017-03-14 21:10:35 -04:00
|
|
|
"ok": true,
|
|
|
|
})
|
|
|
|
}
|
2014-07-26 02:28:04 -04:00
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
// UpdatePullReviewRequest add or remove review request
|
|
|
|
func UpdatePullReviewRequest(ctx *context.Context) {
|
2020-04-06 12:33:34 -04:00
|
|
|
issues := getActionIssues(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-28 21:42:15 -04:00
|
|
|
reviewID := ctx.FormInt64("id")
|
2021-08-10 20:31:13 -04:00
|
|
|
action := ctx.FormString("action")
|
2020-04-06 12:33:34 -04:00
|
|
|
|
2020-09-02 12:55:13 -04:00
|
|
|
// TODO: Not support 'clear' now
|
|
|
|
if action != "attach" && action != "detach" {
|
|
|
|
ctx.Status(403)
|
2020-04-06 12:33:34 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, issue := range issues {
|
2020-10-12 15:55:13 -04:00
|
|
|
if err := issue.LoadRepo(); err != nil {
|
|
|
|
ctx.ServerError("issue.LoadRepo", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !issue.IsPull {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: refusing to add review request for non-PR issue %-v#%d",
|
|
|
|
issue.Repo, issue.Index,
|
|
|
|
)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if reviewID < 0 {
|
|
|
|
// negative reviewIDs represent team requests
|
|
|
|
if err := issue.Repo.GetOwner(); err != nil {
|
|
|
|
ctx.ServerError("issue.Repo.GetOwner", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !issue.Repo.Owner.IsOrganization() {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: refusing to add team review request for %s#%d owned by non organization UID[%d]",
|
|
|
|
issue.Repo.FullName(), issue.Index, issue.Repo.ID,
|
|
|
|
)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
2020-04-06 12:33:34 -04:00
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
team, err := models.GetTeamByID(-reviewID)
|
2020-04-06 12:33:34 -04:00
|
|
|
if err != nil {
|
2020-10-12 15:55:13 -04:00
|
|
|
ctx.ServerError("models.GetTeamByID", err)
|
2020-04-06 12:33:34 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-10-12 15:55:13 -04:00
|
|
|
if team.OrgID != issue.Repo.OwnerID {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: refusing to add team review request for UID[%d] team %s to %s#%d owned by UID[%d]",
|
|
|
|
team.OrgID, team.Name, issue.Repo.FullName(), issue.Index, issue.Repo.ID)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-10-20 14:18:25 -04:00
|
|
|
err = issue_service.IsValidTeamReviewRequest(team, ctx.User, action == "attach", issue)
|
2020-04-06 12:33:34 -04:00
|
|
|
if err != nil {
|
2020-10-12 15:55:13 -04:00
|
|
|
if models.IsErrNotValidReviewRequest(err) {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: refusing to add invalid team review request for UID[%d] team %s to %s#%d owned by UID[%d]: Error: %v",
|
|
|
|
team.OrgID, team.Name, issue.Repo.FullName(), issue.Index, issue.Repo.ID,
|
|
|
|
err,
|
|
|
|
)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
2020-10-20 14:18:25 -04:00
|
|
|
ctx.ServerError("IsValidTeamReviewRequest", err)
|
2020-04-06 12:33:34 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-10-20 14:18:25 -04:00
|
|
|
_, err = issue_service.TeamReviewRequest(issue, ctx.User, team, action == "attach")
|
2020-04-06 12:33:34 -04:00
|
|
|
if err != nil {
|
2020-10-12 15:55:13 -04:00
|
|
|
ctx.ServerError("TeamReviewRequest", err)
|
2020-04-06 12:33:34 -04:00
|
|
|
return
|
|
|
|
}
|
2020-10-12 15:55:13 -04:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
reviewer, err := models.GetUserByID(reviewID)
|
|
|
|
if err != nil {
|
|
|
|
if models.IsErrUserNotExist(err) {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: requested reviewer [%d] for %-v to %-v#%d is not exist: Error: %v",
|
|
|
|
reviewID, issue.Repo, issue.Index,
|
|
|
|
err,
|
|
|
|
)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.ServerError("GetUserByID", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-10-20 14:18:25 -04:00
|
|
|
err = issue_service.IsValidReviewRequest(reviewer, ctx.User, action == "attach", issue, nil)
|
2020-10-12 15:55:13 -04:00
|
|
|
if err != nil {
|
|
|
|
if models.IsErrNotValidReviewRequest(err) {
|
|
|
|
log.Warn(
|
|
|
|
"UpdatePullReviewRequest: refusing to add invalid review request for %-v to %-v#%d: Error: %v",
|
|
|
|
reviewer, issue.Repo, issue.Index,
|
|
|
|
err,
|
|
|
|
)
|
|
|
|
ctx.Status(403)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.ServerError("isValidReviewRequest", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-10-20 14:18:25 -04:00
|
|
|
_, err = issue_service.ReviewRequest(issue, ctx.User, reviewer, action == "attach")
|
2020-10-12 15:55:13 -04:00
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("ReviewRequest", err)
|
2020-09-02 12:55:13 -04:00
|
|
|
return
|
2020-04-06 12:33:34 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2020-04-06 12:33:34 -04:00
|
|
|
"ok": true,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2017-03-14 21:10:35 -04:00
|
|
|
// UpdateIssueStatus change issue's status
|
|
|
|
func UpdateIssueStatus(ctx *context.Context) {
|
|
|
|
issues := getActionIssues(ctx)
|
|
|
|
if ctx.Written() {
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2017-03-14 21:10:35 -04:00
|
|
|
var isClosed bool
|
2021-08-10 20:31:13 -04:00
|
|
|
switch action := ctx.FormString("action"); action {
|
2017-03-14 21:10:35 -04:00
|
|
|
case "open":
|
|
|
|
isClosed = false
|
|
|
|
case "close":
|
|
|
|
isClosed = true
|
|
|
|
default:
|
|
|
|
log.Warn("Unrecognized action: %s", action)
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, err := models.IssueList(issues).LoadRepositories(); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("LoadRepositories", err)
|
2017-03-14 21:10:35 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
for _, issue := range issues {
|
2018-10-18 07:23:05 -04:00
|
|
|
if issue.IsClosed != isClosed {
|
2019-10-28 01:26:46 -04:00
|
|
|
if err := issue_service.ChangeStatus(issue, ctx.User, isClosed); err != nil {
|
2018-10-18 07:23:05 -04:00
|
|
|
if models.IsErrDependenciesLeft(err) {
|
|
|
|
ctx.JSON(http.StatusPreconditionFailed, map[string]interface{}{
|
|
|
|
"error": "cannot close this issue because it still has open dependencies",
|
|
|
|
})
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.ServerError("ChangeStatus", err)
|
2018-07-17 17:23:58 -04:00
|
|
|
return
|
|
|
|
}
|
2017-03-14 21:10:35 -04:00
|
|
|
}
|
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2014-07-26 02:28:04 -04:00
|
|
|
"ok": true,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// NewComment create a comment for issue
|
2021-01-26 10:36:53 -05:00
|
|
|
func NewComment(ctx *context.Context) {
|
2021-04-06 15:44:05 -04:00
|
|
|
form := web.GetForm(ctx).(*forms.CreateCommentForm)
|
2017-10-16 03:55:43 -04:00
|
|
|
issue := GetActionIssue(ctx)
|
|
|
|
if ctx.Written() {
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if !ctx.IsSigned || (ctx.User.ID != issue.PosterID && !ctx.Repo.CanReadIssuesOrPulls(issue.IsPull)) {
|
2019-04-22 16:40:51 -04:00
|
|
|
if log.IsTrace() {
|
|
|
|
if ctx.IsSigned {
|
|
|
|
issueType := "issues"
|
|
|
|
if issue.IsPull {
|
|
|
|
issueType = "pulls"
|
|
|
|
}
|
|
|
|
log.Trace("Permission Denied: User %-v not the Poster (ID: %d) and cannot read %s in Repo %-v.\n"+
|
|
|
|
"User in Repo has Permissions: %-+v",
|
|
|
|
ctx.User,
|
|
|
|
log.NewColoredIDValue(issue.PosterID),
|
|
|
|
issueType,
|
|
|
|
ctx.Repo.Repository,
|
|
|
|
ctx.Repo.Permission)
|
|
|
|
} else {
|
|
|
|
log.Trace("Permission Denied: Not logged in")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2020-01-20 07:00:32 -05:00
|
|
|
return
|
2019-02-18 15:55:04 -05:00
|
|
|
}
|
|
|
|
|
2020-01-20 07:00:32 -05:00
|
|
|
if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.User.IsAdmin {
|
2019-02-18 15:55:04 -05:00
|
|
|
ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))
|
|
|
|
ctx.Redirect(issue.HTMLURL(), http.StatusSeeOther)
|
2018-11-28 06:26:14 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2015-08-13 04:07:11 -04:00
|
|
|
var attachments []string
|
2020-08-18 00:23:45 -04:00
|
|
|
if setting.Attachment.Enabled {
|
2016-08-11 08:48:08 -04:00
|
|
|
attachments = form.Files
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2015-08-13 04:07:11 -04:00
|
|
|
if ctx.HasError() {
|
|
|
|
ctx.Flash.Error(ctx.Data["ErrorMsg"].(string))
|
2019-12-13 19:53:32 -05:00
|
|
|
ctx.Redirect(issue.HTMLURL())
|
2015-08-13 04:07:11 -04:00
|
|
|
return
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2015-10-18 19:30:39 -04:00
|
|
|
var comment *models.Comment
|
2015-09-13 11:26:25 -04:00
|
|
|
defer func() {
|
2015-10-31 18:59:07 -04:00
|
|
|
// Check if issue admin/poster changes the status of issue.
|
2018-11-28 06:26:14 -05:00
|
|
|
if (ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) || (ctx.IsSigned && issue.IsPoster(ctx.User.ID))) &&
|
2015-09-13 11:26:25 -04:00
|
|
|
(form.Status == "reopen" || form.Status == "close") &&
|
2016-08-16 13:19:09 -04:00
|
|
|
!(issue.IsPull && issue.PullRequest.HasMerged) {
|
2015-10-18 19:30:39 -04:00
|
|
|
|
2015-10-25 03:10:22 -04:00
|
|
|
// Duplication and conflict check should apply to reopen pull request.
|
2015-10-18 19:30:39 -04:00
|
|
|
var pr *models.PullRequest
|
|
|
|
|
2015-10-23 10:31:13 -04:00
|
|
|
if form.Status == "reopen" && issue.IsPull {
|
2015-10-18 19:30:39 -04:00
|
|
|
pull := issue.PullRequest
|
2019-06-12 15:41:28 -04:00
|
|
|
var err error
|
2021-07-28 05:42:56 -04:00
|
|
|
pr, err = models.GetUnmergedPullRequest(pull.HeadRepoID, pull.BaseRepoID, pull.HeadBranch, pull.BaseBranch, pull.Flow)
|
2015-10-18 19:30:39 -04:00
|
|
|
if err != nil {
|
|
|
|
if !models.IsErrPullRequestNotExist(err) {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("GetUnmergedPullRequest", err)
|
2015-10-18 19:30:39 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2015-10-25 03:10:22 -04:00
|
|
|
|
|
|
|
// Regenerate patch and test conflict.
|
|
|
|
if pr == nil {
|
2021-07-28 05:42:56 -04:00
|
|
|
issue.PullRequest.HeadCommitID = ""
|
2019-12-06 21:44:10 -05:00
|
|
|
pull_service.AddToTaskQueue(issue.PullRequest)
|
2015-10-25 03:10:22 -04:00
|
|
|
}
|
2015-10-18 19:30:39 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
if pr != nil {
|
|
|
|
ctx.Flash.Info(ctx.Tr("repo.pulls.open_unmerged_pull_exists", pr.Index))
|
2015-09-13 11:26:25 -04:00
|
|
|
} else {
|
2018-10-18 07:23:05 -04:00
|
|
|
isClosed := form.Status == "close"
|
2019-10-28 01:26:46 -04:00
|
|
|
if err := issue_service.ChangeStatus(issue, ctx.User, isClosed); err != nil {
|
2019-04-02 03:48:31 -04:00
|
|
|
log.Error("ChangeStatus: %v", err)
|
2018-07-17 17:23:58 -04:00
|
|
|
|
|
|
|
if models.IsErrDependenciesLeft(err) {
|
|
|
|
if issue.IsPull {
|
|
|
|
ctx.Flash.Error(ctx.Tr("repo.issues.dependency.pr_close_blocked"))
|
|
|
|
ctx.Redirect(fmt.Sprintf("%s/pulls/%d", ctx.Repo.RepoLink, issue.Index), http.StatusSeeOther)
|
|
|
|
} else {
|
|
|
|
ctx.Flash.Error(ctx.Tr("repo.issues.dependency.issue_close_blocked"))
|
|
|
|
ctx.Redirect(fmt.Sprintf("%s/issues/%d", ctx.Repo.RepoLink, issue.Index), http.StatusSeeOther)
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
2015-10-18 19:30:39 -04:00
|
|
|
} else {
|
2019-02-05 06:38:11 -05:00
|
|
|
if err := stopTimerIfAvailable(ctx.User, issue); err != nil {
|
|
|
|
ctx.ServerError("CreateOrStopIssueStopwatch", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2016-02-22 12:40:00 -05:00
|
|
|
log.Trace("Issue [%d] status changed to closed: %v", issue.ID, issue.IsClosed)
|
2015-10-18 19:30:39 -04:00
|
|
|
}
|
2015-09-13 11:26:25 -04:00
|
|
|
}
|
|
|
|
}
|
2015-10-18 19:30:39 -04:00
|
|
|
|
|
|
|
// Redirect to comment hashtag if there is any actual content.
|
|
|
|
typeName := "issues"
|
|
|
|
if issue.IsPull {
|
|
|
|
typeName = "pulls"
|
|
|
|
}
|
|
|
|
if comment != nil {
|
|
|
|
ctx.Redirect(fmt.Sprintf("%s/%s/%d#%s", ctx.Repo.RepoLink, typeName, issue.Index, comment.HashTag()))
|
|
|
|
} else {
|
|
|
|
ctx.Redirect(fmt.Sprintf("%s/%s/%d", ctx.Repo.RepoLink, typeName, issue.Index))
|
|
|
|
}
|
2015-09-13 11:26:25 -04:00
|
|
|
}()
|
|
|
|
|
2015-08-13 04:07:11 -04:00
|
|
|
// Fix #321: Allow empty comments, as long as we have attachments.
|
|
|
|
if len(form.Content) == 0 && len(attachments) == 0 {
|
|
|
|
return
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2019-09-24 13:39:50 -04:00
|
|
|
comment, err := comment_service.CreateIssueComment(ctx.User, ctx.Repo.Repository, issue, form.Content, attachments)
|
2015-08-13 04:07:11 -04:00
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("CreateIssueComment", err)
|
2014-07-26 02:28:04 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2015-08-13 04:07:11 -04:00
|
|
|
log.Trace("Comment created: %d/%d/%d", ctx.Repo.Repository.ID, issue.ID, comment.ID)
|
2014-07-26 02:28:04 -04:00
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// UpdateCommentContent change comment of issue's content
|
2016-03-11 11:56:52 -05:00
|
|
|
func UpdateCommentContent(ctx *context.Context) {
|
2015-08-19 16:31:28 -04:00
|
|
|
comment, err := models.GetCommentByID(ctx.ParamsInt64(":id"))
|
|
|
|
if err != nil {
|
2016-08-30 05:08:38 -04:00
|
|
|
ctx.NotFoundOrServerError("GetCommentByID", models.IsErrCommentNotExist, err)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if err := comment.LoadIssue(); err != nil {
|
|
|
|
ctx.NotFoundOrServerError("LoadIssue", models.IsErrIssueNotExist, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !ctx.IsSigned || (ctx.User.ID != comment.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(comment.Issue.IsPull)) {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
2018-08-06 00:43:22 -04:00
|
|
|
} else if comment.Type != models.CommentTypeComment && comment.Type != models.CommentTypeCode {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusNoContent)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-05-16 10:01:55 -04:00
|
|
|
oldContent := comment.Content
|
2021-08-10 20:31:13 -04:00
|
|
|
comment.Content = ctx.FormString("content")
|
2015-08-19 16:31:28 -04:00
|
|
|
if len(comment.Content) == 0 {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2015-08-19 16:31:28 -04:00
|
|
|
"content": "",
|
|
|
|
})
|
|
|
|
return
|
|
|
|
}
|
2019-09-24 13:39:50 -04:00
|
|
|
if err = comment_service.UpdateComment(comment, ctx.User, oldContent); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("UpdateComment", err)
|
2015-08-19 16:31:28 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-08-20 15:26:19 -04:00
|
|
|
if comment.Type == models.CommentTypeComment {
|
|
|
|
if err := comment.LoadAttachments(); err != nil {
|
|
|
|
ctx.ServerError("LoadAttachments", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-08-21 09:04:47 -04:00
|
|
|
// when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates
|
|
|
|
if !ctx.FormBool("ignore_attachments") {
|
|
|
|
if err := updateAttachments(comment, ctx.FormStrings("files[]")); err != nil {
|
|
|
|
ctx.ServerError("UpdateAttachments", err)
|
|
|
|
return
|
|
|
|
}
|
2021-04-19 18:25:08 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
content, err := markdown.RenderString(&markup.RenderContext{
|
2021-08-10 20:31:13 -04:00
|
|
|
URLPrefix: ctx.FormString("context"),
|
2021-04-19 18:25:08 -04:00
|
|
|
Metas: ctx.Repo.Repository.ComposeMetas(),
|
2021-06-20 18:39:12 -04:00
|
|
|
GitRepo: ctx.Repo.GitRepo,
|
2021-08-28 16:15:56 -04:00
|
|
|
Ctx: ctx,
|
2021-04-19 18:25:08 -04:00
|
|
|
}, comment.Content)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("RenderString", err)
|
|
|
|
return
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2021-04-19 18:25:08 -04:00
|
|
|
"content": content,
|
2020-12-13 14:12:27 -05:00
|
|
|
"attachments": attachmentsHTML(ctx, comment.Attachments, comment.Content),
|
2015-08-19 16:31:28 -04:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-11-24 02:04:31 -05:00
|
|
|
// DeleteComment delete comment of issue
|
2016-07-25 14:48:17 -04:00
|
|
|
func DeleteComment(ctx *context.Context) {
|
|
|
|
comment, err := models.GetCommentByID(ctx.ParamsInt64(":id"))
|
|
|
|
if err != nil {
|
2016-08-30 05:08:38 -04:00
|
|
|
ctx.NotFoundOrServerError("GetCommentByID", models.IsErrCommentNotExist, err)
|
2016-07-25 14:48:17 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if err := comment.LoadIssue(); err != nil {
|
|
|
|
ctx.NotFoundOrServerError("LoadIssue", models.IsErrIssueNotExist, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !ctx.IsSigned || (ctx.User.ID != comment.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(comment.Issue.IsPull)) {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2016-07-25 14:48:17 -04:00
|
|
|
return
|
2018-08-06 00:43:22 -04:00
|
|
|
} else if comment.Type != models.CommentTypeComment && comment.Type != models.CommentTypeCode {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusNoContent)
|
2016-07-25 14:48:17 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-01-21 21:56:19 -05:00
|
|
|
if err = comment_service.DeleteComment(ctx.User, comment); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("DeleteCommentByID", err)
|
2016-07-25 14:48:17 -04:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Status(200)
|
|
|
|
}
|
|
|
|
|
2017-12-03 18:14:26 -05:00
|
|
|
// ChangeIssueReaction create a reaction for issue
|
2021-01-26 10:36:53 -05:00
|
|
|
func ChangeIssueReaction(ctx *context.Context) {
|
2021-04-06 15:44:05 -04:00
|
|
|
form := web.GetForm(ctx).(*forms.ReactionForm)
|
2017-12-03 18:14:26 -05:00
|
|
|
issue := GetActionIssue(ctx)
|
|
|
|
if ctx.Written() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-12-11 13:12:06 -05:00
|
|
|
if !ctx.IsSigned || (ctx.User.ID != issue.PosterID && !ctx.Repo.CanReadIssuesOrPulls(issue.IsPull)) {
|
2019-04-22 16:40:51 -04:00
|
|
|
if log.IsTrace() {
|
|
|
|
if ctx.IsSigned {
|
|
|
|
issueType := "issues"
|
|
|
|
if issue.IsPull {
|
|
|
|
issueType = "pulls"
|
|
|
|
}
|
|
|
|
log.Trace("Permission Denied: User %-v not the Poster (ID: %d) and cannot read %s in Repo %-v.\n"+
|
|
|
|
"User in Repo has Permissions: %-+v",
|
|
|
|
ctx.User,
|
|
|
|
log.NewColoredIDValue(issue.PosterID),
|
|
|
|
issueType,
|
|
|
|
ctx.Repo.Repository,
|
|
|
|
ctx.Repo.Permission)
|
|
|
|
} else {
|
|
|
|
log.Trace("Permission Denied: Not logged in")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2018-11-28 06:26:14 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2017-12-03 18:14:26 -05:00
|
|
|
if ctx.HasError() {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeIssueReaction", errors.New(ctx.GetErrMsg()))
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
switch ctx.Params(":action") {
|
|
|
|
case "react":
|
|
|
|
reaction, err := models.CreateIssueReaction(ctx.User, issue, form.Content)
|
|
|
|
if err != nil {
|
2019-12-07 17:04:19 -05:00
|
|
|
if models.IsErrForbiddenIssueReaction(err) {
|
|
|
|
ctx.ServerError("ChangeIssueReaction", err)
|
|
|
|
return
|
|
|
|
}
|
2017-12-03 18:14:26 -05:00
|
|
|
log.Info("CreateIssueReaction: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
// Reload new reactions
|
|
|
|
issue.Reactions = nil
|
|
|
|
if err = issue.LoadAttributes(); err != nil {
|
|
|
|
log.Info("issue.LoadAttributes: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
|
|
|
log.Trace("Reaction for issue created: %d/%d/%d", ctx.Repo.Repository.ID, issue.ID, reaction.ID)
|
|
|
|
case "unreact":
|
|
|
|
if err := models.DeleteIssueReaction(ctx.User, issue, form.Content); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("DeleteIssueReaction", err)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Reload new reactions
|
|
|
|
issue.Reactions = nil
|
|
|
|
if err := issue.LoadAttributes(); err != nil {
|
|
|
|
log.Info("issue.LoadAttributes: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
|
|
|
log.Trace("Reaction for issue removed: %d/%d", ctx.Repo.Repository.ID, issue.ID)
|
|
|
|
default:
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound(fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(issue.Reactions) == 0 {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2017-12-03 18:14:26 -05:00
|
|
|
"empty": true,
|
|
|
|
"html": "",
|
|
|
|
})
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
html, err := ctx.HTMLString(string(tplReactions), map[string]interface{}{
|
|
|
|
"ctx": ctx.Data,
|
|
|
|
"ActionURL": fmt.Sprintf("%s/issues/%d/reactions", ctx.Repo.RepoLink, issue.Index),
|
|
|
|
"Reactions": issue.Reactions.GroupByType(),
|
|
|
|
})
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeIssueReaction.HTMLString", err)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2017-12-03 18:14:26 -05:00
|
|
|
"html": html,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// ChangeCommentReaction create a reaction for comment
|
2021-01-26 10:36:53 -05:00
|
|
|
func ChangeCommentReaction(ctx *context.Context) {
|
2021-04-06 15:44:05 -04:00
|
|
|
form := web.GetForm(ctx).(*forms.ReactionForm)
|
2017-12-03 18:14:26 -05:00
|
|
|
comment, err := models.GetCommentByID(ctx.ParamsInt64(":id"))
|
|
|
|
if err != nil {
|
|
|
|
ctx.NotFoundOrServerError("GetCommentByID", models.IsErrCommentNotExist, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
if err := comment.LoadIssue(); err != nil {
|
|
|
|
ctx.NotFoundOrServerError("LoadIssue", models.IsErrIssueNotExist, err)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-12-11 13:12:06 -05:00
|
|
|
if !ctx.IsSigned || (ctx.User.ID != comment.PosterID && !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull)) {
|
2019-04-22 16:40:51 -04:00
|
|
|
if log.IsTrace() {
|
|
|
|
if ctx.IsSigned {
|
|
|
|
issueType := "issues"
|
|
|
|
if comment.Issue.IsPull {
|
|
|
|
issueType = "pulls"
|
|
|
|
}
|
|
|
|
log.Trace("Permission Denied: User %-v not the Poster (ID: %d) and cannot read %s in Repo %-v.\n"+
|
|
|
|
"User in Repo has Permissions: %-+v",
|
|
|
|
ctx.User,
|
|
|
|
log.NewColoredIDValue(comment.Issue.PosterID),
|
|
|
|
issueType,
|
|
|
|
ctx.Repo.Repository,
|
|
|
|
ctx.Repo.Permission)
|
|
|
|
} else {
|
|
|
|
log.Trace("Permission Denied: Not logged in")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusForbidden)
|
2018-11-28 06:26:14 -05:00
|
|
|
return
|
|
|
|
} else if comment.Type != models.CommentTypeComment && comment.Type != models.CommentTypeCode {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.Error(http.StatusNoContent)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
switch ctx.Params(":action") {
|
|
|
|
case "react":
|
2018-11-28 06:26:14 -05:00
|
|
|
reaction, err := models.CreateCommentReaction(ctx.User, comment.Issue, comment, form.Content)
|
2017-12-03 18:14:26 -05:00
|
|
|
if err != nil {
|
2019-12-07 17:04:19 -05:00
|
|
|
if models.IsErrForbiddenIssueReaction(err) {
|
|
|
|
ctx.ServerError("ChangeIssueReaction", err)
|
|
|
|
return
|
|
|
|
}
|
2017-12-03 18:14:26 -05:00
|
|
|
log.Info("CreateCommentReaction: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
// Reload new reactions
|
|
|
|
comment.Reactions = nil
|
2020-01-15 06:14:07 -05:00
|
|
|
if err = comment.LoadReactions(ctx.Repo.Repository); err != nil {
|
2017-12-03 18:14:26 -05:00
|
|
|
log.Info("comment.LoadReactions: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
log.Trace("Reaction for comment created: %d/%d/%d/%d", ctx.Repo.Repository.ID, comment.Issue.ID, comment.ID, reaction.ID)
|
2017-12-03 18:14:26 -05:00
|
|
|
case "unreact":
|
2018-11-28 06:26:14 -05:00
|
|
|
if err := models.DeleteCommentReaction(ctx.User, comment.Issue, comment, form.Content); err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("DeleteCommentReaction", err)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Reload new reactions
|
|
|
|
comment.Reactions = nil
|
2020-01-15 06:14:07 -05:00
|
|
|
if err = comment.LoadReactions(ctx.Repo.Repository); err != nil {
|
2017-12-03 18:14:26 -05:00
|
|
|
log.Info("comment.LoadReactions: %s", err)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
2018-11-28 06:26:14 -05:00
|
|
|
log.Trace("Reaction for comment removed: %d/%d/%d", ctx.Repo.Repository.ID, comment.Issue.ID, comment.ID)
|
2017-12-03 18:14:26 -05:00
|
|
|
default:
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.NotFound(fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(comment.Reactions) == 0 {
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2017-12-03 18:14:26 -05:00
|
|
|
"empty": true,
|
|
|
|
"html": "",
|
|
|
|
})
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
html, err := ctx.HTMLString(string(tplReactions), map[string]interface{}{
|
|
|
|
"ctx": ctx.Data,
|
|
|
|
"ActionURL": fmt.Sprintf("%s/comments/%d/reactions", ctx.Repo.RepoLink, comment.ID),
|
|
|
|
"Reactions": comment.Reactions.GroupByType(),
|
|
|
|
})
|
|
|
|
if err != nil {
|
2018-01-10 16:34:17 -05:00
|
|
|
ctx.ServerError("ChangeCommentReaction.HTMLString", err)
|
2017-12-03 18:14:26 -05:00
|
|
|
return
|
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, map[string]interface{}{
|
2017-12-03 18:14:26 -05:00
|
|
|
"html": html,
|
|
|
|
})
|
|
|
|
}
|
2019-09-07 10:53:35 -04:00
|
|
|
|
|
|
|
func addParticipant(poster *models.User, participants []*models.User) []*models.User {
|
|
|
|
for _, part := range participants {
|
|
|
|
if poster.ID == part.ID {
|
|
|
|
return participants
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return append(participants, poster)
|
|
|
|
}
|
2019-09-20 01:45:38 -04:00
|
|
|
|
|
|
|
func filterXRefComments(ctx *context.Context, issue *models.Issue) error {
|
|
|
|
// Remove comments that the user has no permissions to see
|
|
|
|
for i := 0; i < len(issue.Comments); {
|
|
|
|
c := issue.Comments[i]
|
|
|
|
if models.CommentTypeIsRef(c.Type) && c.RefRepoID != issue.RepoID && c.RefRepoID != 0 {
|
|
|
|
var err error
|
|
|
|
// Set RefRepo for description in template
|
|
|
|
c.RefRepo, err = models.GetRepositoryByID(c.RefRepoID)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
perm, err := models.GetUserRepoPermission(c.RefRepo, ctx.User)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if !perm.CanReadIssuesOrPulls(c.RefIsPull) {
|
|
|
|
issue.Comments = append(issue.Comments[:i], issue.Comments[i+1:]...)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
i++
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
2019-10-15 08:19:32 -04:00
|
|
|
|
|
|
|
// GetIssueAttachments returns attachments for the issue
|
|
|
|
func GetIssueAttachments(ctx *context.Context) {
|
|
|
|
issue := GetActionIssue(ctx)
|
|
|
|
var attachments = make([]*api.Attachment, len(issue.Attachments))
|
|
|
|
for i := 0; i < len(issue.Attachments); i++ {
|
2020-10-17 00:23:08 -04:00
|
|
|
attachments[i] = convert.ToReleaseAttachment(issue.Attachments[i])
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, attachments)
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
// GetCommentAttachments returns attachments for the comment
|
|
|
|
func GetCommentAttachments(ctx *context.Context) {
|
|
|
|
comment, err := models.GetCommentByID(ctx.ParamsInt64(":id"))
|
|
|
|
if err != nil {
|
|
|
|
ctx.NotFoundOrServerError("GetCommentByID", models.IsErrCommentNotExist, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
var attachments = make([]*api.Attachment, 0)
|
|
|
|
if comment.Type == models.CommentTypeComment {
|
|
|
|
if err := comment.LoadAttachments(); err != nil {
|
|
|
|
ctx.ServerError("LoadAttachments", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
for i := 0; i < len(comment.Attachments); i++ {
|
2020-10-17 00:23:08 -04:00
|
|
|
attachments = append(attachments, convert.ToReleaseAttachment(comment.Attachments[i]))
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
}
|
2021-04-05 11:30:52 -04:00
|
|
|
ctx.JSON(http.StatusOK, attachments)
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
func updateAttachments(item interface{}, files []string) error {
|
|
|
|
var attachments []*models.Attachment
|
|
|
|
switch content := item.(type) {
|
|
|
|
case *models.Issue:
|
|
|
|
attachments = content.Attachments
|
|
|
|
case *models.Comment:
|
|
|
|
attachments = content.Attachments
|
|
|
|
default:
|
2020-08-04 17:30:02 -04:00
|
|
|
return fmt.Errorf("Unknown Type: %T", content)
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
for i := 0; i < len(attachments); i++ {
|
|
|
|
if util.IsStringInSlice(attachments[i].UUID, files) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
if err := models.DeleteAttachment(attachments[i], true); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
var err error
|
|
|
|
if len(files) > 0 {
|
|
|
|
switch content := item.(type) {
|
|
|
|
case *models.Issue:
|
|
|
|
err = content.UpdateAttachments(files)
|
|
|
|
case *models.Comment:
|
|
|
|
err = content.UpdateAttachments(files)
|
|
|
|
default:
|
2020-08-04 17:30:02 -04:00
|
|
|
return fmt.Errorf("Unknown Type: %T", content)
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
switch content := item.(type) {
|
|
|
|
case *models.Issue:
|
|
|
|
content.Attachments, err = models.GetAttachmentsByIssueID(content.ID)
|
|
|
|
case *models.Comment:
|
|
|
|
content.Attachments, err = models.GetAttachmentsByCommentID(content.ID)
|
|
|
|
default:
|
2020-08-04 17:30:02 -04:00
|
|
|
return fmt.Errorf("Unknown Type: %T", content)
|
2019-10-15 08:19:32 -04:00
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2020-12-13 14:12:27 -05:00
|
|
|
func attachmentsHTML(ctx *context.Context, attachments []*models.Attachment, content string) string {
|
2019-10-15 08:19:32 -04:00
|
|
|
attachHTML, err := ctx.HTMLString(string(tplAttachment), map[string]interface{}{
|
|
|
|
"ctx": ctx.Data,
|
|
|
|
"Attachments": attachments,
|
2020-12-13 14:12:27 -05:00
|
|
|
"Content": content,
|
2019-10-15 08:19:32 -04:00
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("attachmentsHTML.HTMLString", err)
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
return attachHTML
|
|
|
|
}
|
2020-10-25 17:49:48 -04:00
|
|
|
|
2021-03-05 10:17:32 -05:00
|
|
|
// combineLabelComments combine the nearby label comments as one.
|
2020-10-25 17:49:48 -04:00
|
|
|
func combineLabelComments(issue *models.Issue) {
|
2021-03-05 10:17:32 -05:00
|
|
|
var prev, cur *models.Comment
|
2020-11-20 17:29:09 -05:00
|
|
|
for i := 0; i < len(issue.Comments); i++ {
|
2021-03-05 10:17:32 -05:00
|
|
|
cur = issue.Comments[i]
|
2020-11-20 17:29:09 -05:00
|
|
|
if i > 0 {
|
2020-10-25 17:49:48 -04:00
|
|
|
prev = issue.Comments[i-1]
|
|
|
|
}
|
2020-11-20 17:29:09 -05:00
|
|
|
if i == 0 || cur.Type != models.CommentTypeLabel ||
|
|
|
|
(prev != nil && prev.PosterID != cur.PosterID) ||
|
|
|
|
(prev != nil && cur.CreatedUnix-prev.CreatedUnix >= 60) {
|
2021-02-09 21:50:44 -05:00
|
|
|
if cur.Type == models.CommentTypeLabel && cur.Label != nil {
|
2020-11-20 17:29:09 -05:00
|
|
|
if cur.Content != "1" {
|
|
|
|
cur.RemovedLabels = append(cur.RemovedLabels, cur.Label)
|
2020-10-25 17:49:48 -04:00
|
|
|
} else {
|
2020-11-20 17:29:09 -05:00
|
|
|
cur.AddedLabels = append(cur.AddedLabels, cur.Label)
|
2020-10-25 17:49:48 -04:00
|
|
|
}
|
|
|
|
}
|
2020-11-20 17:29:09 -05:00
|
|
|
continue
|
2020-10-25 17:49:48 -04:00
|
|
|
}
|
2020-11-20 17:29:09 -05:00
|
|
|
|
2021-03-05 10:17:32 -05:00
|
|
|
if cur.Label != nil { // now cur MUST be label comment
|
|
|
|
if prev.Type == models.CommentTypeLabel { // we can combine them only prev is a label comment
|
|
|
|
if cur.Content != "1" {
|
|
|
|
prev.RemovedLabels = append(prev.RemovedLabels, cur.Label)
|
|
|
|
} else {
|
|
|
|
prev.AddedLabels = append(prev.AddedLabels, cur.Label)
|
|
|
|
}
|
|
|
|
prev.CreatedUnix = cur.CreatedUnix
|
|
|
|
// remove the current comment since it has been combined to prev comment
|
|
|
|
issue.Comments = append(issue.Comments[:i], issue.Comments[i+1:]...)
|
|
|
|
i--
|
|
|
|
} else { // if prev is not a label comment, start a new group
|
|
|
|
if cur.Content != "1" {
|
|
|
|
cur.RemovedLabels = append(cur.RemovedLabels, cur.Label)
|
|
|
|
} else {
|
|
|
|
cur.AddedLabels = append(cur.AddedLabels, cur.Label)
|
|
|
|
}
|
2021-02-09 21:50:44 -05:00
|
|
|
}
|
2020-11-20 17:29:09 -05:00
|
|
|
}
|
2020-10-25 17:49:48 -04:00
|
|
|
}
|
|
|
|
}
|
2020-12-21 10:39:28 -05:00
|
|
|
|
|
|
|
// get all teams that current user can mention
|
|
|
|
func handleTeamMentions(ctx *context.Context) {
|
|
|
|
if ctx.User == nil || !ctx.Repo.Owner.IsOrganization() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
isAdmin := false
|
|
|
|
var err error
|
|
|
|
// Admin has super access.
|
|
|
|
if ctx.User.IsAdmin {
|
|
|
|
isAdmin = true
|
|
|
|
} else {
|
|
|
|
isAdmin, err = ctx.Repo.Owner.IsOwnedBy(ctx.User.ID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("IsOwnedBy", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if isAdmin {
|
2021-08-12 08:43:08 -04:00
|
|
|
if err := ctx.Repo.Owner.LoadTeams(); err != nil {
|
|
|
|
ctx.ServerError("LoadTeams", err)
|
2020-12-21 10:39:28 -05:00
|
|
|
return
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ctx.Repo.Owner.Teams, err = ctx.Repo.Owner.GetUserTeams(ctx.User.ID)
|
|
|
|
if err != nil {
|
|
|
|
ctx.ServerError("GetUserTeams", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.Data["MentionableTeams"] = ctx.Repo.Owner.Teams
|
|
|
|
ctx.Data["MentionableTeamsOrg"] = ctx.Repo.Owner.Name
|
2020-12-22 16:28:03 -05:00
|
|
|
ctx.Data["MentionableTeamsOrgAvatar"] = ctx.Repo.Owner.RelAvatarLink()
|
2020-12-21 10:39:28 -05:00
|
|
|
}
|