2021-06-14 13:20:43 -04:00
// Copyright 2021 The Gitea Authors. All rights reserved.
2022-11-27 13:20:29 -05:00
// SPDX-License-Identifier: MIT
2021-06-14 13:20:43 -04:00
package mirror
import (
"context"
"fmt"
"strings"
"time"
2021-12-09 20:27:50 -05:00
repo_model "code.gitea.io/gitea/models/repo"
2022-10-16 19:29:26 -04:00
system_model "code.gitea.io/gitea/models/system"
2021-06-14 13:20:43 -04:00
"code.gitea.io/gitea/modules/cache"
"code.gitea.io/gitea/modules/git"
2024-04-13 11:41:57 -04:00
giturl "code.gitea.io/gitea/modules/git/url"
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 15:09:51 -05:00
"code.gitea.io/gitea/modules/gitrepo"
2021-06-14 13:20:43 -04:00
"code.gitea.io/gitea/modules/lfs"
"code.gitea.io/gitea/modules/log"
2021-11-30 15:06:32 -05:00
"code.gitea.io/gitea/modules/process"
2023-02-10 19:39:50 -05:00
"code.gitea.io/gitea/modules/proxy"
2021-06-14 13:20:43 -04:00
repo_module "code.gitea.io/gitea/modules/repository"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util"
2023-09-05 14:37:47 -04:00
notify_service "code.gitea.io/gitea/services/notify"
2021-06-14 13:20:43 -04:00
)
// gitShortEmptySha Git short empty SHA
const gitShortEmptySha = "0000000"
// UpdateAddress writes new address to Git repository and database
2022-01-19 18:26:57 -05:00
func UpdateAddress ( ctx context . Context , m * repo_model . Mirror , addr string ) error {
2024-04-13 11:41:57 -04:00
u , err := giturl . Parse ( addr )
if err != nil {
return fmt . Errorf ( "invalid addr: %v" , err )
}
2021-06-14 13:20:43 -04:00
remoteName := m . GetRemoteName ( )
2023-09-29 08:12:54 -04:00
repoPath := m . GetRepository ( ctx ) . RepoPath ( )
2021-06-14 13:20:43 -04:00
// Remove old remote
2024-04-13 11:41:57 -04:00
_ , _ , err = git . NewCommand ( ctx , "remote" , "rm" ) . AddDynamicArguments ( remoteName ) . RunStdString ( & git . RunOpts { Dir : repoPath } )
2021-06-14 13:20:43 -04:00
if err != nil && ! strings . HasPrefix ( err . Error ( ) , "exit status 128 - fatal: No such remote " ) {
return err
}
2022-10-23 10:44:45 -04:00
cmd := git . NewCommand ( ctx , "remote" , "add" ) . AddDynamicArguments ( remoteName ) . AddArguments ( "--mirror=fetch" ) . AddDynamicArguments ( addr )
2022-03-27 07:54:09 -04:00
if strings . Contains ( addr , "://" ) && strings . Contains ( addr , "@" ) {
2022-03-30 22:25:40 -04:00
cmd . SetDescription ( fmt . Sprintf ( "remote add %s --mirror=fetch %s [repo_path: %s]" , remoteName , util . SanitizeCredentialURLs ( addr ) , repoPath ) )
2022-03-27 07:54:09 -04:00
} else {
cmd . SetDescription ( fmt . Sprintf ( "remote add %s --mirror=fetch %s [repo_path: %s]" , remoteName , addr , repoPath ) )
}
2022-03-31 22:55:30 -04:00
_ , _ , err = cmd . RunStdString ( & git . RunOpts { Dir : repoPath } )
2021-06-14 13:20:43 -04:00
if err != nil && ! strings . HasPrefix ( err . Error ( ) , "exit status 128 - fatal: No such remote " ) {
return err
}
if m . Repo . HasWiki ( ) {
wikiPath := m . Repo . WikiPath ( )
2022-01-19 18:26:57 -05:00
wikiRemotePath := repo_module . WikiRemoteURL ( ctx , addr )
2021-06-14 13:20:43 -04:00
// Remove old remote of wiki
2022-10-23 10:44:45 -04:00
_ , _ , err = git . NewCommand ( ctx , "remote" , "rm" ) . AddDynamicArguments ( remoteName ) . RunStdString ( & git . RunOpts { Dir : wikiPath } )
2021-06-14 13:20:43 -04:00
if err != nil && ! strings . HasPrefix ( err . Error ( ) , "exit status 128 - fatal: No such remote " ) {
return err
}
2022-10-23 10:44:45 -04:00
cmd = git . NewCommand ( ctx , "remote" , "add" ) . AddDynamicArguments ( remoteName ) . AddArguments ( "--mirror=fetch" ) . AddDynamicArguments ( wikiRemotePath )
2022-03-27 07:54:09 -04:00
if strings . Contains ( wikiRemotePath , "://" ) && strings . Contains ( wikiRemotePath , "@" ) {
2022-03-30 22:25:40 -04:00
cmd . SetDescription ( fmt . Sprintf ( "remote add %s --mirror=fetch %s [repo_path: %s]" , remoteName , util . SanitizeCredentialURLs ( wikiRemotePath ) , wikiPath ) )
2022-03-27 07:54:09 -04:00
} else {
cmd . SetDescription ( fmt . Sprintf ( "remote add %s --mirror=fetch %s [repo_path: %s]" , remoteName , wikiRemotePath , wikiPath ) )
}
2022-03-31 22:55:30 -04:00
_ , _ , err = cmd . RunStdString ( & git . RunOpts { Dir : wikiPath } )
2021-06-14 13:20:43 -04:00
if err != nil && ! strings . HasPrefix ( err . Error ( ) , "exit status 128 - fatal: No such remote " ) {
return err
}
}
2024-04-13 11:41:57 -04:00
// erase authentication before storing in database
u . User = nil
m . Repo . OriginalURL = u . String ( )
2022-05-20 10:08:52 -04:00
return repo_model . UpdateRepositoryCols ( ctx , m . Repo , "original_url" )
2021-06-14 13:20:43 -04:00
}
// mirrorSyncResult contains information of a updated reference.
// If the oldCommitID is "0000000", it means a new reference, the value of newCommitID is empty.
// If the newCommitID is "0000000", it means the reference is deleted, the value of oldCommitID is empty.
type mirrorSyncResult struct {
2023-05-25 21:04:48 -04:00
refName git . RefName
2021-06-14 13:20:43 -04:00
oldCommitID string
newCommitID string
}
// parseRemoteUpdateOutput detects create, update and delete operations of references from upstream.
2023-05-25 21:04:48 -04:00
// possible output example:
/ *
// * [new tag] v0.1.8 -> v0.1.8
// * [new branch] master -> origin/master
// - [deleted] (none) -> origin/test // delete a branch
// - [deleted] (none) -> 1 // delete a tag
// 957a993..a87ba5f test -> origin/test
// + f895a1e...957a993 test -> origin/test (forced update)
* /
// TODO: return whether it's a force update
func parseRemoteUpdateOutput ( output , remoteName string ) [ ] * mirrorSyncResult {
2021-06-14 13:20:43 -04:00
results := make ( [ ] * mirrorSyncResult , 0 , 3 )
lines := strings . Split ( output , "\n" )
for i := range lines {
// Make sure reference name is presented before continue
idx := strings . Index ( lines [ i ] , "-> " )
if idx == - 1 {
continue
}
2023-05-25 21:04:48 -04:00
refName := strings . TrimSpace ( lines [ i ] [ idx + 3 : ] )
2021-06-14 13:20:43 -04:00
switch {
2023-05-25 21:04:48 -04:00
case strings . HasPrefix ( lines [ i ] , " * [new tag]" ) : // new tag
2021-06-14 13:20:43 -04:00
results = append ( results , & mirrorSyncResult {
2023-05-25 21:04:48 -04:00
refName : git . RefNameFromTag ( refName ) ,
oldCommitID : gitShortEmptySha ,
} )
case strings . HasPrefix ( lines [ i ] , " * [new branch]" ) : // new branch
refName = strings . TrimPrefix ( refName , remoteName + "/" )
results = append ( results , & mirrorSyncResult {
refName : git . RefNameFromBranch ( refName ) ,
2021-06-14 13:20:43 -04:00
oldCommitID : gitShortEmptySha ,
} )
case strings . HasPrefix ( lines [ i ] , " - " ) : // Delete reference
2023-05-25 21:04:48 -04:00
isTag := ! strings . HasPrefix ( refName , remoteName + "/" )
var refFullName git . RefName
if isTag {
refFullName = git . RefNameFromTag ( refName )
} else {
refFullName = git . RefNameFromBranch ( strings . TrimPrefix ( refName , remoteName + "/" ) )
}
2021-06-14 13:20:43 -04:00
results = append ( results , & mirrorSyncResult {
2023-05-25 21:04:48 -04:00
refName : refFullName ,
2021-06-14 13:20:43 -04:00
newCommitID : gitShortEmptySha ,
} )
case strings . HasPrefix ( lines [ i ] , " + " ) : // Force update
if idx := strings . Index ( refName , " " ) ; idx > - 1 {
refName = refName [ : idx ]
}
delimIdx := strings . Index ( lines [ i ] [ 3 : ] , " " )
if delimIdx == - 1 {
log . Error ( "SHA delimiter not found: %q" , lines [ i ] )
continue
}
shas := strings . Split ( lines [ i ] [ 3 : delimIdx + 3 ] , "..." )
if len ( shas ) != 2 {
log . Error ( "Expect two SHAs but not what found: %q" , lines [ i ] )
continue
}
results = append ( results , & mirrorSyncResult {
2023-05-25 21:04:48 -04:00
refName : git . RefNameFromBranch ( strings . TrimPrefix ( refName , remoteName + "/" ) ) ,
2021-06-14 13:20:43 -04:00
oldCommitID : shas [ 0 ] ,
newCommitID : shas [ 1 ] ,
} )
case strings . HasPrefix ( lines [ i ] , " " ) : // New commits of a reference
delimIdx := strings . Index ( lines [ i ] [ 3 : ] , " " )
if delimIdx == - 1 {
log . Error ( "SHA delimiter not found: %q" , lines [ i ] )
continue
}
shas := strings . Split ( lines [ i ] [ 3 : delimIdx + 3 ] , ".." )
if len ( shas ) != 2 {
log . Error ( "Expect two SHAs but not what found: %q" , lines [ i ] )
continue
}
results = append ( results , & mirrorSyncResult {
2023-05-25 21:04:48 -04:00
refName : git . RefNameFromBranch ( strings . TrimPrefix ( refName , remoteName + "/" ) ) ,
2021-06-14 13:20:43 -04:00
oldCommitID : shas [ 0 ] ,
newCommitID : shas [ 1 ] ,
} )
default :
log . Warn ( "parseRemoteUpdateOutput: unexpected update line %q" , lines [ i ] )
}
}
return results
}
2021-10-21 04:45:25 -04:00
func pruneBrokenReferences ( ctx context . Context ,
2021-12-09 20:27:50 -05:00
m * repo_model . Mirror ,
2021-10-21 04:45:25 -04:00
repoPath string ,
timeout time . Duration ,
stdoutBuilder , stderrBuilder * strings . Builder ,
2022-01-20 12:46:10 -05:00
isWiki bool ,
) error {
2021-10-21 04:45:25 -04:00
wiki := ""
if isWiki {
wiki = "Wiki "
}
stderrBuilder . Reset ( )
stdoutBuilder . Reset ( )
2022-10-23 10:44:45 -04:00
pruneErr := git . NewCommand ( ctx , "remote" , "prune" ) . AddDynamicArguments ( m . GetRemoteName ( ) ) .
2021-10-21 04:45:25 -04:00
SetDescription ( fmt . Sprintf ( "Mirror.runSync %ssPrune references: %s " , wiki , m . Repo . FullName ( ) ) ) .
2022-03-31 22:55:30 -04:00
Run ( & git . RunOpts {
2022-02-11 07:47:22 -05:00
Timeout : timeout ,
Dir : repoPath ,
Stdout : stdoutBuilder ,
Stderr : stderrBuilder ,
} )
2021-10-21 04:45:25 -04:00
if pruneErr != nil {
stdout := stdoutBuilder . String ( )
stderr := stderrBuilder . String ( )
// sanitize the output, since it may contain the remote address, which may
// contain a password
2022-03-30 22:25:40 -04:00
stderrMessage := util . SanitizeCredentialURLs ( stderr )
stdoutMessage := util . SanitizeCredentialURLs ( stdout )
2021-10-21 04:45:25 -04:00
log . Error ( "Failed to prune mirror repository %s%-v references:\nStdout: %s\nStderr: %s\nErr: %v" , wiki , m . Repo , stdoutMessage , stderrMessage , pruneErr )
desc := fmt . Sprintf ( "Failed to prune mirror repository %s'%s' references: %s" , wiki , repoPath , stderrMessage )
2022-10-16 19:29:26 -04:00
if err := system_model . CreateRepositoryNotice ( desc ) ; err != nil {
2021-10-21 04:45:25 -04:00
log . Error ( "CreateRepositoryNotice: %v" , err )
}
// this if will only be reached on a successful prune so try to get the mirror again
}
return pruneErr
}
2021-06-14 13:20:43 -04:00
// runSync returns true if sync finished without error.
2021-12-09 20:27:50 -05:00
func runSync ( ctx context . Context , m * repo_model . Mirror ) ( [ ] * mirrorSyncResult , bool ) {
2021-06-14 13:20:43 -04:00
repoPath := m . Repo . RepoPath ( )
wikiPath := m . Repo . WikiPath ( )
timeout := time . Duration ( setting . Git . Timeout . Mirror ) * time . Second
log . Trace ( "SyncMirrors [repo: %-v]: running git remote update..." , m . Repo )
2022-03-29 13:12:33 -04:00
2023-05-25 21:04:48 -04:00
// use fetch but not remote update because git fetch support --tags but remote update doesn't
cmd := git . NewCommand ( ctx , "fetch" )
2021-06-14 13:20:43 -04:00
if m . EnablePrune {
Refactor git command package to improve security and maintainability (#22678)
This PR follows #21535 (and replace #22592)
## Review without space diff
https://github.com/go-gitea/gitea/pull/22678/files?diff=split&w=1
## Purpose of this PR
1. Make git module command completely safe (risky user inputs won't be
passed as argument option anymore)
2. Avoid low-level mistakes like
https://github.com/go-gitea/gitea/pull/22098#discussion_r1045234918
3. Remove deprecated and dirty `CmdArgCheck` function, hide the `CmdArg`
type
4. Simplify code when using git command
## The main idea of this PR
* Move the `git.CmdArg` to the `internal` package, then no other package
except `git` could use it. Then developers could never do
`AddArguments(git.CmdArg(userInput))` any more.
* Introduce `git.ToTrustedCmdArgs`, it's for user-provided and already
trusted arguments. It's only used in a few cases, for example: use git
arguments from config file, help unit test with some arguments.
* Introduce `AddOptionValues` and `AddOptionFormat`, they make code more
clear and simple:
* Before: `AddArguments("-m").AddDynamicArguments(message)`
* After: `AddOptionValues("-m", message)`
* -
* Before: `AddArguments(git.CmdArg(fmt.Sprintf("--author='%s <%s>'",
sig.Name, sig.Email)))`
* After: `AddOptionFormat("--author='%s <%s>'", sig.Name, sig.Email)`
## FAQ
### Why these changes were not done in #21535 ?
#21535 is mainly a search&replace, it did its best to not change too
much logic.
Making the framework better needs a lot of changes, so this separate PR
is needed as the second step.
### The naming of `AddOptionXxx`
According to git's manual, the `--xxx` part is called `option`.
### How can it guarantee that `internal.CmdArg` won't be not misused?
Go's specification guarantees that. Trying to access other package's
internal package causes compilation error.
And, `golangci-lint` also denies the git/internal package. Only the
`git/command.go` can use it carefully.
### There is still a `ToTrustedCmdArgs`, will it still allow developers
to make mistakes and pass untrusted arguments?
Generally speaking, no. Because when using `ToTrustedCmdArgs`, the code
will be very complex (see the changes for examples). Then developers and
reviewers can know that something might be unreasonable.
### Why there was a `CmdArgCheck` and why it's removed?
At the moment of #21535, to reduce unnecessary changes, `CmdArgCheck`
was introduced as a hacky patch. Now, almost all code could be written
as `cmd := NewCommand(); cmd.AddXxx(...)`, then there is no need for
`CmdArgCheck` anymore.
### Why many codes for `signArg == ""` is deleted?
Because in the old code, `signArg` could never be empty string, it's
either `-S[key-id]` or `--no-gpg-sign`. So the `signArg == ""` is just
dead code.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-03 21:30:43 -05:00
cmd . AddArguments ( "--prune" )
2021-06-14 13:20:43 -04:00
}
2023-05-25 21:04:48 -04:00
cmd . AddArguments ( "--tags" ) . AddDynamicArguments ( m . GetRemoteName ( ) )
2021-06-14 13:20:43 -04:00
2022-06-11 09:50:14 -04:00
remoteURL , remoteErr := git . GetRemoteURL ( ctx , repoPath , m . GetRemoteName ( ) )
2021-06-14 13:20:43 -04:00
if remoteErr != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: GetRemoteAddress Error %v" , m . Repo , remoteErr )
2022-06-11 09:50:14 -04:00
return nil , false
2021-06-14 13:20:43 -04:00
}
2023-02-10 19:39:50 -05:00
envs := proxy . EnvWithProxy ( remoteURL . URL )
2021-06-14 13:20:43 -04:00
stdoutBuilder := strings . Builder { }
stderrBuilder := strings . Builder { }
Refactor git command package to improve security and maintainability (#22678)
This PR follows #21535 (and replace #22592)
## Review without space diff
https://github.com/go-gitea/gitea/pull/22678/files?diff=split&w=1
## Purpose of this PR
1. Make git module command completely safe (risky user inputs won't be
passed as argument option anymore)
2. Avoid low-level mistakes like
https://github.com/go-gitea/gitea/pull/22098#discussion_r1045234918
3. Remove deprecated and dirty `CmdArgCheck` function, hide the `CmdArg`
type
4. Simplify code when using git command
## The main idea of this PR
* Move the `git.CmdArg` to the `internal` package, then no other package
except `git` could use it. Then developers could never do
`AddArguments(git.CmdArg(userInput))` any more.
* Introduce `git.ToTrustedCmdArgs`, it's for user-provided and already
trusted arguments. It's only used in a few cases, for example: use git
arguments from config file, help unit test with some arguments.
* Introduce `AddOptionValues` and `AddOptionFormat`, they make code more
clear and simple:
* Before: `AddArguments("-m").AddDynamicArguments(message)`
* After: `AddOptionValues("-m", message)`
* -
* Before: `AddArguments(git.CmdArg(fmt.Sprintf("--author='%s <%s>'",
sig.Name, sig.Email)))`
* After: `AddOptionFormat("--author='%s <%s>'", sig.Name, sig.Email)`
## FAQ
### Why these changes were not done in #21535 ?
#21535 is mainly a search&replace, it did its best to not change too
much logic.
Making the framework better needs a lot of changes, so this separate PR
is needed as the second step.
### The naming of `AddOptionXxx`
According to git's manual, the `--xxx` part is called `option`.
### How can it guarantee that `internal.CmdArg` won't be not misused?
Go's specification guarantees that. Trying to access other package's
internal package causes compilation error.
And, `golangci-lint` also denies the git/internal package. Only the
`git/command.go` can use it carefully.
### There is still a `ToTrustedCmdArgs`, will it still allow developers
to make mistakes and pass untrusted arguments?
Generally speaking, no. Because when using `ToTrustedCmdArgs`, the code
will be very complex (see the changes for examples). Then developers and
reviewers can know that something might be unreasonable.
### Why there was a `CmdArgCheck` and why it's removed?
At the moment of #21535, to reduce unnecessary changes, `CmdArgCheck`
was introduced as a hacky patch. Now, almost all code could be written
as `cmd := NewCommand(); cmd.AddXxx(...)`, then there is no need for
`CmdArgCheck` anymore.
### Why many codes for `signArg == ""` is deleted?
Because in the old code, `signArg` could never be empty string, it's
either `-S[key-id]` or `--no-gpg-sign`. So the `signArg == ""` is just
dead code.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-03 21:30:43 -05:00
if err := cmd .
2021-06-14 13:20:43 -04:00
SetDescription ( fmt . Sprintf ( "Mirror.runSync: %s" , m . Repo . FullName ( ) ) ) .
2022-03-31 22:55:30 -04:00
Run ( & git . RunOpts {
2022-02-11 07:47:22 -05:00
Timeout : timeout ,
Dir : repoPath ,
2023-02-10 19:39:50 -05:00
Env : envs ,
2022-02-11 07:47:22 -05:00
Stdout : & stdoutBuilder ,
Stderr : & stderrBuilder ,
} ) ; err != nil {
2021-06-14 13:20:43 -04:00
stdout := stdoutBuilder . String ( )
stderr := stderrBuilder . String ( )
2022-03-30 22:25:40 -04:00
// sanitize the output, since it may contain the remote address, which may contain a password
stderrMessage := util . SanitizeCredentialURLs ( stderr )
stdoutMessage := util . SanitizeCredentialURLs ( stdout )
2021-06-14 13:20:43 -04:00
2021-10-21 04:45:25 -04:00
// Now check if the error is a resolve reference due to broken reference
if strings . Contains ( stderr , "unable to resolve reference" ) && strings . Contains ( stderr , "reference broken" ) {
2022-03-10 05:09:48 -05:00
log . Warn ( "SyncMirrors [repo: %-v]: failed to update mirror repository due to broken references:\nStdout: %s\nStderr: %s\nErr: %v\nAttempting Prune" , m . Repo , stdoutMessage , stderrMessage , err )
2021-10-21 04:45:25 -04:00
err = nil
// Attempt prune
2022-03-30 22:25:40 -04:00
pruneErr := pruneBrokenReferences ( ctx , m , repoPath , timeout , & stdoutBuilder , & stderrBuilder , false )
2021-10-21 04:45:25 -04:00
if pruneErr == nil {
// Successful prune - reattempt mirror
stderrBuilder . Reset ( )
stdoutBuilder . Reset ( )
Refactor git command package to improve security and maintainability (#22678)
This PR follows #21535 (and replace #22592)
## Review without space diff
https://github.com/go-gitea/gitea/pull/22678/files?diff=split&w=1
## Purpose of this PR
1. Make git module command completely safe (risky user inputs won't be
passed as argument option anymore)
2. Avoid low-level mistakes like
https://github.com/go-gitea/gitea/pull/22098#discussion_r1045234918
3. Remove deprecated and dirty `CmdArgCheck` function, hide the `CmdArg`
type
4. Simplify code when using git command
## The main idea of this PR
* Move the `git.CmdArg` to the `internal` package, then no other package
except `git` could use it. Then developers could never do
`AddArguments(git.CmdArg(userInput))` any more.
* Introduce `git.ToTrustedCmdArgs`, it's for user-provided and already
trusted arguments. It's only used in a few cases, for example: use git
arguments from config file, help unit test with some arguments.
* Introduce `AddOptionValues` and `AddOptionFormat`, they make code more
clear and simple:
* Before: `AddArguments("-m").AddDynamicArguments(message)`
* After: `AddOptionValues("-m", message)`
* -
* Before: `AddArguments(git.CmdArg(fmt.Sprintf("--author='%s <%s>'",
sig.Name, sig.Email)))`
* After: `AddOptionFormat("--author='%s <%s>'", sig.Name, sig.Email)`
## FAQ
### Why these changes were not done in #21535 ?
#21535 is mainly a search&replace, it did its best to not change too
much logic.
Making the framework better needs a lot of changes, so this separate PR
is needed as the second step.
### The naming of `AddOptionXxx`
According to git's manual, the `--xxx` part is called `option`.
### How can it guarantee that `internal.CmdArg` won't be not misused?
Go's specification guarantees that. Trying to access other package's
internal package causes compilation error.
And, `golangci-lint` also denies the git/internal package. Only the
`git/command.go` can use it carefully.
### There is still a `ToTrustedCmdArgs`, will it still allow developers
to make mistakes and pass untrusted arguments?
Generally speaking, no. Because when using `ToTrustedCmdArgs`, the code
will be very complex (see the changes for examples). Then developers and
reviewers can know that something might be unreasonable.
### Why there was a `CmdArgCheck` and why it's removed?
At the moment of #21535, to reduce unnecessary changes, `CmdArgCheck`
was introduced as a hacky patch. Now, almost all code could be written
as `cmd := NewCommand(); cmd.AddXxx(...)`, then there is no need for
`CmdArgCheck` anymore.
### Why many codes for `signArg == ""` is deleted?
Because in the old code, `signArg` could never be empty string, it's
either `-S[key-id]` or `--no-gpg-sign`. So the `signArg == ""` is just
dead code.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-03 21:30:43 -05:00
if err = cmd .
2021-10-21 04:45:25 -04:00
SetDescription ( fmt . Sprintf ( "Mirror.runSync: %s" , m . Repo . FullName ( ) ) ) .
2022-03-31 22:55:30 -04:00
Run ( & git . RunOpts {
2022-02-11 07:47:22 -05:00
Timeout : timeout ,
Dir : repoPath ,
Stdout : & stdoutBuilder ,
Stderr : & stderrBuilder ,
} ) ; err != nil {
2021-10-21 04:45:25 -04:00
stdout := stdoutBuilder . String ( )
stderr := stderrBuilder . String ( )
// sanitize the output, since it may contain the remote address, which may
// contain a password
2022-03-30 22:25:40 -04:00
stderrMessage = util . SanitizeCredentialURLs ( stderr )
stdoutMessage = util . SanitizeCredentialURLs ( stdout )
2021-10-21 04:45:25 -04:00
}
}
}
// If there is still an error (or there always was an error)
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to update mirror repository:\nStdout: %s\nStderr: %s\nErr: %v" , m . Repo , stdoutMessage , stderrMessage , err )
2021-10-21 04:45:25 -04:00
desc := fmt . Sprintf ( "Failed to update mirror repository '%s': %s" , repoPath , stderrMessage )
2022-10-16 19:29:26 -04:00
if err = system_model . CreateRepositoryNotice ( desc ) ; err != nil {
2021-10-21 04:45:25 -04:00
log . Error ( "CreateRepositoryNotice: %v" , err )
}
return nil , false
2021-06-14 13:20:43 -04:00
}
}
output := stderrBuilder . String ( )
2022-03-29 13:12:33 -04:00
if err := git . WriteCommitGraph ( ctx , repoPath ) ; err != nil {
log . Error ( "SyncMirrors [repo: %-v]: %v" , m . Repo , err )
}
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 15:09:51 -05:00
gitRepo , err := gitrepo . OpenRepository ( ctx , m . Repo )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to OpenRepository: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
return nil , false
}
2023-07-06 07:18:37 -04:00
log . Trace ( "SyncMirrors [repo: %-v]: syncing branches..." , m . Repo )
if _ , err = repo_module . SyncRepoBranchesWithRepo ( ctx , m . Repo , gitRepo , 0 ) ; err != nil {
log . Error ( "SyncMirrors [repo: %-v]: failed to synchronize branches: %v" , m . Repo , err )
}
2021-06-14 13:20:43 -04:00
log . Trace ( "SyncMirrors [repo: %-v]: syncing releases with tags..." , m . Repo )
2023-09-25 09:17:37 -04:00
if err = repo_module . SyncReleasesWithTags ( ctx , m . Repo , gitRepo ) ; err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to synchronize tags to releases: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
}
if m . LFS && setting . LFS . StartServer {
log . Trace ( "SyncMirrors [repo: %-v]: syncing LFS objects..." , m . Repo )
2022-06-11 09:50:14 -04:00
endpoint := lfs . DetermineEndpoint ( remoteURL . String ( ) , m . LFSEndpoint )
2021-11-20 04:34:05 -05:00
lfsClient := lfs . NewClient ( endpoint , nil )
if err = repo_module . StoreMissingLfsObjectsInRepository ( ctx , m . Repo , gitRepo , lfsClient ) ; err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to synchronize LFS objects for repository: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
}
}
gitRepo . Close ( )
log . Trace ( "SyncMirrors [repo: %-v]: updating size of repository" , m . Repo )
2022-06-06 04:01:49 -04:00
if err := repo_module . UpdateRepoSize ( ctx , m . Repo ) ; err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to update size for mirror repository: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
}
if m . Repo . HasWiki ( ) {
log . Trace ( "SyncMirrors [repo: %-v Wiki]: running git remote update..." , m . Repo )
stderrBuilder . Reset ( )
stdoutBuilder . Reset ( )
2022-10-23 10:44:45 -04:00
if err := git . NewCommand ( ctx , "remote" , "update" , "--prune" ) . AddDynamicArguments ( m . GetRemoteName ( ) ) .
2021-06-14 13:20:43 -04:00
SetDescription ( fmt . Sprintf ( "Mirror.runSync Wiki: %s " , m . Repo . FullName ( ) ) ) .
2022-03-31 22:55:30 -04:00
Run ( & git . RunOpts {
2022-02-11 07:47:22 -05:00
Timeout : timeout ,
Dir : wikiPath ,
Stdout : & stdoutBuilder ,
Stderr : & stderrBuilder ,
} ) ; err != nil {
2021-06-14 13:20:43 -04:00
stdout := stdoutBuilder . String ( )
stderr := stderrBuilder . String ( )
2022-03-30 22:25:40 -04:00
// sanitize the output, since it may contain the remote address, which may contain a password
stderrMessage := util . SanitizeCredentialURLs ( stderr )
stdoutMessage := util . SanitizeCredentialURLs ( stdout )
2021-06-14 13:20:43 -04:00
2021-10-21 04:45:25 -04:00
// Now check if the error is a resolve reference due to broken reference
if strings . Contains ( stderrMessage , "unable to resolve reference" ) && strings . Contains ( stderrMessage , "reference broken" ) {
2022-03-10 05:09:48 -05:00
log . Warn ( "SyncMirrors [repo: %-v Wiki]: failed to update mirror wiki repository due to broken references:\nStdout: %s\nStderr: %s\nErr: %v\nAttempting Prune" , m . Repo , stdoutMessage , stderrMessage , err )
2021-10-21 04:45:25 -04:00
err = nil
// Attempt prune
2022-03-30 22:25:40 -04:00
pruneErr := pruneBrokenReferences ( ctx , m , repoPath , timeout , & stdoutBuilder , & stderrBuilder , true )
2021-10-21 04:45:25 -04:00
if pruneErr == nil {
// Successful prune - reattempt mirror
stderrBuilder . Reset ( )
stdoutBuilder . Reset ( )
2022-10-23 10:44:45 -04:00
if err = git . NewCommand ( ctx , "remote" , "update" , "--prune" ) . AddDynamicArguments ( m . GetRemoteName ( ) ) .
2021-10-21 04:45:25 -04:00
SetDescription ( fmt . Sprintf ( "Mirror.runSync Wiki: %s " , m . Repo . FullName ( ) ) ) .
2022-03-31 22:55:30 -04:00
Run ( & git . RunOpts {
2022-02-11 07:47:22 -05:00
Timeout : timeout ,
Dir : wikiPath ,
Stdout : & stdoutBuilder ,
Stderr : & stderrBuilder ,
} ) ; err != nil {
2021-10-21 04:45:25 -04:00
stdout := stdoutBuilder . String ( )
stderr := stderrBuilder . String ( )
2022-03-30 22:25:40 -04:00
stderrMessage = util . SanitizeCredentialURLs ( stderr )
stdoutMessage = util . SanitizeCredentialURLs ( stdout )
2021-10-21 04:45:25 -04:00
}
}
}
// If there is still an error (or there always was an error)
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v Wiki]: failed to update mirror repository wiki:\nStdout: %s\nStderr: %s\nErr: %v" , m . Repo , stdoutMessage , stderrMessage , err )
2021-10-21 04:45:25 -04:00
desc := fmt . Sprintf ( "Failed to update mirror repository wiki '%s': %s" , wikiPath , stderrMessage )
2022-10-16 19:29:26 -04:00
if err = system_model . CreateRepositoryNotice ( desc ) ; err != nil {
2021-10-21 04:45:25 -04:00
log . Error ( "CreateRepositoryNotice: %v" , err )
}
return nil , false
2021-06-14 13:20:43 -04:00
}
2022-03-29 13:12:33 -04:00
if err := git . WriteCommitGraph ( ctx , wikiPath ) ; err != nil {
log . Error ( "SyncMirrors [repo: %-v]: %v" , m . Repo , err )
}
2021-06-14 13:20:43 -04:00
}
log . Trace ( "SyncMirrors [repo: %-v Wiki]: git remote update complete" , m . Repo )
}
log . Trace ( "SyncMirrors [repo: %-v]: invalidating mirror branch caches..." , m . Repo )
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 15:09:51 -05:00
branches , _ , err := gitrepo . GetBranchesByPath ( ctx , m . Repo , 0 , 0 )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to GetBranches: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
return nil , false
}
for _ , branch := range branches {
cache . Remove ( m . Repo . GetCommitsCountCacheKey ( branch . Name , true ) )
}
m . UpdatedUnix = timeutil . TimeStampNow ( )
2023-05-25 21:04:48 -04:00
return parseRemoteUpdateOutput ( output , m . GetRemoteName ( ) ) , true
2021-06-14 13:20:43 -04:00
}
// SyncPullMirror starts the sync of the pull mirror and schedules the next run.
func SyncPullMirror ( ctx context . Context , repoID int64 ) bool {
log . Trace ( "SyncMirrors [repo_id: %v]" , repoID )
defer func ( ) {
err := recover ( )
if err == nil {
return
}
// There was a panic whilst syncMirrors...
2022-03-10 05:09:48 -05:00
log . Error ( "PANIC whilst SyncMirrors[repo_id: %d] Panic: %v\nStacktrace: %s" , repoID , err , log . Stack ( 2 ) )
2021-06-14 13:20:43 -04:00
} ( )
2022-05-20 10:08:52 -04:00
m , err := repo_model . GetMirrorByRepoID ( ctx , repoID )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo_id: %v]: unable to GetMirrorByRepoID: %v" , repoID , err )
2021-06-14 13:20:43 -04:00
return false
}
2023-09-29 08:12:54 -04:00
_ = m . GetRepository ( ctx ) // force load repository of mirror
2021-06-14 13:20:43 -04:00
2021-11-30 15:06:32 -05:00
ctx , _ , finished := process . GetManager ( ) . AddContext ( ctx , fmt . Sprintf ( "Syncing Mirror %s/%s" , m . Repo . OwnerName , m . Repo . Name ) )
defer finished ( )
2021-06-14 13:20:43 -04:00
log . Trace ( "SyncMirrors [repo: %-v]: Running Sync" , m . Repo )
results , ok := runSync ( ctx , m )
if ! ok {
2022-03-27 10:40:17 -04:00
if err = repo_model . TouchMirror ( ctx , m ) ; err != nil {
log . Error ( "SyncMirrors [repo: %-v]: failed to TouchMirror: %v" , m . Repo , err )
}
2021-06-14 13:20:43 -04:00
return false
}
log . Trace ( "SyncMirrors [repo: %-v]: Scheduling next update" , m . Repo )
m . ScheduleNextUpdate ( )
2022-05-20 10:08:52 -04:00
if err = repo_model . UpdateMirror ( ctx , m ) ; err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: failed to UpdateMirror with next update date: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
return false
}
2024-04-12 23:01:02 -04:00
gitRepo , err := gitrepo . OpenRepository ( ctx , m . Repo )
if err != nil {
log . Error ( "SyncMirrors [repo: %-v]: unable to OpenRepository: %v" , m . Repo , err )
return false
}
defer gitRepo . Close ( )
2021-06-14 13:20:43 -04:00
2024-04-12 23:01:02 -04:00
log . Trace ( "SyncMirrors [repo: %-v]: %d branches updated" , m . Repo , len ( results ) )
if len ( results ) > 0 {
2023-10-03 06:30:41 -04:00
if ok := checkAndUpdateEmptyRepository ( ctx , m , gitRepo , results ) ; ! ok {
2024-04-12 23:01:02 -04:00
log . Error ( "SyncMirrors [repo: %-v]: checkAndUpdateEmptyRepository: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
return false
}
}
for _ , result := range results {
// Discard GitHub pull requests, i.e. refs/pull/*
2023-05-25 21:04:48 -04:00
if result . refName . IsPull ( ) {
2021-06-14 13:20:43 -04:00
continue
}
// Create reference
if result . oldCommitID == gitShortEmptySha {
2023-05-25 21:04:48 -04:00
commitID , err := gitRepo . GetRefCommitID ( result . refName . String ( ) )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: unable to GetRefCommitID [ref_name: %s]: %v" , m . Repo , result . refName , err )
2021-06-14 13:20:43 -04:00
continue
}
2024-03-10 17:30:36 -04:00
objectFormat := git . ObjectFormatFromName ( m . Repo . ObjectFormatName )
2023-09-05 14:37:47 -04:00
notify_service . SyncPushCommits ( ctx , m . Repo . MustOwner ( ctx ) , m . Repo , & repo_module . PushUpdateOptions {
2021-06-14 13:20:43 -04:00
RefFullName : result . refName ,
2023-12-17 06:56:08 -05:00
OldCommitID : objectFormat . EmptyObjectID ( ) . String ( ) ,
2021-06-14 13:20:43 -04:00
NewCommitID : commitID ,
} , repo_module . NewPushCommits ( ) )
2023-09-05 14:37:47 -04:00
notify_service . SyncCreateRef ( ctx , m . Repo . MustOwner ( ctx ) , m . Repo , result . refName , commitID )
2021-06-14 13:20:43 -04:00
continue
}
// Delete reference
if result . newCommitID == gitShortEmptySha {
2023-09-05 14:37:47 -04:00
notify_service . SyncDeleteRef ( ctx , m . Repo . MustOwner ( ctx ) , m . Repo , result . refName )
2021-06-14 13:20:43 -04:00
continue
}
// Push commits
2022-01-19 18:26:57 -05:00
oldCommitID , err := git . GetFullCommitID ( gitRepo . Ctx , gitRepo . Path , result . oldCommitID )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: unable to get GetFullCommitID[%s]: %v" , m . Repo , result . oldCommitID , err )
2021-06-14 13:20:43 -04:00
continue
}
2022-01-19 18:26:57 -05:00
newCommitID , err := git . GetFullCommitID ( gitRepo . Ctx , gitRepo . Path , result . newCommitID )
2021-06-14 13:20:43 -04:00
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: unable to get GetFullCommitID [%s]: %v" , m . Repo , result . newCommitID , err )
2021-06-14 13:20:43 -04:00
continue
}
commits , err := gitRepo . CommitsBetweenIDs ( newCommitID , oldCommitID )
if err != nil {
2022-03-10 05:09:48 -05:00
log . Error ( "SyncMirrors [repo: %-v]: unable to get CommitsBetweenIDs [new_commit_id: %s, old_commit_id: %s]: %v" , m . Repo , newCommitID , oldCommitID , err )
2021-06-14 13:20:43 -04:00
continue
}
2021-08-09 14:08:51 -04:00
theCommits := repo_module . GitToPushCommits ( commits )
2021-06-14 13:20:43 -04:00
if len ( theCommits . Commits ) > setting . UI . FeedMaxCommitNum {
theCommits . Commits = theCommits . Commits [ : setting . UI . FeedMaxCommitNum ]
}
2024-04-22 07:48:42 -04:00
newCommit , err := gitRepo . GetCommit ( newCommitID )
if err != nil {
2023-03-03 23:45:53 -05:00
log . Error ( "SyncMirrors [repo: %-v]: unable to get commit %s: %v" , m . Repo , newCommitID , err )
continue
}
2024-04-22 07:48:42 -04:00
theCommits . HeadCommit = repo_module . CommitToPushCommit ( newCommit )
2021-06-14 13:20:43 -04:00
theCommits . CompareURL = m . Repo . ComposeCompareURL ( oldCommitID , newCommitID )
2023-09-05 14:37:47 -04:00
notify_service . SyncPushCommits ( ctx , m . Repo . MustOwner ( ctx ) , m . Repo , & repo_module . PushUpdateOptions {
2021-06-14 13:20:43 -04:00
RefFullName : result . refName ,
OldCommitID : oldCommitID ,
NewCommitID : newCommitID ,
} , theCommits )
}
log . Trace ( "SyncMirrors [repo: %-v]: done notifying updated branches/tags - now updating last commit time" , m . Repo )
2024-04-12 23:01:02 -04:00
isEmpty , err := gitRepo . IsEmpty ( )
2021-06-14 13:20:43 -04:00
if err != nil {
2024-04-12 23:01:02 -04:00
log . Error ( "SyncMirrors [repo: %-v]: unable to check empty git repo: %v" , m . Repo , err )
2021-06-14 13:20:43 -04:00
return false
}
2024-04-12 23:01:02 -04:00
if ! isEmpty {
// Get latest commit date and update to current repository updated time
commitDate , err := git . GetLatestCommitTime ( ctx , m . Repo . RepoPath ( ) )
if err != nil {
log . Error ( "SyncMirrors [repo: %-v]: unable to GetLatestCommitDate: %v" , m . Repo , err )
return false
}
if err = repo_model . UpdateRepositoryUpdatedTime ( ctx , m . RepoID , commitDate ) ; err != nil {
log . Error ( "SyncMirrors [repo: %-v]: unable to update repository 'updated_unix': %v" , m . Repo , err )
return false
}
2021-06-14 13:20:43 -04:00
}
log . Trace ( "SyncMirrors [repo: %-v]: Successfully updated" , m . Repo )
return true
}
2023-10-03 06:30:41 -04:00
func checkAndUpdateEmptyRepository ( ctx context . Context , m * repo_model . Mirror , gitRepo * git . Repository , results [ ] * mirrorSyncResult ) bool {
2021-06-14 13:20:43 -04:00
if ! m . Repo . IsEmpty {
return true
}
hasDefault := false
hasMaster := false
hasMain := false
defaultBranchName := m . Repo . DefaultBranch
if len ( defaultBranchName ) == 0 {
defaultBranchName = setting . Repository . DefaultBranch
}
firstName := ""
for _ , result := range results {
2023-05-25 21:04:48 -04:00
if ! result . refName . IsBranch ( ) {
2021-06-14 13:20:43 -04:00
continue
}
2023-05-25 21:04:48 -04:00
name := result . refName . BranchName ( )
2021-06-14 13:20:43 -04:00
if len ( firstName ) == 0 {
firstName = name
}
hasDefault = hasDefault || name == defaultBranchName
hasMaster = hasMaster || name == "master"
hasMain = hasMain || name == "main"
}
if len ( firstName ) > 0 {
if hasDefault {
m . Repo . DefaultBranch = defaultBranchName
} else if hasMaster {
m . Repo . DefaultBranch = "master"
} else if hasMain {
m . Repo . DefaultBranch = "main"
} else {
m . Repo . DefaultBranch = firstName
}
// Update the git repository default branch
2024-03-08 02:30:10 -05:00
if err := gitrepo . SetDefaultBranch ( ctx , m . Repo , m . Repo . DefaultBranch ) ; err != nil {
2021-06-14 13:20:43 -04:00
if ! git . IsErrUnsupportedVersion ( err ) {
log . Error ( "Failed to update default branch of underlying git repository %-v. Error: %v" , m . Repo , err )
2023-10-02 10:52:18 -04:00
desc := fmt . Sprintf ( "Failed to update default branch of underlying git repository '%s': %v" , m . Repo . RepoPath ( ) , err )
2022-10-16 19:29:26 -04:00
if err = system_model . CreateRepositoryNotice ( desc ) ; err != nil {
2021-06-14 13:20:43 -04:00
log . Error ( "CreateRepositoryNotice: %v" , err )
}
return false
}
}
m . Repo . IsEmpty = false
// Update the is empty and default_branch columns
2023-10-03 06:30:41 -04:00
if err := repo_model . UpdateRepositoryCols ( ctx , m . Repo , "default_branch" , "is_empty" ) ; err != nil {
2021-06-14 13:20:43 -04:00
log . Error ( "Failed to update default branch of repository %-v. Error: %v" , m . Repo , err )
2023-10-02 10:52:18 -04:00
desc := fmt . Sprintf ( "Failed to update default branch of repository '%s': %v" , m . Repo . RepoPath ( ) , err )
2022-10-16 19:29:26 -04:00
if err = system_model . CreateRepositoryNotice ( desc ) ; err != nil {
2021-06-14 13:20:43 -04:00
log . Error ( "CreateRepositoryNotice: %v" , err )
}
return false
}
}
return true
}