1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-11-04 08:17:17 -05:00
elinks/src
Miciah Dashiel Butler Masters 9e04b0ec8c Fix bug 944: avoid duplicate type-query handlers
Previously, init_type_query would check to make sure that it doesn't create a
duplicate type query and would return NULL if it otherwise would create a
duplicate.  Then setup_download_handler would return 0 to do_move.

This patch changes setup_download_handler to return 1 to do_move in this
situation so that do_move stops trying to load the document.

This avoid a crash when loading twice the same file in the same tab when
loading the file opens a type query.
2008-05-11 15:42:21 +00:00
..
bfu Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
bookmarks get_opt_*: Add ses parameter 2007-08-28 17:24:59 +00:00
cache bug 1009: id variables renamed, added document_id to the document. 2008-04-27 23:22:08 +03:00
config Merge branch 'elinks-0.12' into elinks-0.13 2008-04-28 22:08:19 +03:00
cookies Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
dialogs Merge branch 'elinks-0.12' into elinks-0.13 2008-02-24 22:49:47 +02:00
document bug 1009: id variables renamed, added document_id to the document. 2008-04-27 23:22:08 +03:00
dom Merge branch 'elinks-0.12' 2007-09-09 18:25:49 +02:00
ecmascript bug 1009: id variables renamed, added document_id to the document. 2008-04-27 23:22:08 +03:00
encoding Merge branch 'elinks-0.12' into elinks-0.13 2008-03-01 17:28:37 +02:00
formhist Declare element types of lists. 2007-07-26 22:47:23 +03:00
globhist get_opt_*: Add ses parameter 2007-08-28 17:24:59 +00:00
intl Merge branch 'elinks-0.12' into elinks-0.13 2008-02-03 22:30:46 +02:00
main Bug 824: Disable combining characters unless --enable-combining. 2008-01-19 20:58:22 +02:00
mime bug 638: More comments. Assert that calls don't nest. 2008-03-22 14:06:47 +02:00
network bug 991: Added the bit field cgi to the structs connection and type_query. 2008-03-15 19:25:01 +02:00
osdep Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64 2008-02-10 11:30:27 +02:00
protocol Merge branch 'elinks-0.12' into elinks-0.13 2008-04-28 22:08:19 +03:00
scripting Bug 975: Fix int/size_t pointer type mismatch. 2007-11-10 19:28:01 +02:00
session Fix bug 944: avoid duplicate type-query handlers 2008-05-11 15:42:21 +00:00
terminal Merge branch 'elinks-0.12' into elinks-0.13 2008-02-24 22:49:47 +02:00
util Merge branch 'elinks-0.12' into elinks-0.13 2008-04-28 22:08:19 +03:00
viewer bug 1009: id variables renamed, added document_id to the document. 2008-04-27 23:22:08 +03:00
.gitignore Ignore tags file 2007-08-08 14:25:38 +02:00
elinks.h
Makefile BUILD_ID: Fix dirt check when srcdir != builddir. 2008-03-01 14:30:57 +02:00
README
setup.h Make copyright info independent from translations. 2007-10-03 11:53:09 +02:00
vernum.c
vernum.h

				  The Big View

The whole dependency tree is supposed (in ideal world) to look somewhat like
the following. Please note that this deals only with the core parts of ELinks,
not extensions like bookmarks, cookies, globhist, mime etc. Those act like
modules and are generally self-contained - the main visible difference is that
they don't have their UI stuff in dialogs/foo.c but in foo/dialogs.c.

Note also that it isn't all that clean-cut as it looks. Some parts of e.g.
lowlevel/ or osdep/ are omnipresent as well and it's meant to be so (at least
for now). Also some other exceptions are possible; the exception to this is
util/, where no exceptions are permitted - it must have no dependencies to the
rest of the code whatsoever, not even compile-time ones. The other way around,
the gettext part of intl/ is generally omnipresent but the charset part is
pretty isolated - it could be probably drawn as connected to document and
terminal (actually, it is used when encoding forms in viewer too, but that
stuff should be probably moved to document).

viewer/ contains code concerning that big rectangle between bars at the top
and bars at the bottom, documents usually being shown inside. Logically, it
is in fact kind of a BFU widget, but in practice it has little in common with
the bfu/ widgets, it is special in many ways and deeply woven to the fabric
of session/ (e.g. session history is basically a chain of viewer widget
descriptors).

dialogs/ is special too. It in fact means to say "global and unique BFU
instances belonging to the ELinks core"/ but that's a rather long and boring
name, besides the nightmares associated with maintaining files and directories
containing spaces in GIT. The "global and unique BFU instances" part can be
represented by exmode, menus and leds (were they there). The "ELinks core"
part can be represented by options, document and downloads. The reason those
aren't in their respective directories (while bookmarks or formhist have their
dialogs.c) is that it's important to keep the dependencies sorted out
reasonably. Had there been e.g. terminal/dialogs.c, it would mean libterminal
has to depend on libbfu.a and so. (There are two 'managerial' exceptions
to this; don't dig into them, please. ;-)

scripting/ (== browser scripting) is also expected to hook all around, perhaps
it should be better in the omnipresent box.

The edges are directed and represent the "using" relation. Therefore,
"bfu -> terminal" means "bfu/ is using terminal/ services (but not
the other way around)".

.---------.
| util/   | <-- This is omnipresent :)
| config/ |
| intl/   |
`---------'

                   .-------.         .---------.
                   |  bfu  |<------- | dialogs |
                   `-------' \       `---------'
                       v      `---.       |
                 .----------.      \ .--------.
                 | terminal | <----- | viewer | <-----------------.
               / `----------'     .> `--------'                   |
           .--'        v         /        v                       v
.-------. /      .----------.   |    .----------.       .----/ecmascript/----.
| osdep |<------ | lowlevel |   |    | document | ----> | document scripting |
`-------' \      `----------'   |    `----------'       `--------------------'
           `---.       ^         \        ^
                \ .---------.     `> .---------.        .----/scripting/----.
                  | network | <----- | session | -----> | browser scripting |
                  `---------'      / `---------'        `-------------------'
                       ^       .--'
                 .----------. <
                 | protocol |
                 `----------'