1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
elinks/src
Jonas Fonseca af7ce38639 BOOKMARKS: Fix XBEL calling add_bookmark() with NULL title
It didn't check that both title and title->text was non NULL. In either
case it now passes "No title" string to add_bookmark().

Reported by Neuromancer.

Tested with both:

	<bookmark href="empty://title"><title></title><bookmark>
	<bookmark href="no://title"></bookmark>
2006-11-27 16:56:12 +01:00
..
bfu Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
bookmarks BOOKMARKS: Fix XBEL calling add_bookmark() with NULL title 2006-11-27 16:56:12 +01:00
cache Use internal OFF_T_FORMAT instead of PRId64 2006-08-05 00:39:14 +02:00
config Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
cookies Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
dialogs Use internal OFF_T_FORMAT instead of PRId64 2006-08-05 00:39:14 +02:00
document Normalize all links added by the plain renderer 2006-01-29 12:06:30 +01:00
dom Apply the many changes to Makefile.lib in one go 2006-01-29 12:41:14 +01:00
ecmascript Bug 846: Document the expected parents of form_elements_class instances. 2006-11-26 19:06:28 +02:00
encoding Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
formhist Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
globhist Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
intl Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
main Make elinks tcc (tiny C compiler) friendly. 2006-01-29 11:28:05 +01:00
mime Apply the many changes to Makefile.lib in one go 2006-01-29 12:41:14 +01:00
network Fix compilation on Minix3 2006-08-22 22:10:51 +02:00
osdep Fix compilation on Minix3 2006-08-22 22:10:51 +02:00
protocol Bug 841, CVE-2006-5925: Prevent enabling the SMB protocol. 2006-11-18 22:37:51 +02:00
scripting SMJS: keymap_get_property: fix build error 2006-11-26 15:57:52 +02:00
session Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
terminal Remove .vimrc files; use the Vim ftplugin instead 2006-01-29 10:45:22 +01:00
util Revert 06eb3fa02abf12c6d2352af4288a6ad465a0e8c1 (in the historic repo) 2006-01-29 12:28:43 +01:00
viewer Ecmascript: activate link only when onClick returns true 2006-08-22 23:49:40 +02:00
elinks.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
Makefile Store lib.o name in a variable named LIB_O_NAME. 2006-01-29 10:22:19 +01:00
README Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
setup.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
vernum.c Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
vernum.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00

				  The Big View

The whole dependency tree is supposed (in ideal world) to look somewhat like
the following. Please note that this deals only with the core parts of ELinks,
not extensions like bookmarks, cookies, globhist, mime etc. Those act like
modules and are generally self-contained - the main visible difference is that
they don't have their UI stuff in dialogs/foo.c but in foo/dialogs.c.

Note also that it isn't all that clean-cut as it looks. Some parts of e.g.
lowlevel/ or osdep/ are omnipresent as well and it's meant to be so (at least
for now). Also some other exceptions are possible; the exception to this is
util/, where no exceptions are permitted - it must have no dependencies to the
rest of the code whatsoever, not even compile-time ones. The other way around,
the gettext part of intl/ is generally omnipresent but the charset part is
pretty isolated - it could be probably drawn as connected to document and
terminal (actually, it is used when encoding forms in viewer too, but that
stuff should be probably moved to document).

viewer/ contains code concerning that big rectangle between bars at the top
and bars at the bottom, documents usually being shown inside. Logically, it
is in fact kind of a BFU widget, but in practice it has little in common with
the bfu/ widgets, it is special in many ways and deeply woven to the fabric
of session/ (e.g. session history is basically a chain of viewer widget
descriptors).

dialogs/ is special too. It in fact means to say "global and unique BFU
instances belonging to the ELinks core"/ but that's a rather long and boring
name, besides the nightmares associated with maintaining files and directories
containing spaces in GIT. The "global and unique BFU instances" part can be
represented by exmode, menus and leds (were they there). The "ELinks core"
part can be represented by options, document and downloads. The reason those
aren't in their respective directories (while bookmarks or formhist have their
dialogs.c) is that it's important to keep the dependencies sorted out
reasonably. Had there been e.g. terminal/dialogs.c, it would mean libterminal
has to depend on libbfu.a and so. (There are two 'managerial' exceptions
to this; don't dig into them, please. ;-)

scripting/ (== browser scripting) is also expected to hook all around, perhaps
it should be better in the omnipresent box.

The edges are directed and represent the "using" relation. Therefore,
"bfu -> terminal" means "bfu/ is using terminal/ services (but not
the other way around)".

.---------.
| util/   | <-- This is omnipresent :)
| config/ |
| intl/   |
`---------'

                   .-------.         .---------.
                   |  bfu  |<------- | dialogs |
                   `-------' \       `---------'
                       v      `---.       |
                 .----------.      \ .--------.
                 | terminal | <----- | viewer | <-----------------.
               / `----------'     .> `--------'                   |
           .--'        v         /        v                       v
.-------. /      .----------.   |    .----------.       .----/ecmascript/----.
| osdep |<------ | lowlevel |   |    | document | ----> | document scripting |
`-------' \      `----------'   |    `----------'       `--------------------'
           `---.       ^         \        ^
                \ .---------.     `> .---------.        .----/scripting/----.
                  | network | <----- | session | -----> | browser scripting |
                  `---------'      / `---------'        `-------------------'
                       ^       .--'
                 .----------. <
                 | protocol |
                 `----------'