1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-11-04 08:17:17 -05:00
Commit Graph

1213 Commits

Author SHA1 Message Date
Laurent MONIN
f835a27e25 Fix crash due to untested null pointer occuring when doing
HTTP_PROXY=8080:proxy.ucv.cl elinks http://wwww.google.cl. Thanks to
Karel Zak.

[ From commit 947c1730a6 in ELinks 0.12.GIT.
  This crash occurs in ELinks 0.11.0 but not in 0.10.6.  --KON ]
2007-04-07 11:15:47 +03:00
Kalle Olavi Niemitalo
977a6df851 NEWS: mention decoding of URI fragment 2007-04-07 10:54:50 +03:00
Miciah Dashiel Butler Masters
a495814482 Decode the fragment identifier extracted from the URI when looking it up
This fixes a problem with fragment references that was reported
by Thomas Adam.

[ Backported from commit c22f38413e in
  ELinks 0.12.GIT, without changing localizable strings.  --KON ]
2007-04-07 10:51:38 +03:00
Kalle Olavi Niemitalo
f8a89597cd NEWS: mention the authentication dialog 2007-04-06 22:43:54 +03:00
Kalle Olavi Niemitalo
b5bbcb2f3a do_auth_dialog: Fix off-by-one error leading to reads of uninitialized memory.
This bug manifested as a junk character at the end of the text in the
authentication dialog.

[ From commit ca496aa2dd in ELinks
  0.12.GIT.  --KON ]
2007-04-06 22:38:46 +03:00
Kalle Olavi Niemitalo
319f362432 NEWS: mention umask in secure file saving 2007-04-06 15:25:59 +03:00
Miciah Dashiel Butler Masters
40f5e23fb0 Secure file saving: restore umask after _all_ failure conditions
The secure file saving code plays some shenanigans with the umask.
Previously, the code could fail to restore the old umask when certain libc
calls failed: malloc, mkstemp, fdopen, and fopen. This resulted in
unrelated code creating files with the wrong umode. Specifically, the
download code's automatic directory creation was creating directories
without the execute permission bit.

Thanks to Quiznos for reporting and helping to track the problem down.

[ Backported from commit 7f0fb0440c in
  ELinks 0.12.GIT.  The general download code in 0.11.2.GIT does not
  automatically create directories but the BitTorrent code does.  --KON ]
2007-04-06 15:18:49 +03:00
Kalle Olavi Niemitalo
452d4c0f61 NEWS: Undocument the reverted Python goto_url_hook change. 2007-04-06 14:32:11 +03:00
Kalle Olavi Niemitalo
1dfdb6e19b Revert 8bedf25b, "goto_url_hook takes 2 params not 1."
Revert 8bedf25bf8.  Different versions
of ELinks call the Python goto_url_hook with different arguments:

- goto_url_hook(current) in 0.11.0, 0.11.1, and 0.11.2.

- goto_url_hook(new, current) in 0.11.2.GIT since 2007-11-27, commit
  8bedf25bf8 which I'm now reverting.
  No released version of ELinks has used this variant.

- goto_url_hook(new) in 0.12.GIT since 2007-01-01, commit
  26473f72f5.  The hook can call
  elinks.current_url() if desired.

I think it will be less confusing to users if we drop the middle
variant and make the rest of the stable 0.11 branch call the hook in
the same way as 0.11.2 did.  The difference will then be only between
the 0.11 and 0.12 branches.
2007-04-06 14:30:00 +03:00
Kalle Olavi Niemitalo
854cc4b5fd Remove inaccurate information from README.Python.
These parts of contrib/python/README.Python are not accurate for
ELinks 0.11.2.GIT:

- It suggests using --with-python=/usr/local, but configure.in treats
  that as equivalent to --without-python and contains a comment:

	# FIXME: If withval is a valid directory append it to PATH
	# so that you can specify one of several Python installations.

- It suggests creating a libpython.so symbolic link, but as of commit
  421d04093a, the configure script no
  longer tries to link with a bare -lpython but rather always appends
  a version number.
2007-04-05 11:31:35 +03:00
Kalle Olavi Niemitalo
be7f2ecda0 NEWS: mention bug 880 2007-04-05 10:50:30 +03:00
Kalle Olavi Niemitalo
defc67d020 Bug 880: Prevent SIGSEGV in init_python when -no-home is used.
Before this patch, init_python would crash trying to set up the
PYTHONPATH environment variable.  Now it omits the home directory
from the variable in that case.

[ Related to commit 78bd416dc0 in ELinks
  0.12.GIT but quite different internally.  --KON ]
2007-04-05 10:10:32 +03:00
Kalle Olavi Niemitalo
ce2137c035 NEWS: mention the SMJS null pointer crash 2007-04-05 00:20:37 +03:00
Miciah Dashiel Butler Masters
0fe04536b3 SMJS: fix segfault on exit
Create and immediately destroy a context when initialising the SMJS
document scripting module, because SMJS crashes on exit if there has
been no context created since it started, which is the case if one does
not load any documents.

[ From commit d7a964efaf in ELinks
  0.12.GIT.  --KON ]
2007-04-05 00:16:15 +03:00
Kalle Olavi Niemitalo
3d7a3f751b NEWS: mention bug 921 and Debian 313696 2007-04-04 01:01:32 +03:00
Kalle Olavi Niemitalo
23468745cd NEWS: mention bug 768 2007-04-02 23:08:30 +03:00
Witold Filipczyk
421d04093a Bugfix for bug 768
[ Backported from commit 49ce097505 in
  ELinks 0.12.GIT.  The configure.in of 0.11 does not use $PYTHON and
  $python_prefix.  --KON ]
2007-04-02 23:05:08 +03:00
Miciah Dashiel Butler Masters
63de05a585 menu_handler: Don't call get_parent_ptr for redraw events
Only call get_parent_ptr for resize events so that the menu isn't moved
to the cursor position for normal redraw events.

Without this change, if ui.leds.enable and ui.clock.enable are 1 and
the user opens the tab menu, it first appears near the tab bar and
almost immediately jumps near the cursor.  With this change, the tab
menu stays near the tab bar.  However, if the user presses Ctrl+L,
then the menu still jumps; but that is less annoying than having it
jump on its own.

[ From commit 1a89589b13 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 22:05:43 +03:00
Kalle Olavi Niemitalo
d0255cf7dd doc: cut-clipboard does not merely delete text from clipboard.
[ From commit 315f4e0342 in ELinks
  0.12.GIT.  This commit adds a string that perhaps won't be
  translated in time for the 0.11.3 release, but I think it is
  better to display a correct description in the wrong language
  than a misleading description in the right language.  --KON ]
2007-04-01 21:22:55 +03:00
Witold Filipczyk
06b9ee5ff0 Removed outdated entries.
[ From commit 5c51b0a2ae in ELinks
  0.12.GIT.  --KON ]
2007-04-01 21:10:43 +03:00
Kalle Olavi Niemitalo
7e8020a36f "Do not show anymore" resets ui.success_msgbox, instead of toggling it.
Normally, the success msgbox is shown only if the ui.success_msgbox
option is set as 1, and clicking "Do not show anymore" would then
toggle the option to 0, and no more such msgboxes would appear.
However, if there already are two success msgboxes being displayed
(most likely in different terminals), then clicking "Do not show
anymore" in the first of them would reset the option to 0, but doing
the same in the second of them would toggle the option back to 1.

Rename toggle_success_msgbox to disable_success_msgbox, and make it
always reset the option to 0, regardless of the previous value.

[ From commit 7185e926e6 in ELinks
  0.12.GIT.  This I think does not deserve a NEWS entry.  --KON ]
2007-04-01 21:09:12 +03:00
Kalle Olavi Niemitalo
74799c60b2 NEWS: more verbose descriptions from 0.12.GIT 2007-04-01 15:30:43 +03:00
Kalle Olavi Niemitalo
d5d918e26b NEWS: more verbose descriptions from 0.12.GIT; mention bug 630 2007-04-01 15:12:51 +03:00
Kalle Olavi Niemitalo
22d051925e do_move_bookmark: Update comment to match reality. 2007-04-01 14:59:28 +03:00
Kalle Olavi Niemitalo
007207c796 NEWS: mention half of bug 396 2007-04-01 12:19:09 +03:00
Laurent MONIN
a3fb7f097c Compilation fix: _GNU_SOURCE has to be defined on GNU platforms to get
strcasestr().

[ From commit 7585eedd2e in ELinks
  0.12.GIT.  --KON ]
2007-04-01 12:14:33 +03:00
Jonas Fonseca
a822daef26 Add support for more graceful detection of HTML content
It will grab at the first fragment of the cache entry and try to detect the
content-type by looking for valid HTML. It is very stupid for now, simply
searching for "<html>", which may be bogus in certain circumstances. And I
am not sure if this is better left out and up to the scripting backends,
e.g. SMJS can now modify the cache entry.

A feable fix for bug 396.

[ From commit 3ea73da7df in ELinks
  0.12.GIT.  --KON ]
2007-04-01 12:10:03 +03:00
Kalle Olavi Niemitalo
60dbf024e5 NEWS: mention the crash in the file extensions menu 2007-04-01 12:05:31 +03:00
Miciah Dashiel Butler Masters
94e153194c MIME: fix crash with empty File extensions menu
Delete the FREE_LIST flag from mi_no_ext so that free_menu_items doesn't
try to free static memory.

This fixes a crash reproducible by deleting every entry under Setup -> File
extensions, opening said menu, and then closing said menu.

[ From commit b41c7d4055 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 12:03:03 +03:00
Kalle Olavi Niemitalo
36f987840a NEWS: mention bug 760 2007-04-01 12:01:07 +03:00
Miciah Dashiel Butler Masters
cf4bfd6b75 do_move_bookmarks: replace destb and desti parameters with insert_as_child flag
Simplify do_move_bookmarks (from a readability perspective) by replacing
the destb and desti parameters with a new insert_as_child flag. Inspired
by Kalle Olavi Niemitalo.

[ Backported from commit 32ec5d1db3 in
  ELinks 0.12.GIT.  This change is not required for fixing bug 760, but
  the bookmark code in ELinks 0.12.GIT has been tested more with the
  change than without it, so I think applying it is safest.  --KON ]
2007-04-01 11:58:40 +03:00
Miciah Dashiel Butler Masters
f287d5aa31 Bookmarks: Fix update after move
do_move_bookmark was only updating the selection in the bookmarks manager
window in which the Move button was pressed. Now all windows are updated.

This patch also prevents a crash when the first item that was displayed
in a box was the last child of a folder and was being moved (the comment
removed in this patch was incorrect in assuming that bm->box->next must
be valid because it neglected to account for non-root children).

This change required that I move the definition of struct
hierbox_dialog_list_item from src/bfu/hierbox.c to src/bfu/hierbox.h.

Thanks to Kalle Olavi Niemitalo for finding both the update problem
and the crash.

[ Backported from commit 6f98f5fd96 in
  ELinks 0.12.GIT.  --KON ]
2007-04-01 11:49:37 +03:00
Kalle Olavi Niemitalo
c7987e331c NEWS: mention bug 927 2007-04-01 11:34:00 +03:00
Witold Filipczyk
a3862170ff Fix the memleak. Part II of the 927 bugfix.
[ From commit 27a66f59d9 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 11:30:46 +03:00
Witold Filipczyk
7a56204271 The fix for the bug 927.
When tables were rendered first time html_format_part was called with
document==NULL. <meta http-equiv=Refresh.../> was inside a table,
so document was NULL. Second time the table knew its dimensions
and document was not NULL.

[ From commit e01785e462 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 11:30:24 +03:00
Kalle Olavi Niemitalo
6bf41676b3 NEWS: show the severities of bugs; mention bug 872 2007-04-01 11:20:51 +03:00
Kalle Olavi Niemitalo
22524ad32b NEWS: mention bug 767 2007-04-01 11:02:20 +03:00
Laurent MONIN
b918ab57de Let be more tolerant with buggy meta refresh. It should fix bug 767.
[ From commit 36a277540c in ELinks
  0.12.GIT.  --KON ]
2007-04-01 10:57:35 +03:00
Kalle Olavi Niemitalo
73696e34ce NEWS: mention bug 24 2007-04-01 00:39:39 +03:00
Kalle Olavi Niemitalo
935f02c0f0 BFU: Fix infinite loops in menus that have only unselectable elements.
src/bfu/menu.c (scroll_menu): Let neither menu->selected nor pos
become -2.

src/bfu/menu.c (menu_mouse_handler): Call set_menu_selection directly
rather than via scroll_menu, as sel is already known to be selectable.
(Not required for fixing the bug.)

src/bfu/menu.c (menu_search_handler): Break infinite loops also if
menu->selected is -1 initially.

src/bfu/menu.c (menu_handler): Instead of tweaking menu->selected
directly, let scroll_menu do it.

[ From commit 0a8633d07e in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:33:45 +03:00
Kalle Olavi Niemitalo
220b0d770a BFU: Fix searching in menus past unselectable items.
The bug was that menu_search_handler gave scroll_menu an incorrect
count because it didn't know that scroll_menu skips unselectable
items.

[ From commit 9fa5ae374f in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:32:03 +03:00
Kalle Olavi Niemitalo
22f1dedaad NEWS: mention bug 886 2007-04-01 00:19:56 +03:00
Kalle Olavi Niemitalo
681f34d8d0 Bug 886: Set cookies_dirty if a cookie is edited via the manager.
If the appropriate option is set, this now causes the cookies to be
immediately saved as well.

[ From commit 3cd0fbe5f0 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:16:36 +03:00
Kalle Olavi Niemitalo
0bdbb983b8 Bug 886: Update cookies_dirty after delete_cookie calls as appropriate.
[ From commit fad9c75cc6 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:15:47 +03:00
Kalle Olavi Niemitalo
f311f3ea93 Bug 886: Postpone resaving the cookies until a bottom half.
[ From commit b79210ea1b in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:13:25 +03:00
Kalle Olavi Niemitalo
89f1e654c6 Bug 886: Document why delete_cookie does not set cookies_dirty.
[ From commit 8ecf105cd5 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:11:26 +03:00
Kalle Olavi Niemitalo
72186129ec NEWS: mention bug 908 2007-04-01 00:03:04 +03:00
Miciah Dashiel Butler Masters
83663ac993 Re-use @fs in activate_link instead of introducing a new local variable
This optimisation is made possible by commit
4a9b80eea0.

[ From commit 896cdab771 in ELinks
  0.12.GIT.  --KON ]
2007-04-01 00:00:26 +03:00
Kalle Olavi Niemitalo
4a9b80eea0 Bug 908, activate_link: Set fs->state before the fs pointer becomes invalid.
[ From commit 15dce57bc9 in ELinks
  0.12.GIT.  --KON ]
2007-03-31 23:59:14 +03:00
Kalle Olavi Niemitalo
9b7217e286 NEWS: mention bug 772 2007-03-31 23:07:37 +03:00