1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00

try_mark_key: try to improve readability by using a local var and a cast

The cast is not necessary since we already check the bounds, but by using a
cast here, it hopefully makes it more obvious what the long comment above
is pointing out: namely that we put the value of a signed integer into an
unsigned char.
This commit is contained in:
Jonas Fonseca 2006-08-13 13:27:16 +02:00 committed by Jonas Fonseca
parent f24fa6ef63
commit edeb934cc3

View File

@ -637,6 +637,7 @@ enum frame_event_status
try_mark_key(struct session *ses, struct document_view *doc_view,
struct term_event *ev)
{
term_event_key_T key = get_kbd_key(ev);
unsigned char mark;
/* set_mark and goto_mark allow only a subset of the ASCII
@ -646,8 +647,8 @@ try_mark_key(struct session *ses, struct document_view *doc_view,
* will not accept, so the results are consistent.
* When CONFIG_UTF_8 is not defined, this assumes that codes
* 0 to 0x7F in all codepages match ASCII. */
if (get_kbd_key(ev) >= 0 && get_kbd_key(ev) <= 0x7F)
mark = get_kbd_key(ev);
if (key >= 0 && key <= 0x7F)
mark = (unsigned char) key;
else
mark = 0;