aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
Code

SMJS: verbose comment about JS_AddNamedStringRoot

Browse Source
This commit is contained in:
Kalle Olavi Niemitalo 2012-11-25 21:05:52 +02:00 committed by Kalle Olavi Niemitalo
parent 767a1c4228
commit c4a23543fd
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/scripting/smjs/bookmarks.c
View File

@ -112,7 +112,19 @@ jsval_to_bookmark_string(JSContext *ctx, jsval val, unsigned char **result)
JSString *jsstr = NULL;
unsigned char *str;
/* jsstring_to_utf8() might GC; protect the string to come. */
/* JS_ValueToString constructs a new string if val is not
* already a string. Protect the new string from the garbage
* collector, which jsstring_to_utf8() may trigger.
*
* Actually, SpiderMonkey 1.8.5 does not require this
* JS_AddNamedStringRoot call because it conservatively scans
* the C stack for GC roots. Do the call anyway, because:
* 1. Omitting the call would require somehow ensuring that the
* C compiler won't reuse the stack location too early.
* (See template class js::Anchor in <jsapi.h>.)
* 2. Later versions of SpiderMonkey are switching back to
* precise GC rooting, with a C++-only API.
* 3. jsval_to_bookmark_string() does not seem speed-critical. */
if (!JS_AddNamedStringRoot(ctx, &jsstr, "jsval_to_bookmark_string"))
return JS_FALSE;