aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-11-04 08:17:17 -05:00
Code

do_smb: URI-encode the username and password.

Browse Source 
I tested that this does the right thing for the username "Kalle %50"
(encodes it to "Kalle%20%2550", and libsmbclient then decodes back).
This commit is contained in:
Kalle Olavi Niemitalo 2007-03-25 12:13:46 +03:00 committed by Kalle Olavi Niemitalo
parent 1b0b08f31b
commit 9955ca8e5a
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/protocol/smb/smb2.c
View File

@ -295,10 +295,21 @@ do_smb(struct connection *conn)
if (!uri_string || !init_string(&string)) {
smb_error(-S_OUT_OF_MEM);
}
/* Must URI-encode the username and password to avoid
* ambiguity if they contain "/:@" characters.
* Libsmbclient then decodes them again, and the
* server gets them as they were in auth->user and
* auth->password, i.e. as the user typed them in the
* auth dialog. This implies that, if the username or
* password contains some characters or bytes that the
* user cannot directly type, then she cannot enter
* them. If that becomes an actual problem, it should
* be fixed in the auth dialog, e.g. by providing a
* hexadecimal input mode. */
add_to_string(&string, "smb://");
add_to_string(&string, auth->user);
encode_uri_string(&string, auth->user, -1, 1);
add_char_to_string(&string, ':');
add_to_string(&string, auth->password);
encode_uri_string(&string, auth->password, -1, 1);
add_char_to_string(&string, '@');
add_to_string(&string, uri_string);
url = string.source;