NET: Move cache entry normalization to abort_connection

It simplifies the code and ensures that stuff like conn->from is properly
updated.

src/network/connection.c

@@ -724,6 +724,9 @@ abort_connection(struct connection *conn, enum connection_state state)
 	assertm(is_in_result_state(state),
 		"connection didn't end in result state (%d)", state);
 
+	if (state == S_OK && conn->cached)
+		normalize_cache_entry(conn->cached, conn->from);
+
 	set_connection_state(conn, state);
 
 	if (conn->running) interrupt_connection(conn);

src/protocol/about.c

@@ -114,8 +114,6 @@ about_protocol_handler(struct connection *conn)
 		}
 #endif
 
-		normalize_cache_entry(cached, len);
-
 		/* Set content to known type */
 		mem_free_set(&cached->content_type, stracpy("text/html"));
 	}

src/protocol/data.c

@@ -157,7 +157,6 @@ data_protocol_handler(struct connection *conn)
 		int datalen = strlen(data);
 
 		add_fragment(cached, conn->from, data, datalen);
-		normalize_cache_entry(cached, datalen);
 	}
 
 	mem_free(data);

src/protocol/file/file.c

@@ -279,6 +279,7 @@ file_protocol_handler(struct connection *connection)
 
 		} else {
 			add_fragment(cached, 0, page.source, page.length);
+			connection->from += page.length;
 
 			if (!cached->content_type) {
 				unsigned char *ctype = null_or_stracpy(type);
@@ -287,15 +288,10 @@ file_protocol_handler(struct connection *connection)
 				 * allocation. */
 				if (type && !ctype)
 					state = S_OUT_OF_MEM;
-				else
-					normalize_cache_entry(cached, page.length);
 
 				/* Setup file read or directory listing for
 				 * viewing. */
 				mem_free_set(&cached->content_type, ctype);
-
-			} else {
-				normalize_cache_entry(cached, page.length);
 			}
 
 			done_string(&page);

src/protocol/finger/finger.c

@@ -27,15 +27,6 @@ struct module finger_protocol_module = struct_module(
 	/* done: */		NULL
 );
 
-static void
-finger_end_request(struct connection *conn, enum connection_state state)
-{
-	if (state == S_OK && conn->cached)
-		normalize_cache_entry(conn->cached, conn->from);
-
-	abort_connection(conn, state);
-}
-
 static void
 finger_get_response(struct socket *socket, struct read_buffer *rb)
 {
@@ -50,7 +41,7 @@ finger_get_response(struct socket *socket, struct read_buffer *rb)
 	conn->cached = cached;
 
 	if (socket->state == SOCKET_CLOSED) {
-		finger_end_request(conn, S_OK);
+		abort_connection(conn, S_OK);
 		return;
 	}
 

src/protocol/fsp/fsp.c

@@ -232,8 +232,6 @@ fsp_got_data(struct socket *socket, struct read_buffer *rb)
 	}
 
 	if (!len) {
-		if (conn->from)
-			normalize_cache_entry(conn->cached, conn->from);
 		abort_connection(conn, S_OK);
 		return;
 	}

src/protocol/gopher/gopher.c

@@ -346,7 +346,6 @@ end_gopher_connection(struct connection *conn, enum connection_state state)
 			conn->from -= 3;
 		}
 #endif
-		normalize_cache_entry(conn->cached, conn->from);
 	}
 
 	abort_connection(conn, state);

src/protocol/http/http.c

@@ -470,14 +470,12 @@ http_end_request(struct connection *conn, enum connection_state state,
 {
 	shutdown_connection_stream(conn);
 
-	if (state == S_OK && conn->cached) {
-		normalize_cache_entry(conn->cached, !notrunc ? conn->from : -1);
-	}
-
 	if (conn->info && !((struct http_connection_info *) conn->info)->close
 	    && (!conn->socket->ssl) /* We won't keep alive ssl connections */
 	    && (!get_opt_bool("protocol.http.bugs.post_no_keepalive")
 		|| !conn->uri->post)) {
+		if (state == S_OK && conn->cached)
+			normalize_cache_entry(conn->cached, !notrunc ? conn->from : -1);
 		set_connection_state(conn, state);
 		add_keepalive_connection(conn, HTTP_KEEPALIVE_TIMEOUT, NULL);
 	} else {

src/protocol/smb/smb.c

@@ -475,10 +475,8 @@ end_smb_connection(struct connection *conn)
 
 	if (smb_get_cache(conn)) return;
 
-	if (conn->from) {
-		normalize_cache_entry(conn->cached, conn->from);
+	if (conn->from)
 		goto bye;
-	}
 
 	/* Ensure termination by LF + NUL chars, memory for this
 	 * was reserved by smb_read_text(). */
@@ -507,7 +505,6 @@ end_smb_connection(struct connection *conn)
 
 		add_fragment(conn->cached, 0, page.source, page.length);
 		conn->from += page.length;
-		normalize_cache_entry(conn->cached, page.length);
 		done_string(&page);
 
 		mem_free_set(&conn->cached->content_type, stracpy("text/html"));