aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
Code

Fix out-of-memory crash in globhist

Browse Source 
If globhist_simple_search ran out of memory in stracpy(search_url), it
could leave gh_last_searched_title pointing to freed memory and cause
a crash in the next call.  Fix by not freeing gh_last_searched_title.
It is then possible to have gh_last_searched_title and
gh_last_searched_url pointing to strings from different searches;
but that was already possible if stracpy(search_title) failed.

Because this bug occurs only in out-of-memory situations and I don't
think ELinks in general has been properly tested in those, the fix is
perhaps not worth mentioning in NEWS and backporting to elinks-0.11.
This commit is contained in:
Kalle Olavi Niemitalo 2009-04-19 20:19:07 +03:00 committed by Kalle Olavi Niemitalo
parent 3bcca8e889
commit 5e0032551b
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/globhist/globhist.c
View File

@ -301,10 +301,7 @@ globhist_simple_search(unsigned char *search_url, unsigned char *search_title)
/* Memorize last searched url */
mem_free_set(&gh_last_searched_url, stracpy(search_url));
if (!gh_last_searched_url) {
mem_free(gh_last_searched_title);
return 0;
}
if (!gh_last_searched_url) return 0;
if (!*search_title && !*search_url) {
/* No search terms, make all entries visible. */