aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
Code

do_real_lookup: Assert that ai_addrlen <= sizeof(struct sockaddr_storage).

Browse Source
This commit is contained in:
Kalle Olavi Niemitalo 2007-02-17 22:21:56 +02:00 committed by Kalle Olavi Niemitalo
parent 447ef9d4dc
commit 3651a53e58
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/network/dns.c
View File

@ -196,7 +196,29 @@ do_real_lookup(unsigned char *name, struct sockaddr_storage **addrs, int *addrno
#ifdef CONFIG_IPV6 #ifdef CONFIG_IPV6
for (i = 0, ai_cur = ai; ai_cur; i++, ai_cur = ai_cur->ai_next) { for (i = 0, ai_cur = ai; ai_cur; i++, ai_cur = ai_cur->ai_next) {
struct sockaddr_in6 *addr = (struct sockaddr_in6 *) &(*addrs)[i]; /* Don't use struct sockaddr_in6 here: because we
* called getaddrinfo with AF_UNSPEC, the address
* might not be for IP at all. */
struct sockaddr_storage *addr = &(*addrs)[i];
/* RFC 3493 says struct sockaddr_storage is supposed
* to be "Large enough to accommodate all supported
* protocol-specific address structures." So if
* getaddrinfo supports an address that does not fit
* in struct sockaddr_storage, then it is a bug in the
* library. In this case, fail the whole lookup, to
* make the bug more likely to be noticed. */
assert(ai_cur->ai_addrlen <= sizeof(*addr));
if_assert_failed {
freeaddrinfo(ai);
if (in_thread)
free(*addrs);
else
mem_free(*addrs);
*addrs = NULL;
*addrno = 0;
return DNS_ERROR;
}
memcpy(addr, ai_cur->ai_addr, ai_cur->ai_addrlen); memcpy(addr, ai_cur->ai_addr, ai_cur->ai_addrlen);
} }