aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-06-20 00:15:31 +00:00
Code

Bug 939: Documented the fix.

Browse Source 
The fix itself is in the parent commit.
(cherry picked from commit 4c390589ea,
 rewriting the NEWS entry because the bug also occurred on Debian)
This commit is contained in:
Kalle Olavi Niemitalo 2008-01-19 10:55:11 +02:00 committed by Kalle Olavi Niemitalo
parent 8a02678bed
commit 2463c1b2f8
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -320,6 +320,7 @@ To be released as 0.11.4.
* bug 712: GnuTLS works on https://www-s.uiuc.edu/[]
* fix active and passive FTP over IPv6
* bug 938: elinks -remote no longer needs a controlling tty
* bug 939: fix FSP directory listing (some compiler options left it empty)
* bug 978: Python's webbrowser.open_new_tab(URL) works since now
* minor bug 54, Debian bug 338402: don't force the terminal to 8 bits
with no parity, and don't disable XON/XOFF flow control either

9
src/protocol/fsp/fsp.c
View File

@ -171,6 +171,13 @@ display_entry(const FSP_RDENTRY *fentry, const unsigned char dircolor[])
static void
sort_and_display_entries(FSP_DIR *dir, const unsigned char dircolor[])
{
/* fsp_readdir_native in fsplib 0.9 and earlier requires
* the third parameter to point to a non-null pointer
* even though it does not dereference that pointer
* and overwrites it with another one anyway.
* http://sourceforge.net/tracker/index.php?func=detail&aid=1875210&group_id=93841&atid=605738
* Work around the bug by using non-null &tmp.
* Nothing will actually read or write tmp. */
FSP_RDENTRY fentry, tmp, *table = NULL;
FSP_RDENTRY *fresult = &tmp;
int size = 0;
@ -229,6 +236,8 @@ fsp_directory(FSP_SESSION *ses, struct uri *uri)
if (get_opt_bool("protocol.fsp.sort")) {
sort_and_display_entries(dir, dircolor);
} else {
/* &tmp works around a bug in fsplib 0.9 or earlier.
* See sort_and_display_entries for details. */
FSP_RDENTRY fentry, tmp;
FSP_RDENTRY *fresult = &tmp;