aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
Code

Bug 908, activate_link: Set fs->state before the fs pointer becomes invalid.

Browse Source
This commit is contained in:
Kalle Olavi Niemitalo 2006-12-23 02:11:01 +02:00 committed by Kalle Olavi Niemitalo
parent cde14dcd18
commit 15dce57bc9
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/viewer/text/link.c
View File

@ -1019,6 +1019,13 @@ activate_link(struct session *ses, struct document_view *doc_view,
return FRAME_EVENT_REFRESH; return FRAME_EVENT_REFRESH;
} }
/* @link_fc->type must be FC_RADIO, then. First turn
* this one on, and then turn off all the other radio
* buttons in the group. Do it in this order because
* further @find_form_state calls may reallocate
* @doc_view->vs->form_info[] and thereby make the @fs
* pointer invalid. */
fs->state = 1;
foreach (form, doc_view->document->forms) { foreach (form, doc_view->document->forms) {
struct form_control *fc; struct form_control *fc;
@ -1027,7 +1034,8 @@ activate_link(struct session *ses, struct document_view *doc_view,
foreach (fc, form->items) { foreach (fc, form->items) {
if (fc->type == FC_RADIO if (fc->type == FC_RADIO
&& !xstrcmp(fc->name, link_fc->name)) { && !xstrcmp(fc->name, link_fc->name)
&& fc != link_fc) {
struct form_state *frm_st; struct form_state *frm_st;
frm_st = find_form_state(doc_view, fc); frm_st = find_form_state(doc_view, fc);
@ -1035,7 +1043,6 @@ activate_link(struct session *ses, struct document_view *doc_view,
} }
} }
} }
fs->state = 1;
break; break;