aniani/elinks
1
0
Fork 0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
Code

Prefer S_I?USR and S_IRWXU over obsolete S_IREAD, S_IWRITE, S_IEXEC.

Browse Source
This commit is contained in:
Laurent MONIN 2006-01-10 23:40:39 +01:00 committed by Laurent MONIN
parent 88de36b8d2
commit 151bcbd3a2
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/protocol/bittorrent/piececache.c
View File

@ -657,14 +657,14 @@ open_bittorrent_file(struct bittorrent_meta *meta, struct bittorrent_file *file,
if (!name) return -1; if (!name) return -1;
fd = open(name, flags, S_IREAD | S_IWRITE); fd = open(name, flags, S_IRUSR | S_IWUSR);
if (fd == -1) { if (fd == -1) {
/* 99% of the time the file will already exist so special case /* 99% of the time the file will already exist so special case
* the directory and file creation. */ * the directory and file creation. */
if (errno == ENOENT if (errno == ENOENT
&& trans == BITTORRENT_WRITE && trans == BITTORRENT_WRITE
&& create_bittorrent_path(name) == BITTORRENT_STATE_OK) && create_bittorrent_path(name) == BITTORRENT_STATE_OK)
fd = open(name, flags | O_CREAT, S_IREAD | S_IWRITE); fd = open(name, flags | O_CREAT, S_IRUSR | S_IWUSR);
} }
mem_free(name); mem_free(name);

2
src/protocol/file/cgi.c
View File

@ -299,7 +299,7 @@ execute_cgi(struct connection *conn)
scriptlen = strlen(script); scriptlen = strlen(script);
if (stat(script, &buf) || !(S_ISREG(buf.st_mode)) if (stat(script, &buf) || !(S_ISREG(buf.st_mode))
|| !(buf.st_mode & S_IEXEC)) { || !(buf.st_mode & S_IXUSR)) {
mem_free(script); mem_free(script);
return 1; return 1;
} }

2
src/util/file.c
View File

@ -607,7 +607,7 @@ mkalldirs(const unsigned char *path)
p[pos] = 0; p[pos] = 0;
ret = mkdir(p, S_IREAD | S_IWRITE | S_IEXEC); ret = mkdir(p, S_IRWXU);
p[pos] = separator; p[pos] = separator;