🚸 Show sub popup even if they're already subbed

display/handlers.go

@@ -237,7 +237,7 @@ func handleURL(t *tab, u string, numRedirects int) (string, bool) {
 		t.mode = tabModeDone
 
 		go func(p *structs.Page) {
-			if b && t.hasContent() && !subscriptions.IsSubscribed(s) && viper.GetBool("subscriptions.popup") {
+			if b && t.hasContent() && viper.GetBool("subscriptions.popup") {
 				// The current page might be an untracked feed, and the user wants
 				// to be notified in such cases.
 

subscriptions/subscriptions.go

@@ -22,9 +22,6 @@ import (
 	"github.com/spf13/viper"
 )
 
-// TODO: Test for deadlocks and whether there should be more
-// goroutines for file writing or other things.
-
 var (
 	ErrSaving     = errors.New("couldn't save JSON to disk")
 	ErrNotSuccess = errors.New("status 20 not returned")
@@ -277,8 +274,6 @@ func updatePage(url string) error {
 // updateAll updates all subscriptions using workers.
 // It only returns once all the workers are done.
 func updateAll() {
-	// TODO: Is two goroutines the right amount?
-
 	worker := func(jobs <-chan [2]string, wg *sync.WaitGroup) {
 		// Each job is: [2]string{<type>, "url"}
 		// where <type> is "feed" or "page"