aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2024-11-03 02:37:23 -05:00
Code
ede504caaf
amfora/NOTES.md

25 lines
1.4 KiB
Markdown
Raw Normal View History

🎉 Initial commit, full featured
2020-06-18 16:54:48 -04:00
# Notes
🔀 Refactor to use tab struct Squashed commit of the following: commit 72f36afc9ea51b1d4fc6e24895bbc32b8b8cd872 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 16:15:45 2020 -0400 🚧 Scroll is applied correctly when navigating around commit 4b8982723f60294977f5e9d213fa3c8a51362356 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 15:34:45 2020 -0400 🚧 Fix bottomBar code Make sure it always resets to a selected link if one was selected before commit be09ffcf913662983a0362431d8e4765d06b4187 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 20:30:54 2020 -0400 🚧 Switch to using tab pointers instead of ints Almost finished overall work. commit ef8ab3da39eb2681f439337354b6b8f9fed74f15 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 12:10:50 2020 -0400 🚧 Fixed some bugs, major ones remain commit d3d47a344d54a9aac66acddd6ea9ca893ecc30df Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 20:58:46 2020 -0400 🚧 Everything uses tab struct, no compile errors, untested commit 44bf54c12f379524fe95073ca4eb1f3fb2c7195a Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 13:24:49 2020 -0400 🚧 Initial work on tab struct
2020-07-07 21:13:45 -04:00
## Issues
🚧 Downloading all content seems to work
2020-07-10 14:37:18 -04:00
- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL
🔀 Refactor to use tab struct Squashed commit of the following: commit 72f36afc9ea51b1d4fc6e24895bbc32b8b8cd872 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 16:15:45 2020 -0400 🚧 Scroll is applied correctly when navigating around commit 4b8982723f60294977f5e9d213fa3c8a51362356 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 15:34:45 2020 -0400 🚧 Fix bottomBar code Make sure it always resets to a selected link if one was selected before commit be09ffcf913662983a0362431d8e4765d06b4187 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 20:30:54 2020 -0400 🚧 Switch to using tab pointers instead of ints Almost finished overall work. commit ef8ab3da39eb2681f439337354b6b8f9fed74f15 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 12:10:50 2020 -0400 🚧 Fixed some bugs, major ones remain commit d3d47a344d54a9aac66acddd6ea9ca893ecc30df Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 20:58:46 2020 -0400 🚧 Everything uses tab struct, no compile errors, untested commit 44bf54c12f379524fe95073ca4eb1f3fb2c7195a Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 13:24:49 2020 -0400 🚧 Initial work on tab struct
2020-07-07 21:13:45 -04:00
- Can't go back or do other things while page is loading - need a way to stop `handleURL`
🐛 Able to leave help page This was a regression, the bug was not present in v1.3.0. This could be due to the cview update?
2020-07-28 17:33:18 -04:00
- Pressing Escape in the bottom bar jumps back to the top of the page
🐛 Allow open new tab while loading
2020-07-28 17:16:57 -04:00
## Regressions
🐛 Fix not being able to interact with page after modal This was a regression, the bug was not present in v1.3.0. This could be due to the cview update?
2020-07-28 18:09:36 -04:00
- Switching to another tab scrolls page back to the top - same with closing
🎉 Initial commit, full featured
2020-06-18 16:54:48 -04:00
🐛 Hardwrap help table cells
2020-07-01 20:08:07 -04:00
## Upstream Bugs
🐛 Use recover() on WordWrap - fixes #20
2020-06-29 12:54:36 -04:00
- Wrapping messes up on brackets
🎉 Initial commit, full featured
2020-06-18 16:54:48 -04:00
- Filed [issue 23](https://gitlab.com/tslocum/cview/-/issues/23)
🐛 Use recover() on WordWrap - fixes #20
2020-06-29 12:54:36 -04:00
- Wrapping panics on strings with brackets and Asian characters
- Filed cview [issue 27](https://gitlab.com/tslocum/cview/-/issues/27)
- The panicking was reported and fixed in Amfora [issue 20](https://github.com/makeworld-the-better-one/amfora/issues/20), but the lines are now just not wrapped
🎉 Initial commit, full featured
2020-06-18 16:54:48 -04:00
- Text background not reset on ANSI pages
- Filed [issue 25](https://gitlab.com/tslocum/cview/-/issues/25)
✨ Give Error modals titles
2020-06-19 14:05:05 -04:00
- Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
✨ Add TOFU continue option - fixes #6
2020-06-21 20:37:27 -04:00
- Filed [issue 26](https://gitlab.com/tslocum/cview/-/issues/26)
✨ Add version and help commands - fixes #14
2020-06-23 20:23:28 -04:00
- Add some bold back into modal text after this is fixed
🐛 Add no-color UI elements - fixes #16
2020-06-24 11:37:32 -04:00
- Bookmark keys aren't deleted, just set to `""`
🐛 Hardwrap help table cells
2020-07-01 20:08:07 -04:00
- Waiting on [this viper PR](https://github.com/spf13/viper/pull/519) to be merged
- Help table cells aren't dynamically wrapped
- Filed [issue 29](https://gitlab.com/tslocum/cview/-/issues/29)
Copy Permalink