amfora/NOTES.md

# Notes

## Issues
- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL

## Upstream Bugs
- Bookmark keys aren't deleted, just set to `""`
  - Waiting on [this viper PR](https://github.com/spf13/viper/pull/519) to be merged
- Help table cells aren't dynamically wrapped
  - Filed [issue 29](https://gitlab.com/tslocum/cview/-/issues/29)
🎉 Initial commit, full featured 2020-06-18 20:54:48 +00:00			`# Notes`

🔀 Refactor to use tab struct Squashed commit of the following: commit 72f36afc9ea51b1d4fc6e24895bbc32b8b8cd872 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 16:15:45 2020 -0400 🚧 Scroll is applied correctly when navigating around commit 4b8982723f60294977f5e9d213fa3c8a51362356 Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 15:34:45 2020 -0400 🚧 Fix bottomBar code Make sure it always resets to a selected link if one was selected before commit be09ffcf913662983a0362431d8e4765d06b4187 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 20:30:54 2020 -0400 🚧 Switch to using tab pointers instead of ints Almost finished overall work. commit ef8ab3da39eb2681f439337354b6b8f9fed74f15 Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 12:10:50 2020 -0400 🚧 Fixed some bugs, major ones remain commit d3d47a344d54a9aac66acddd6ea9ca893ecc30df Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 20:58:46 2020 -0400 🚧 Everything uses tab struct, no compile errors, untested commit 44bf54c12f379524fe95073ca4eb1f3fb2c7195a Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 13:24:49 2020 -0400 🚧 Initial work on tab struct 2020-07-08 01:13:45 +00:00			`## Issues`
🚧 Downloading all content seems to work 2020-07-10 18:37:18 +00:00			`- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL`
🔖 Release v1.4.0 2020-07-28 23:33:00 +00:00
🐛 Hardwrap help table cells 2020-07-02 00:08:07 +00:00			`## Upstream Bugs`
🐛 Add no-color UI elements - fixes #16 2020-06-24 15:37:32 +00:00			- Bookmark keys aren't deleted, just set to `""`
🐛 Hardwrap help table cells 2020-07-02 00:08:07 +00:00			`- Waiting on [this viper PR](https://github.com/spf13/viper/pull/519) to be merged`
			`- Help table cells aren't dynamically wrapped`
🚧 Starting on cview update [compile failing] 2020-10-11 20:07:31 +00:00			`- Filed [issue 29](https://gitlab.com/tslocum/cview/-/issues/29)`