Atlas48/grungnet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Detect isSafari to disable antialias on dice

Browse Source
This commit is contained in:
nthouliss 2022-04-27 13:06:19 +10:00
parent 32edd63755
commit fb011ff31a
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/dice/DiceInteraction.tsx
View File

@ -20,6 +20,7 @@ import usePreventTouch from "../../hooks/usePreventTouch";
import ErrorBanner from "../banner/ErrorBanner"; import ErrorBanner from "../banner/ErrorBanner";
import { AbstractMesh } from "@babylonjs/core/Meshes/abstractMesh"; import { AbstractMesh } from "@babylonjs/core/Meshes/abstractMesh";
import { isSafari } from "../../helpers/shared";
const diceThrowSpeed = 2; const diceThrowSpeed = 2;
@ -57,15 +58,14 @@ function DiceInteraction({
} }
try { try {
const engine = new Engine(canvas, true, { // iOS 15.4 introduced a bug - animation trails ar visible on dice in Safari. Have to disable antialiasing on Safari
// https://forum.babylonjs.com/t/render-loop-issue-on-iphone-11-unwanted-animation-trails/29742
const engine = new Engine(canvas, !isSafari, {
preserveDrawingBuffer: true, preserveDrawingBuffer: true,
stencil: true, stencil: true,
// Prevent XR from loading as Safari 15 crashes with this enabled // Prevent XR from loading as Safari 15 crashes with this enabled
// TODO: Remove when https://github.com/BabylonJS/Babylon.js/pull/11121/files released // TODO: Remove when https://github.com/BabylonJS/Babylon.js/pull/11121/files released
xrCompatible: false, xrCompatible: false
// iOS 15.4.1 introduced a bug - animation trails on dice
// https://forum.babylonjs.com/t/render-loop-issue-on-iphone-11-unwanted-animation-trails/29742
antialias: false
}); });
const scene = new Scene(engine); const scene = new Scene(engine);
scene.clearColor = new Color4(0, 0, 0, 0); scene.clearColor = new Color4(0, 0, 0, 0);

2
src/helpers/shared.ts
View File

@ -86,6 +86,8 @@ export function groupBy(array: Record<PropertyKey, any>[], key: string) {
export const isMacLike = /(Mac|iPhone|iPod|iPad)/i.test(navigator.platform); export const isMacLike = /(Mac|iPhone|iPod|iPad)/i.test(navigator.platform);
export const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
export function shuffle<Type>(array: Type[]) { export function shuffle<Type>(array: Type[]) {
let temp = [...array]; let temp = [...array];
var currentIndex = temp.length, var currentIndex = temp.length,