Ashish/yt-dlp
1
1
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-12-23 10:37:18 -05:00
Code Issues 7 Projects Releases Wiki Activity

[extractor/youtube] Fix comment loop detection for pinned comments (#6714)

Browse Source 
Pinned comments may repeat a second time - this is expected.

Fixes https://github.com/yt-dlp/yt-dlp/issues/6712

Authored by: coletdjnz
This commit is contained in:
coletdjnz 2023-04-06 19:44:22 +12:00 committed by GitHub
parent 68be95bd0c
commit 141a8dff98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
yt_dlp/extractor/youtube.py
View File

@ -3316,9 +3316,17 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
comment = self._extract_comment(comment_renderer, parent)
if not comment:
continue
is_pinned = bool(traverse_obj(comment_renderer, 'pinnedCommentBadge'))
comment_id = comment['id']
if is_pinned:
tracker['pinned_comment_ids'].add(comment_id)
# Sometimes YouTube may break and give us infinite looping comments.
# See: https://github.com/yt-dlp/yt-dlp/issues/6290
if comment['id'] in tracker['seen_comment_ids']:
if comment_id in tracker['seen_comment_ids']:
if comment_id in tracker['pinned_comment_ids'] and not is_pinned:
# Pinned comments may appear a second time in newest first sort
# See: https://github.com/yt-dlp/yt-dlp/issues/6712
continue
self.report_warning('Detected YouTube comments looping. Stopping comment extraction as we probably cannot get any more.')
yield
else:
@ -3348,7 +3356,9 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
current_page_thread=0,
total_parent_comments=0,
total_reply_comments=0,
seen_comment_ids=set())
seen_comment_ids=set(),
pinned_comment_ids=set()
)
# TODO: Deprecated
# YouTube comments have a max depth of 2