From 6a6efba27ac37e8b202040363296151c839cbcea Mon Sep 17 00:00:00 2001 From: Patrick Marsceill Date: Thu, 25 Oct 2018 11:17:10 -0400 Subject: [PATCH] fix linting / rules --- .stylelintrc.json | 3 +++ _sass/labels.scss | 2 +- _sass/layout.scss | 2 ++ _sass/navigation.scss | 3 +-- _sass/support/mixins/_layout.scss | 10 ++++++---- 5 files changed, 13 insertions(+), 7 deletions(-) diff --git a/.stylelintrc.json b/.stylelintrc.json index 19028f9..a624c10 100644 --- a/.stylelintrc.json +++ b/.stylelintrc.json @@ -1,4 +1,7 @@ { + "ignoreFiles" : [ + "assets/css/just-the-docs.scss" + ], "extends": [ "stylelint-config-primer" ] diff --git a/_sass/labels.scss b/_sass/labels.scss index a15d40c..23cc510 100644 --- a/_sass/labels.scss +++ b/_sass/labels.scss @@ -12,9 +12,9 @@ margin-right: $sp-1; margin-left: $sp-1; color: $white; + text-transform: uppercase; vertical-align: middle; background-color: $blue-100; - text-transform: uppercase; @include fs-2; } diff --git a/_sass/layout.scss b/_sass/layout.scss index 9bb6889..e3c93e4 100644 --- a/_sass/layout.scss +++ b/_sass/layout.scss @@ -115,6 +115,7 @@ } } +// stylelint-disable selector-no-type body { position: relative; padding-bottom: $sp-10; @@ -124,6 +125,7 @@ body { padding-bottom: 0; } } +// stylelint-enable selector-no-type .site-footer { position: absolute; diff --git a/_sass/navigation.scss b/_sass/navigation.scss index e6f1d22..802a6ed 100644 --- a/_sass/navigation.scss +++ b/_sass/navigation.scss @@ -11,9 +11,9 @@ position: absolute; top: 0; right: 0; + z-index: 101; height: 60px; padding-top: $sp-4; - z-index: 101; box-shadow: inset 0 -1px 0 $border-color; } } @@ -89,7 +89,6 @@ } } - .navigation-list-toggle { position: absolute; right: $sp-4; diff --git a/_sass/support/mixins/_layout.scss b/_sass/support/mixins/_layout.scss index 52b9e3c..7e7967e 100644 --- a/_sass/support/mixins/_layout.scss +++ b/_sass/support/mixins/_layout.scss @@ -15,20 +15,22 @@ @media (min-width: rem($value)) { @content; } - } @else { + } + + @else { @warn "No value could be retrieved from `#{$media-query}`. " - + "Please make sure it is defined in `$media-queries` map."; + + "Please make sure it is defined in `$media-queries` map."; } } // Responsive container @mixin container { - padding-left: $gutter-spacing-sm; padding-right: $gutter-spacing-sm; + padding-left: $gutter-spacing-sm; @include mq(md) { - padding-left: $gutter-spacing; padding-right: $gutter-spacing; + padding-left: $gutter-spacing; } }