From 11d2d1faaf9cd0e2b6796c17390137dedcdc90bb Mon Sep 17 00:00:00 2001 From: sin Date: Sat, 30 Jun 2018 17:31:53 +0100 Subject: [PATCH] Fix segfault in killall5 without -o Original patch by Platon Ryzhikov --- killall5.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/killall5.c b/killall5.c index 14790b9..f3541f5 100644 --- a/killall5.c +++ b/killall5.c @@ -73,10 +73,12 @@ main(int argc, char *argv[]) SLIST_INIT(&omitpid_head); - for (p = strtok(arg, ","); p; p = strtok(NULL, ",")) { - pe = emalloc(sizeof(*pe)); - pe->pid = estrtol(p, 10); - SLIST_INSERT_HEAD(&omitpid_head, pe, entry); + if (oflag) { + for (p = strtok(arg, ","); p; p = strtok(NULL, ",")) { + pe = emalloc(sizeof(*pe)); + pe->pid = estrtol(p, 10); + SLIST_INSERT_HEAD(&omitpid_head, pe, entry); + } } if (sig != SIGSTOP && sig != SIGCONT)