midfavila/sbase
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

cp: Default to -P when -R is specified

Browse Source 
POSIX only specifies the -H, -L, and -P options for use with -R, and
the default is left to the implementation. Without -R, symlinks must
be followed.

Most implementations use -P as the default with -R, which makes sense
to me as default behavior (the source and destination trees are the same).

Since we use the same code for -R and without it, and we allow -H, -L,
and -P without -R, set the default based on the presence of -R. Without
it, use -L as before, as required by POSIX, and with it, use -P to match
the behavior of other implementations.
This commit is contained in:
Michael Forney 2019-12-21 21:08:36 -08:00
parent 61f5d4887a
commit f4b9b966cf
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cp.1
View File

@ -48,9 +48,12 @@ Dereference
if it is a symbolic link.
.It Fl L
Dereference all symbolic links.
This is the default.
This is the default without
.Fl R .
.It Fl P
Preserve symbolic links.
This is the default with
.Fl R .
.It Fl R
Traverse directories recursively. If this flag is not specified, directories
are not copied.

3
cp.c
View File

@ -45,6 +45,9 @@ main(int argc, char *argv[])
if (argc < 2)
usage();
if (!cp_follow)
cp_follow = cp_rflag ? 'P' : 'L';
if (argc > 2) {
if (stat(argv[argc - 1], &st) < 0)
eprintf("stat %s:", argv[argc - 1]);

2
libutil/cp.c
View File

@ -20,7 +20,7 @@ int cp_pflag = 0;
int cp_rflag = 0;
int cp_vflag = 0;
int cp_status = 0;
int cp_follow = 'L';
int cp_follow;
int
cp(const char *s1, const char *s2, int depth)