From cf3688729e7ddc5c022c596606ed75612fa91a52 Mon Sep 17 00:00:00 2001 From: Shelikhoo Date: Mon, 28 Jun 2021 16:59:50 +0100 Subject: [PATCH] show explicit error to users with a incorrect fake DNS setting. --- app/dns/fakedns/fake.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/dns/fakedns/fake.go b/app/dns/fakedns/fake.go index f7b85cfae..5aa4c2482 100644 --- a/app/dns/fakedns/fake.go +++ b/app/dns/fakedns/fake.go @@ -46,7 +46,7 @@ func (fkdns *Holder) Start() error { if fkdns.config != nil && fkdns.config.IpPool != "" && fkdns.config.LruSize != 0 { return fkdns.initializeFromConfig() } - return nil + return newError("invalid fakeDNS setting") } func (fkdns *Holder) Close() error { @@ -191,6 +191,8 @@ func (h *HolderMulti) Start() error { if err := v.Start(); err != nil { return newError("Cannot start all fake dns pools").Base(err) } + } else { + return newError("invalid fakeDNS setting") } } return nil