diff --git a/proxy/shadowsocks/protocol_test.go b/proxy/shadowsocks/protocol_test.go index e7023a6a9..fbc06be62 100644 --- a/proxy/shadowsocks/protocol_test.go +++ b/proxy/shadowsocks/protocol_test.go @@ -9,6 +9,7 @@ import ( . "github.com/v2ray/v2ray-core/proxy/shadowsocks" v2testing "github.com/v2ray/v2ray-core/testing" "github.com/v2ray/v2ray-core/testing/assert" + "github.com/v2ray/v2ray-core/transport" ) func TestNormalRequestParsing(t *testing.T) { @@ -24,6 +25,54 @@ func TestNormalRequestParsing(t *testing.T) { assert.Bool(request.OTA).IsFalse() } +func TestEmptyPayload(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear() + _, err := ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + +func TestSingleBytePayload(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear().AppendBytes(1) + _, err := ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + +func TestWrongAddressType(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear().AppendBytes(5) + _, err := ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + +func TestInsufficientAddressRequest(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear().AppendBytes(1, 1) + _, err := ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) + + buffer = alloc.NewSmallBuffer().Clear().AppendBytes(4, 1) + _, err = ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) + + buffer = alloc.NewSmallBuffer().Clear().AppendBytes(3, 255, 1) + _, err = ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + +func TestInsufficientPortRequest(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear().AppendBytes(1, 1, 2, 3, 4, 5) + _, err := ReadRequest(buffer, nil, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + func TestOTARequest(t *testing.T) { v2testing.Current(t) @@ -39,6 +88,19 @@ func TestOTARequest(t *testing.T) { assert.Bool(request.OTA).IsTrue() } +func TestInvalidOTARequest(t *testing.T) { + v2testing.Current(t) + + buffer := alloc.NewSmallBuffer().Clear() + buffer.AppendBytes(0x13, 13, 119, 119, 119, 46, 118, 50, 114, 97, 121, 46, 99, 111, 109, 0, 0, 239, 115, 52, 212, 178, 172, 26, 6, 168, 1) + + auth := NewAuthenticator(HeaderKeyGenerator( + []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 1, 2, 3, 4, 5}, + []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 1, 2, 3, 4, 5})) + _, err := ReadRequest(buffer, auth, false) + assert.Error(err).Equals(transport.ErrorCorruptedPacket) +} + func TestUDPRequestParsing(t *testing.T) { v2testing.Current(t)