From a7f40da07a8f574bbf5c8515ad98f1fe31ba17e1 Mon Sep 17 00:00:00 2001 From: v2ray Date: Tue, 26 Apr 2016 00:46:04 +0200 Subject: [PATCH] Fix unused variables --- common/protocol/raw/client.go | 4 +++- common/uuid/uuid_test.go | 2 +- proxy/internal/config/config_cache_test.go | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/common/protocol/raw/client.go b/common/protocol/raw/client.go index 5dd4c250e..77e242c51 100644 --- a/common/protocol/raw/client.go +++ b/common/protocol/raw/client.go @@ -129,7 +129,9 @@ func (this *ClientSession) DecodeResponseHeader(reader io.Reader) (*protocol.Res } data := buffer.Value[:dataLen] command, err := UnmarshalCommand(cmdId, data) - header.Command = command + if err == nil { + header.Command = command + } } return header, nil diff --git a/common/uuid/uuid_test.go b/common/uuid/uuid_test.go index 55b78e263..f38d1743c 100644 --- a/common/uuid/uuid_test.go +++ b/common/uuid/uuid_test.go @@ -18,7 +18,7 @@ func TestParseBytes(t *testing.T) { assert.Error(err).IsNil() assert.String(uuid).Equals(str) - uuid, err = ParseBytes([]byte{1, 3, 2, 4}) + _, err = ParseBytes([]byte{1, 3, 2, 4}) assert.Error(err).Equals(ErrorInvalidID) } diff --git a/proxy/internal/config/config_cache_test.go b/proxy/internal/config/config_cache_test.go index 6123d85ad..82ad2b274 100644 --- a/proxy/internal/config/config_cache_test.go +++ b/proxy/internal/config/config_cache_test.go @@ -24,6 +24,7 @@ func TestRegisterInboundConfig(t *testing.T) { assert.Error(err).IsNil() configObj, err = CreateOutboundConfig(protocol, nil) + assert.Error(err).IsNotNil() assert.Pointer(configObj).IsNil() } @@ -44,5 +45,6 @@ func TestRegisterOutboundConfig(t *testing.T) { assert.Error(err).IsNil() configObj, err = CreateInboundConfig(protocol, nil) + assert.Error(err).IsNotNil() assert.Pointer(configObj).IsNil() }