From 21f8bfe4765af4f11529f0acdaee1ec952d1a46d Mon Sep 17 00:00:00 2001 From: Darien Raymond Date: Sat, 5 Jan 2019 19:49:21 +0100 Subject: [PATCH] move udp packet to protocol --- common/protocol/udp/packet.go | 13 +++++++++++++ common/protocol/udp/udp.go | 1 + transport/internet/kcp/listener.go | 2 +- transport/internet/udp/hub.go | 26 ++++++++++---------------- 4 files changed, 25 insertions(+), 17 deletions(-) create mode 100644 common/protocol/udp/packet.go create mode 100644 common/protocol/udp/udp.go diff --git a/common/protocol/udp/packet.go b/common/protocol/udp/packet.go new file mode 100644 index 000000000..67bcf658b --- /dev/null +++ b/common/protocol/udp/packet.go @@ -0,0 +1,13 @@ +package udp + +import ( + "v2ray.com/core/common/buf" + "v2ray.com/core/common/net" +) + +// Packet is a UDP packet together with its source and destination address. +type Packet struct { + Payload *buf.Buffer + Source net.Destination + Target net.Destination +} diff --git a/common/protocol/udp/udp.go b/common/protocol/udp/udp.go new file mode 100644 index 000000000..0213f41f0 --- /dev/null +++ b/common/protocol/udp/udp.go @@ -0,0 +1 @@ +package udp diff --git a/transport/internet/kcp/listener.go b/transport/internet/kcp/listener.go index 2416979fc..c2dba56cc 100644 --- a/transport/internet/kcp/listener.go +++ b/transport/internet/kcp/listener.go @@ -76,7 +76,7 @@ func NewListener(ctx context.Context, address net.Address, port net.Port, stream func (l *Listener) handlePackets() { receive := l.hub.Receive() for payload := range receive { - l.OnReceive(payload.Content, payload.Source) + l.OnReceive(payload.Payload, payload.Source) } } diff --git a/transport/internet/udp/hub.go b/transport/internet/udp/hub.go index 676d99d5a..d1c7992cd 100644 --- a/transport/internet/udp/hub.go +++ b/transport/internet/udp/hub.go @@ -5,16 +5,10 @@ import ( "v2ray.com/core/common/buf" "v2ray.com/core/common/net" + "v2ray.com/core/common/protocol/udp" "v2ray.com/core/transport/internet" ) -// Payload represents a single UDP payload. -type Payload struct { - Content *buf.Buffer - Source net.Destination - OriginalDestination net.Destination -} - type HubOption func(h *Hub) func HubCapacity(capacity int) HubOption { @@ -31,7 +25,7 @@ func HubReceiveOriginalDestination(r bool) HubOption { type Hub struct { conn *net.UDPConn - cache chan *Payload + cache chan *udp.Packet capacity int recvOrigDest bool } @@ -62,7 +56,7 @@ func ListenUDP(ctx context.Context, address net.Address, port net.Port, streamSe } newError("listening UDP on ", address, ":", port).WriteToLog() hub.conn = udpConn.(*net.UDPConn) - hub.cache = make(chan *Payload, hub.capacity) + hub.cache = make(chan *udp.Packet, hub.capacity) go hub.start() return hub, nil @@ -106,14 +100,14 @@ func (h *Hub) start() { continue } - payload := &Payload{ - Content: buffer, + payload := &udp.Packet{ + Payload: buffer, Source: net.UDPDestination(net.IPAddress(addr.IP), net.Port(addr.Port)), } if h.recvOrigDest && noob > 0 { - payload.OriginalDestination = RetrieveOriginalDest(oobBytes[:noob]) - if payload.OriginalDestination.IsValid() { - newError("UDP original destination: ", payload.OriginalDestination).AtDebug().WriteToLog() + payload.Target = RetrieveOriginalDest(oobBytes[:noob]) + if payload.Target.IsValid() { + newError("UDP original destination: ", payload.Target).AtDebug().WriteToLog() } else { newError("failed to read UDP original destination").WriteToLog() } @@ -123,7 +117,7 @@ func (h *Hub) start() { case c <- payload: default: buffer.Release() - payload.Content = nil + payload.Payload = nil } } @@ -134,6 +128,6 @@ func (h *Hub) Addr() net.Addr { return h.conn.LocalAddr() } -func (h *Hub) Receive() <-chan *Payload { +func (h *Hub) Receive() <-chan *udp.Packet { return h.cache }