From 0d4479a72ab615bafcbf61a22fd87c30851a0fab Mon Sep 17 00:00:00 2001 From: Loyalsoldier <10487845+Loyalsoldier@users.noreply.github.com> Date: Sat, 1 May 2021 21:44:12 +0800 Subject: [PATCH] Fix: FakeDNS prints error with empty config (#955) --- app/dns/fakedns/fake.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/dns/fakedns/fake.go b/app/dns/fakedns/fake.go index 8aa6624a2..e74ec76bd 100644 --- a/app/dns/fakedns/fake.go +++ b/app/dns/fakedns/fake.go @@ -43,7 +43,10 @@ func (*Holder) Type() interface{} { } func (fkdns *Holder) Start() error { - return fkdns.initializeFromConfig() + if fkdns.config != nil && fkdns.config.IpPool != "" && fkdns.config.LruSize != 0 { + return fkdns.initializeFromConfig() + } + return nil } func (fkdns *Holder) Close() error { @@ -184,9 +187,10 @@ func (h *HolderMulti) Type() interface{} { func (h *HolderMulti) Start() error { for _, v := range h.holders { - err := v.Start() - if err != nil { - return newError("Cannot start all fake dns pools").Base(err) + if v.config != nil && v.config.IpPool != "" && v.config.LruSize != 0 { + if err := v.Start(); err != nil { + return newError("Cannot start all fake dns pools").Base(err) + } } } return nil