From d77fd2e69e7ac850aba8aa4893d3c4f65a1a54d2 Mon Sep 17 00:00:00 2001 From: Benau Date: Thu, 18 Jul 2019 15:52:03 +0800 Subject: [PATCH] Revert "Replace xml.dom.minidom.parse which is known to be vulnerable to XML attacks. (#3933)" This reverts commit 74f227590e115b157fa7a5b38594154e1debe79d. Expat doesn't like ./data/achievements.xml ! Error= ( ("name 'defusedxml' is not defined",) ) --- data/po/extract_strings_from_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/po/extract_strings_from_XML.py b/data/po/extract_strings_from_XML.py index d27f25b7f..19b8acf8f 100755 --- a/data/po/extract_strings_from_XML.py +++ b/data/po/extract_strings_from_XML.py @@ -86,7 +86,7 @@ for file in filenames: isAchievements = True try: - doc = defusedxml.minidom.parse(file) + doc = xml.dom.minidom.parse(file) except Exception as ex: print "============================================" print "/!\\ Expat doesn't like ", file, "! Error=", type(ex), " (", ex.args, ")"