From 279e551371266faf8e227f599ef669703918afb9 Mon Sep 17 00:00:00 2001
From: auria <auria@178a84e3-b1eb-0310-8ba1-8eac791a3b58>
Date: Thu, 6 Jan 2011 21:11:32 +0000
Subject: [PATCH] Remove outdated FIXMES + fix possible crash if section is
 missing in XML file

git-svn-id: svn+ssh://svn.code.sf.net/p/supertuxkart/code/main/trunk@7316 178a84e3-b1eb-0310-8ba1-8eac791a3b58
---
 src/graphics/particle_emitter.cpp |  4 ---
 src/graphics/particle_kind.cpp    | 46 +++++++++++++++++++++----------
 2 files changed, 32 insertions(+), 18 deletions(-)

diff --git a/src/graphics/particle_emitter.cpp b/src/graphics/particle_emitter.cpp
index 91a509c27..b45126a17 100644
--- a/src/graphics/particle_emitter.cpp
+++ b/src/graphics/particle_emitter.cpp
@@ -66,8 +66,6 @@ ParticleEmitter::ParticleEmitter(ParticleKind* type, core::vector3df position,
     {
         case EMITTER_POINT:
         {
-            // FIXME: does the maxAngle param work at all??
-            // FIXME: the min and max color params don't appear to work
             m_emitter = m_node->createPointEmitter(core::vector3df(m_particle_type->getVelocityX(),
                                                                    m_particle_type->getVelocityY(),
                                                                    m_particle_type->getVelocityZ()),   // velocity in m/ms
@@ -81,8 +79,6 @@ ParticleEmitter::ParticleEmitter(ParticleKind* type, core::vector3df position,
             
         case EMITTER_BOX:
         {
-            // FIXME: does the maxAngle param work at all??
-            // FIXME: the min and max color params don't appear to work
             const float box_size_x = type->getBoxSizeX()/2.0f;
             const float box_size_y = type->getBoxSizeY()/2.0f;
             const float box_size_z = type->getBoxSizeZ()/2.0f;
diff --git a/src/graphics/particle_kind.cpp b/src/graphics/particle_kind.cpp
index bc91164dd..a0aa48b7b 100644
--- a/src/graphics/particle_kind.cpp
+++ b/src/graphics/particle_kind.cpp
@@ -62,7 +62,7 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     if (xml->getName() != "particles")
     {
         delete xml;
-        throw std::runtime_error("[ParticleKind] No <particles> main node in smoke.xml");
+        throw std::runtime_error("[ParticleKind] No <particles> main node in " + file);
     }
     
     // ------------------------------------------------------------------------
@@ -105,6 +105,12 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     // ------------------------------------------------------------------------
     
     const XMLNode* material = xml->getNode("material");
+    if (material == NULL)
+    {
+        delete xml;
+        throw std::runtime_error("[ParticleKind] No <material> node in " + file);
+    }
+    
     std::string materialFile;
     material->get("file", &materialFile);
     
@@ -123,8 +129,11 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     // ------------------------------------------------------------------------
     
     const XMLNode* rate = xml->getNode("rate");
-    rate->get("min", &m_min_rate);
-    rate->get("max", &m_max_rate);
+    if (rate != NULL)
+    {
+        rate->get("min", &m_min_rate);
+        rate->get("max", &m_max_rate);
+    }
     
     //std::cout << "m_min_rate = " << m_min_rate << "\n";
     //std::cout << "m_max_rate = " << m_max_rate << "\n";
@@ -132,8 +141,11 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     // ------------------------------------------------------------------------
     
     const XMLNode* lifetime = xml->getNode("lifetime");
-    lifetime->get("min", &m_lifetime_min);
-    lifetime->get("max", &m_lifetime_max);
+    if (lifetime != NULL)
+    {
+        lifetime->get("min", &m_lifetime_min);
+        lifetime->get("max", &m_lifetime_max);
+    }
     
     //std::cout << "m_lifetime_min = " << m_lifetime_min << "\n";
     //std::cout << "m_lifetime_max = " << m_lifetime_max << "\n";
@@ -141,9 +153,11 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     // ------------------------------------------------------------------------
     
     const XMLNode* size = xml->getNode("size");
-    //size->get("default", &m_particle_size);
-    size->get("min", &m_min_size);
-    size->get("max", &m_max_size);
+    if (size != NULL)
+    {
+        size->get("min", &m_min_size);
+        size->get("max", &m_max_size);
+    }
     
     //std::cout << "m_particle_size = " << m_particle_size << "\n";
     //std::cout << "m_min_size = " << m_min_size << "\n";
@@ -152,16 +166,20 @@ ParticleKind::ParticleKind(const std::string file) : m_min_start_color(255,255,2
     // ------------------------------------------------------------------------
     
     const XMLNode* color = xml->getNode("color");
-    video::SColor minColor;
-    video::SColor maxColor;
-    color->get("min", &m_min_start_color);
-    color->get("max", &m_max_start_color);
+    if (color != NULL)
+    {
+        color->get("min", &m_min_start_color);
+        color->get("max", &m_max_start_color);
+    }
     
     // ------------------------------------------------------------------------
     
     const XMLNode* fadeout = xml->getNode("fadeout");
-    fadeout->get("time", &m_fadeout_time);
-    
+    if (fadeout != NULL)
+    {
+        fadeout->get("time", &m_fadeout_time);
+    }
+        
     //std::cout << "m_fadeout_time = " << m_fadeout_time << "\n";
     
     // ------------------------------------------------------------------------