From 6d23d53d1fb8a271d765b297ee56cb075f488072 Mon Sep 17 00:00:00 2001 From: "Ali H. Fardan" Date: Sun, 11 Sep 2016 13:33:35 +0300 Subject: [PATCH 1/2] fixed cpu_perc() stupidity && added some useful comment for drkh5h --- slstatus.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/slstatus.c b/slstatus.c index 6c25f3f..3391e67 100644 --- a/slstatus.c +++ b/slstatus.c @@ -37,6 +37,8 @@ struct arg { const char *args; }; +static unsigned short int delay; + static char *smprintf(const char *, ...); static char *battery_perc(const char *); static char *cpu_perc(void); @@ -126,7 +128,7 @@ battery_perc(const char *battery) static char * cpu_perc(void) -{ /* FIXME: ugly function, would be better without sleep(), see below */ +{ int perc; long double a[4], b[4]; FILE *fp = fopen("/proc/stat","r"); @@ -139,7 +141,8 @@ cpu_perc(void) fscanf(fp, "%*s %Lf %Lf %Lf %Lf", &a[0], &a[1], &a[2], &a[3]); fclose(fp); - sleep(1); + delay = (UPDATE_INTERVAL - (UPDATE_INTERVAL - 1)); + sleep(delay); fp = fopen("/proc/stat","r"); if (fp == NULL) { @@ -470,7 +473,7 @@ uid(void) static char * vol_perc(const char *snd_card) -{ /* thanks to botika for this function */ +{ /* FIX THIS SHIT! */ long int vol, max, min; snd_mixer_t *handle; snd_mixer_elem_t *elem; @@ -601,7 +604,12 @@ main(void) } XStoreName(dpy, DefaultRootWindow(dpy), status_string); XSync(dpy, False); - sleep(UPDATE_INTERVAL - 1); /* FIXME: ugly cpu function which uses 1 second */ + /* + * subtract delay time spend in function + * calls from the actual global delay time + */ + sleep(UPDATE_INTERVAL - delay); + delay = 0; } XCloseDisplay(dpy); From 6cb5af2bd733cd73da704714c248b6ad2cd2ec09 Mon Sep 17 00:00:00 2001 From: "Ali H. Fardan" Date: Sun, 11 Sep 2016 13:57:04 +0300 Subject: [PATCH 2/2] fixed (hopefully) the vol_perc() function --- slstatus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/slstatus.c b/slstatus.c index 3391e67..0906b9d 100644 --- a/slstatus.c +++ b/slstatus.c @@ -480,17 +480,17 @@ vol_perc(const char *snd_card) snd_mixer_selem_id_t *s_elem; snd_mixer_open(&handle, 0); - snd_mixer_attach(handle, "default"); + snd_mixer_attach(handle, snd_card); snd_mixer_selem_register(handle, NULL, NULL); snd_mixer_load(handle); snd_mixer_selem_id_malloc(&s_elem); - snd_mixer_selem_id_set_name(s_elem, snd_card); + snd_mixer_selem_id_set_name(s_elem, ALSA_CHANNEL); elem = snd_mixer_find_selem(handle, s_elem); if (elem == NULL) { snd_mixer_selem_id_free(s_elem); snd_mixer_close(handle); - perror("alsa error"); + warn("error: ALSA"); return smprintf(UNKNOWN_STR); } @@ -501,7 +501,7 @@ vol_perc(const char *snd_card) snd_mixer_selem_id_free(s_elem); snd_mixer_close(handle); - return smprintf("%d", (vol * 100) / max); + return smprintf("%d", ((uint_fast16_t)(vol * 100) / max)); } static char *