From 7c8583d7d47158b1673950e98126579e63c6008f Mon Sep 17 00:00:00 2001 From: gravestench Date: Mon, 26 Oct 2020 23:16:59 +0000 Subject: [PATCH] github workflows should now fail on lint errors (#855) --- .github/workflows/pullRequest.yml | 2 +- .github/workflows/pushToMaster.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pullRequest.yml b/.github/workflows/pullRequest.yml index 8ea9a5bb..9fb65552 100644 --- a/.github/workflows/pullRequest.yml +++ b/.github/workflows/pullRequest.yml @@ -22,7 +22,7 @@ jobs: sudo apt-get install -y xvfb libxcursor-dev libxrandr-dev libxinerama-dev libxi-dev libgl1-mesa-dev libsdl2-dev libasound2-dev > /dev/null 2>&1 - name: Run golangci-lint - continue-on-error: true + continue-on-error: false uses: golangci/golangci-lint-action@v1.2.1 with: version: v1.27 diff --git a/.github/workflows/pushToMaster.yml b/.github/workflows/pushToMaster.yml index 1205d264..60ee0642 100644 --- a/.github/workflows/pushToMaster.yml +++ b/.github/workflows/pushToMaster.yml @@ -24,7 +24,7 @@ jobs: sudo apt-get install -y xvfb libxcursor-dev libxrandr-dev libxinerama-dev libxi-dev libgl1-mesa-dev libsdl2-dev libasound2-dev > /dev/null 2>&1 - name: Run golangci-lint - continue-on-error: true + continue-on-error: false uses: golangci/golangci-lint-action@v1.2.1 with: version: v1.27