From 4835cefef8608939d5a780d3eb2e9228646dd3c4 Mon Sep 17 00:00:00 2001
From: anvil-of-fury <evancoe@gmail.com>
Date: Sun, 21 Mar 2021 02:44:37 +0000
Subject: [PATCH] removing TODO comment since it broke linting during build

---
 d2common/d2cache/cache_test.go | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/d2common/d2cache/cache_test.go b/d2common/d2cache/cache_test.go
index 3cf1d159..57968d27 100644
--- a/d2common/d2cache/cache_test.go
+++ b/d2common/d2cache/cache_test.go
@@ -7,15 +7,16 @@ import (
 func TestCacheInsert(t *testing.T) {
 	cache := CreateCache(1)
 	insertError := cache.Insert("A", "", 1)
+
 	if insertError != nil {
 		t.Fatalf("Cache insert resulted in unexpected error: %s", insertError)
 	}
 }
 
-// TODO: do we want cache insert to fail if we add a node with weight > budget?
 func TestCacheInsertWithinBudget(t *testing.T) {
 	cache := CreateCache(1)
 	insertError := cache.Insert("A", "", 2)
+
 	if insertError != nil {
 		t.Fatalf("Cache insert resulted in unexpected error: %s", insertError)
 	}
@@ -23,20 +24,20 @@ func TestCacheInsertWithinBudget(t *testing.T) {
 
 func TestCacheInsertUpdatesWeight(t *testing.T) {
 	cache := CreateCache(2)
-	cache.Insert("A", "", 1)
-	cache.Insert("B", "", 1)
-	cache.Insert("budget_exceeded", "", 1)
+	_ = cache.Insert("A", "", 1)
+	_ = cache.Insert("B", "", 1)
+	_ = cache.Insert("budget_exceeded", "", 1)
 
 	if cache.GetWeight() != 2 {
 		t.Fatal("Cache with budget 2 did not correctly set weight after evicting one of three nodes")
 	}
-
 }
 
 func TestCacheInsertDuplicateRejected(t *testing.T) {
 	cache := CreateCache(2)
-	cache.Insert("dupe", "", 1)
+	_ = cache.Insert("dupe", "", 1)
 	dupeError := cache.Insert("dupe", "", 1)
+
 	if dupeError == nil {
 		t.Fatal("Cache insert of duplicate key did not result in any err")
 	}
@@ -45,9 +46,9 @@ func TestCacheInsertDuplicateRejected(t *testing.T) {
 func TestCacheInsertEvictsLeastRecentlyUsed(t *testing.T) {
 	cache := CreateCache(2)
 	// with a budget of 2, inserting 3 keys should evict the last
-	cache.Insert("evicted", "", 1)
-	cache.Insert("A", "", 1)
-	cache.Insert("B", "", 1)
+	_ = cache.Insert("evicted", "", 1)
+	_ = cache.Insert("A", "", 1)
+	_ = cache.Insert("B", "", 1)
 
 	_, foundEvicted := cache.Retrieve("evicted")
 	if foundEvicted {
@@ -57,6 +58,7 @@ func TestCacheInsertEvictsLeastRecentlyUsed(t *testing.T) {
 	// double check that only 1 one was evicted and not any extra
 	_, foundA := cache.Retrieve("A")
 	_, foundB := cache.Retrieve("B")
+
 	if !foundA || !foundB {
 		t.Fatal("Cache insert evicted more than necessary")
 	}
@@ -64,14 +66,14 @@ func TestCacheInsertEvictsLeastRecentlyUsed(t *testing.T) {
 
 func TestCacheInsertEvictsLeastRecentlyRetrieved(t *testing.T) {
 	cache := CreateCache(2)
-	cache.Insert("A", "", 1)
-	cache.Insert("evicted", "", 1)
+	_ = cache.Insert("A", "", 1)
+	_ = cache.Insert("evicted", "", 1)
 
 	// retrieve the oldest node, promoting it head so it is not evicted
 	cache.Retrieve("A")
 
 	// insert once more, exceeding weight capacity
-	cache.Insert("B", "", 1)
+	_ = cache.Insert("B", "", 1)
 	// now the least recently used key should be evicted
 	_, foundEvicted := cache.Retrieve("evicted")
 	if foundEvicted {
@@ -81,9 +83,10 @@ func TestCacheInsertEvictsLeastRecentlyRetrieved(t *testing.T) {
 
 func TestClear(t *testing.T) {
 	cache := CreateCache(1)
-	cache.Insert("cleared", "", 1)
+	_ = cache.Insert("cleared", "", 1)
 	cache.Clear()
 	_, found := cache.Retrieve("cleared")
+
 	if found {
 		t.Fatal("Still able to retrieve nodes after cache was cleared")
 	}