From 17036bf40e7deeceada541ee56fd855e84fc06b9 Mon Sep 17 00:00:00 2001 From: Ryan Fox Date: Mon, 19 Apr 2021 06:53:03 +0000 Subject: [PATCH] Blog: Correct point about disabling -Werror --- posts/2021-03-29-gentoo-overlays-for-noobs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/posts/2021-03-29-gentoo-overlays-for-noobs.md b/posts/2021-03-29-gentoo-overlays-for-noobs.md index d0ae43e..5873267 100644 --- a/posts/2021-03-29-gentoo-overlays-for-noobs.md +++ b/posts/2021-03-29-gentoo-overlays-for-noobs.md @@ -286,8 +286,8 @@ things. - I did not notice that they were statically linked since I don't understand Meson well. - It prevents swaybg from running alongside versions of gui-wm/sway below 1.1_alpha1 - Likely because that is the version where [swaybg became standalone](https://github.com/swaywm/sway/releases/tag/1.1-rc1). -- Compiler warnings are silenced - - They are probably only useful for developers, so why not? +- I forgot to remove the -Werror compiler flag + - Leaving it enabled can [break things](https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#-werror-compiler-flag-not-removed). - The ebuild uses usex instead of meson_feature - meson_feature wasn't added until [2019-03-17](https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/meson.eclass?id=eeb4c7afa12a3acb5773fbfdb4e6e1b1f626e731),