60c10ef248
Co-authored-by: Franklin T Kong <ftk@umich.edu> Co-authored-by: aiugai <aiugai@umich.edu> Fixes #4641 Overrode GetPlacementBlockTypeMeta for CactusBlock, which gets called before a player places the cactus block, so it returns true if the placement is allowed or false if not, in which case the cactus does not drop as a block but stays in the player's hand which is the expected behavior. Tested in Minecraft client 1.12.2.
202 lines
4.3 KiB
C++
202 lines
4.3 KiB
C++
#pragma once
|
|
|
|
#include "BlockPlant.h"
|
|
#include "../BlockInfo.h"
|
|
|
|
|
|
|
|
|
|
|
|
class cBlockCactusHandler :
|
|
public cClearMetaOnDrop<cBlockPlant<false>>
|
|
{
|
|
using Super = cClearMetaOnDrop<cBlockPlant<false>>;
|
|
|
|
public:
|
|
|
|
cBlockCactusHandler(BLOCKTYPE a_BlockType):
|
|
Super(a_BlockType)
|
|
{
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/** Called before a cactus block is placed by a player, overrides cItemHandler::GetPlacementBlockTypeMeta().
|
|
Calls CanBeAt function to determine if a cactus block can be placed on a given block. */
|
|
bool GetPlacementBlockTypeMeta(
|
|
cChunkInterface & a_ChunkInterface,
|
|
cPlayer & a_Player,
|
|
const Vector3i a_PlacedBlockPos,
|
|
eBlockFace a_ClickedBlockFace,
|
|
const Vector3i a_CursorPos,
|
|
BLOCKTYPE & a_BlockType, NIBBLETYPE & a_BlockMeta
|
|
) override
|
|
{
|
|
if (
|
|
a_Player.GetWorld()->DoWithChunkAt(a_PlacedBlockPos,
|
|
[this, a_PlacedBlockPos, &a_ChunkInterface](cChunk & a_Chunk)
|
|
{
|
|
auto RelPos = cChunkDef::AbsoluteToRelative(a_PlacedBlockPos);
|
|
return CanBeAt(a_ChunkInterface, RelPos, a_Chunk);
|
|
}
|
|
))
|
|
{
|
|
a_BlockType = m_BlockType;
|
|
// Setting a_BlockMeta to meta copied from the lowest 4 bits of the player's equipped item's damage value.
|
|
NIBBLETYPE Meta = static_cast<NIBBLETYPE>(a_Player.GetEquippedItem().m_ItemDamage);
|
|
a_BlockMeta = Meta & 0x0f;
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
virtual bool CanBeAt(cChunkInterface & a_ChunkInterface, const Vector3i a_RelPos, const cChunk & a_Chunk) override
|
|
{
|
|
if (a_RelPos.y <= 0)
|
|
{
|
|
return false;
|
|
}
|
|
BLOCKTYPE Surface = a_Chunk.GetBlock(a_RelPos.addedY(-1));
|
|
if ((Surface != E_BLOCK_SAND) && (Surface != E_BLOCK_CACTUS))
|
|
{
|
|
// Cactus can only be placed on sand and itself
|
|
return false;
|
|
}
|
|
|
|
// Check surroundings. Cacti may ONLY be surrounded by non-solid blocks
|
|
static const Vector3i Coords[] =
|
|
{
|
|
{-1, 0, 0},
|
|
{ 1, 0, 0},
|
|
{ 0, 0, -1},
|
|
{ 0, 0, 1},
|
|
};
|
|
for (size_t i = 0; i < ARRAYCOUNT(Coords); i++)
|
|
{
|
|
BLOCKTYPE BlockType;
|
|
NIBBLETYPE BlockMeta;
|
|
if (
|
|
a_Chunk.UnboundedRelGetBlock(a_RelPos + Coords[i], BlockType, BlockMeta) &&
|
|
(
|
|
cBlockInfo::IsSolid(BlockType) ||
|
|
(BlockType == E_BLOCK_LAVA) ||
|
|
(BlockType == E_BLOCK_STATIONARY_LAVA)
|
|
)
|
|
)
|
|
{
|
|
return false;
|
|
}
|
|
} // for i - Coords[]
|
|
|
|
return true;
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
virtual ColourID GetMapBaseColourID(NIBBLETYPE a_Meta) override
|
|
{
|
|
UNUSED(a_Meta);
|
|
return 7;
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual int Grow(cChunk & a_Chunk, Vector3i a_RelPos, int a_NumStages = 1) override
|
|
{
|
|
// Check the total height of the cacti blocks here:
|
|
int top = a_RelPos.y + 1;
|
|
while (
|
|
(top < cChunkDef::Height) &&
|
|
(a_Chunk.GetBlock({a_RelPos.x, top, a_RelPos.z}) == E_BLOCK_CACTUS)
|
|
)
|
|
{
|
|
++top;
|
|
}
|
|
int bottom = a_RelPos.y - 1;
|
|
while (
|
|
(bottom > 0) &&
|
|
(a_Chunk.GetBlock({a_RelPos.x, bottom, a_RelPos.z}) == E_BLOCK_CACTUS)
|
|
)
|
|
{
|
|
--bottom;
|
|
}
|
|
|
|
// Refuse if already too high:
|
|
auto numToGrow = std::min(a_NumStages, a_Chunk.GetWorld()->GetMaxCactusHeight() + 1 - (top - bottom));
|
|
if (numToGrow <= 0)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
BLOCKTYPE blockType;
|
|
for (int i = 0; i < numToGrow; ++i)
|
|
{
|
|
Vector3i pos(a_RelPos.x, top + i, a_RelPos.z);
|
|
if (!a_Chunk.UnboundedRelGetBlockType(pos, blockType) || (blockType != E_BLOCK_AIR))
|
|
{
|
|
// Cannot grow there
|
|
return i;
|
|
}
|
|
|
|
a_Chunk.UnboundedRelFastSetBlock(pos, E_BLOCK_CACTUS, 0);
|
|
|
|
// Check surroundings. Cacti may ONLY be surrounded by non-solid blocks; if they aren't, drop as pickup and bail out the growing
|
|
static const Vector3i neighborOffsets[] =
|
|
{
|
|
{-1, 0, 0},
|
|
{ 1, 0, 0},
|
|
{ 0, 0, -1},
|
|
{ 0, 0, 1},
|
|
} ;
|
|
for (const auto & ofs: neighborOffsets)
|
|
{
|
|
if (
|
|
a_Chunk.UnboundedRelGetBlockType(pos + ofs, blockType) &&
|
|
(
|
|
cBlockInfo::IsSolid(blockType) ||
|
|
(blockType == E_BLOCK_LAVA) ||
|
|
(blockType == E_BLOCK_STATIONARY_LAVA)
|
|
)
|
|
)
|
|
{
|
|
// Remove the cactus
|
|
auto absPos = a_Chunk.RelativeToAbsolute(pos);
|
|
a_Chunk.GetWorld()->DropBlockAsPickups(absPos);
|
|
return i + 1;
|
|
}
|
|
} // for neighbor
|
|
} // for i - numToGrow
|
|
return numToGrow;
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
protected:
|
|
|
|
virtual PlantAction CanGrow(cChunk & a_Chunk, Vector3i a_RelPos) override
|
|
{
|
|
// Only allow growing if there's an air block above:
|
|
if (((a_RelPos.y + 1) < cChunkDef::Height) && (a_Chunk.GetBlock(a_RelPos.addedY(1)) == E_BLOCK_AIR))
|
|
{
|
|
return Super::CanGrow(a_Chunk, a_RelPos);
|
|
}
|
|
return paStay;
|
|
}
|
|
} ;
|
|
|
|
|
|
|
|
|