Tiger Wang
a62b2b1be2
Move item placement into item handlers ( #5184 )
...
* Move item placement into item handlers
+ Add appropriate CanBeAt checks in cPlayer::PlaceBlocks, into which all placement handlers call.
* Partly addresses #5157
* Fixes #4878
* Fixes #2919
* Fixes #4629
* Fixes #4239
* Fixes #4849
Co-authored-by: changyong guo <guo1487@163.com>
Co-authored-by: Xotheus <shady3300@outlook.com>
Co-authored-by: Krist Pregracke <krist@tiger-scm.com>
* Review fixes
* Update APIDesc.lua
* Rename
Co-authored-by: changyong guo <guo1487@163.com>
Co-authored-by: Xotheus <shady3300@outlook.com>
Co-authored-by: Krist Pregracke <krist@tiger-scm.com>
2021-05-05 13:25:10 +00:00
Tiger Wang
125df19477
Do not fake a tool when converting to pickups ( #5170 )
...
* When the cause of destruction was world-induced (CanBeAt check failed) there is no tool. Pass the nullptr directly to ConvertToPickups and let it handle it.
* Fixes #4795
- Remove unused a_Digger parameter to ConvertToPickups.
2021-03-28 14:41:34 +01:00
peterbell10
a9031b6bae
Fix cmake not adding Werror on clang, and _lots_ of warnings ( #4963 )
...
* Fix cmake not adding Werror on clang, and _lots_ of warnings
* WIP: Build fixes
* Cannot make intermediate blockhandler instance
* Tiger's changes
* Fix BitIndex check
* Handle invalid NextState values in cMultiVersionProtocol
Co-authored-by: Tiger Wang <ziwei.tiger@outlook.com>
2020-10-05 10:27:14 +00:00
Tiger Wang
c53a0ba5f6
Unify block entity pickup conversion
...
- Removed normal BlockHandler knowledge of block entities during conversion
+ Added cBlockEntity::ConvertToPickups that handles it
2020-09-25 09:07:01 +00:00
Tiger Wang
68cced73af
BlockHandler initialisation is a constant expression ( #4891 )
...
* BlockHandler initialisation is a constant expression
If we can't make it all namespaces, this is the next best I guess.
+ Tag handlers constexpr, const as needed
+ Inherit constructors
* Privatise handler functions
* More constexpr
Co-authored-by: Alexander Harkness <me@bearbin.net>
2020-09-20 13:50:52 +00:00
Mattes D
487f9a2aa9
Vector3 in Handlers ( #4680 )
...
Refactored all cBlockHandler and cItemHandler descendants to use Vector3.
2020-04-21 22:19:22 +02:00
Mattes D
9ee47e5999
Using Super.
2020-04-16 20:07:48 +00:00
Alexander Harkness
8914355895
Fix rotation metas on blocks
2020-04-11 19:00:05 +00:00
GefaketHD
0712fd2d90
fixing rotation - rel. #4625
2020-04-11 19:00:05 +00:00
Alexander Harkness
0d72270186
Replace all single-digit hex constants with two-digit version
2020-04-10 13:07:16 +00:00
Alexander Harkness
49f301d5a4
Reduce line length on templates
2020-04-10 13:07:16 +00:00
Alexander Harkness
e5cc698ee7
Add additional spacing between template/function definitions
2020-04-10 13:07:16 +00:00
Alexander Harkness
9bb001f17b
Add doxy-comments to new functions
2020-04-10 13:07:16 +00:00
Alexander Harkness
2b77b67197
Fix comment text
2020-04-10 13:07:16 +00:00
Alexander Harkness
f40aba941e
Add mixins for blocks that rotate based on player yaw at placement
...
Also add observer block handler.
2020-04-10 13:07:16 +00:00
Mattes D
221cc4ec5c
Refactored block-to-pickup conversion. ( #4417 )
2019-10-16 10:06:34 +02:00