$OpenBSD: patch-base_logging_h,v 1.2 2011/03/15 11:38:05 robert Exp $ --- base/logging.h.orig Fri Mar 11 10:01:33 2011 +++ base/logging.h Mon Mar 14 10:55:37 2011 @@ -141,6 +141,18 @@ // There is also the special severity of DFATAL, which logs FATAL in // debug mode, ERROR in normal mode. +// XXX better comment -- must be before we use << and in global namespace +// These functions are provided as a convenience for logging, which is where we +// use streams (it is against Google style to use streams in other places). It +// is designed to allow you to emit non-ASCII Unicode strings to the log file, +// which is normally ASCII. It is relatively slow, so try not to use it for +// common cases. Non-ASCII characters will be converted to UTF-8 by these +// operators. +std::ostream& operator<<(std::ostream& out, const wchar_t* wstr); +inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) { + return out << wstr.c_str(); +} + namespace logging { // Where to record logging output? A flat file and/or system debug log via @@ -865,17 +877,6 @@ void RawLog(int level, const char* message); } while (0) } // namespace logging - -// These functions are provided as a convenience for logging, which is where we -// use streams (it is against Google style to use streams in other places). It -// is designed to allow you to emit non-ASCII Unicode strings to the log file, -// which is normally ASCII. It is relatively slow, so try not to use it for -// common cases. Non-ASCII characters will be converted to UTF-8 by these -// operators. -std::ostream& operator<<(std::ostream& out, const wchar_t* wstr); -inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) { - return out << wstr.c_str(); -} // The NOTIMPLEMENTED() macro annotates codepaths which have // not been implemented yet.