From 8a0d72f97db0d172e5335cb3db9ae27afc69df38 Mon Sep 17 00:00:00 2001 From: Tobias Kortkamp Date: Sat, 25 Aug 2018 03:35:46 +0000 Subject: [PATCH] biology/primer3: Fix build with Clang 6 thal.c:426:13: error: comparison between pointer and integer ('int' and 'const unsigned char *') if ('\0' == oligo_f) { ~~~~ ^ ~~~~~~~ thal.c:431:13: error: comparison between pointer and integer ('int' and 'const unsigned char *') if ('\0' == oligo_r) { ~~~~ ^ ~~~~~~~ http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/primer3-2.3.6.log --- biology/primer3/files/patch-thal.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 biology/primer3/files/patch-thal.c diff --git a/biology/primer3/files/patch-thal.c b/biology/primer3/files/patch-thal.c new file mode 100644 index 000000000000..06d1a884718e --- /dev/null +++ b/biology/primer3/files/patch-thal.c @@ -0,0 +1,24 @@ +hal.c:426:13: error: comparison between pointer and integer ('int' and 'const unsigned char *') + if ('\0' == oligo_f) { + ~~~~ ^ ~~~~~~~ +thal.c:431:13: error: comparison between pointer and integer ('int' and 'const unsigned char *') + if ('\0' == oligo_r) { + ~~~~ ^ ~~~~~~~ + +--- thal.c.orig 2018-08-25 03:33:22 UTC ++++ thal.c +@@ -423,12 +423,12 @@ thal(const unsigned char *oligo_f, + "Illegal type"); + o->align_end_1 = -1; + o->align_end_2 = -1; +- if ('\0' == oligo_f) { ++ if ('\0' == *oligo_f) { + strcpy(o->msg, "Empty first sequence"); + o->temp = 0.0; + return; + } +- if ('\0' == oligo_r) { ++ if ('\0' == *oligo_r) { + strcpy(o->msg, "Empty second sequence"); + o->temp = 0.0; + return;