mirror of
https://github.com/profanity-im/profanity.git
synced 2024-12-04 14:46:46 -05:00
23fa4750ff
## Summary Partial fix for https://github.com/profanity-im/profanity/issues/1939 > When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded. Download a file twice with `/url save`, the second download will not print download progress to the window. The cause is `HTTPDownload`'s `silent` variable is not initialized; so, `silent` points to a second-hand stack memory address with old data. `silent` references data, so the `if` statement will fail in **src/tools/http_download.c:206** and download progress will not print to the window. The fix is to initialize `silent` in both encrypted and unencrypted file download scenarios. ## Testing Valgrind: Yes - `/url save` without OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/url save` with OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py` **SUCCESS**: Try once and download progress is hidden. |
||
|---|---|---|
| .. | ||
| aesgcm_download.c | ||
| aesgcm_download.h | ||
| autocomplete.c | ||
| autocomplete.h | ||
| bookmark_ignore.c | ||
| bookmark_ignore.h | ||
| clipboard.c | ||
| clipboard.h | ||
| editor.c | ||
| editor.h | ||
| http_common.c | ||
| http_common.h | ||
| http_download.c | ||
| http_download.h | ||
| http_upload.c | ||
| http_upload.h | ||
| parser.c | ||
| parser.h | ||
| plugin_download.c | ||
| plugin_download.h | ||