From a35cbea73273fb7e61218155ca1c28ebab73bb5b Mon Sep 17 00:00:00 2001
From: James Booth <boothj5@gmail.com>
Date: Sat, 17 Oct 2015 22:30:01 +0100
Subject: [PATCH 1/3] Implemented /script list

---
 src/command/command.c        |  7 ++-----
 src/command/commands.c       |  4 ++++
 src/config/scripts.c         | 26 ++++++++++++++++++++++++++
 src/config/scripts.h         |  1 +
 src/ui/console.c             | 18 ++++++++++++++++++
 src/ui/ui.h                  |  1 +
 tests/unittests/ui/stub_ui.c |  1 +
 7 files changed, 53 insertions(+), 5 deletions(-)

diff --git a/src/command/command.c b/src/command/command.c
index 8b43ad21..35c2e32a 100644
--- a/src/command/command.c
+++ b/src/command/command.c
@@ -1693,19 +1693,17 @@ static struct cmd_t command_defs[] =
     },
 
     { "/script",
-        cmd_script, parse_args, 2, 2, NULL,
+        cmd_script, parse_args, 1, 2, NULL,
         CMD_NOTAGS
         CMD_SYN(
             "/script run <script>",
-            "/script remove <script>",
             "/script list",
             "/script show <script>")
         CMD_DESC(
-            "Manage and run command scripts. "
+            "Run command scripts. "
             "Scripts are stored in $XDG_DATA_HOME/profanity/scripts/ which is usually $HOME/.local/share/profanity/scripts/.")
         CMD_ARGS(
             { "script run <script>",    "Execute a script." },
-            { "script remove <script>", "Remove a script TODO." },
             { "script list",            "List all scripts TODO." },
             { "script show <script>",   "Show the commands in script TODO." })
         CMD_EXAMPLES(
@@ -2202,7 +2200,6 @@ cmd_init(void)
     script_ac = autocomplete_new();
     autocomplete_add(script_ac, "run");
     autocomplete_add(script_ac, "list");
-    autocomplete_add(script_ac, "remove");
     autocomplete_add(script_ac, "show");
 }
 
diff --git a/src/command/commands.c b/src/command/commands.c
index cbc37046..58f2a9b2 100644
--- a/src/command/commands.c
+++ b/src/command/commands.c
@@ -698,6 +698,10 @@ cmd_script(ProfWin *window, const char * const command, gchar **args)
         if (!res) {
             cons_show("Could not find script %s", args[1]);
         }
+    } else if (g_strcmp0(args[0], "list") == 0) {
+        GSList *scripts = scripts_list();
+        cons_show_scripts(scripts);
+        g_slist_free_full(scripts, g_free);
     } else {
         cons_bad_cmd_usage(command);
     }
diff --git a/src/config/scripts.c b/src/config/scripts.c
index 17beb697..916e292c 100644
--- a/src/config/scripts.c
+++ b/src/config/scripts.c
@@ -66,6 +66,32 @@ scripts_init(void)
             log_error("Error creating directory: %s", scriptsdir->str);
         }
     }
+
+    g_string_free(scriptsdir, TRUE);
+}
+
+GSList*
+scripts_list(void)
+{
+    gchar *data_home = xdg_get_data_home();
+    GString *scriptsdir = g_string_new(data_home);
+    free(data_home);
+    g_string_append(scriptsdir, "/profanity/scripts");
+
+    GSList *result = NULL;
+    GDir *scripts = g_dir_open(scriptsdir->str, 0, NULL);
+    g_string_free(scriptsdir, TRUE);
+
+    if (scripts) {
+        const gchar *script = g_dir_read_name(scripts);
+        while (script) {
+            result = g_slist_append(result, strdup(script));
+            script = g_dir_read_name(scripts);
+        }
+        g_dir_close(scripts);
+    }
+
+    return result;
 }
 
 gboolean
diff --git a/src/config/scripts.h b/src/config/scripts.h
index 114452af..9b56fac4 100644
--- a/src/config/scripts.h
+++ b/src/config/scripts.h
@@ -35,4 +35,5 @@
 #include <glib.h>
 
 void scripts_init(void);
+GSList* scripts_list(void);
 gboolean scripts_exec(const char *const script);
diff --git a/src/ui/console.c b/src/ui/console.c
index 6590cb78..2388e79b 100644
--- a/src/ui/console.c
+++ b/src/ui/console.c
@@ -1581,6 +1581,24 @@ cons_show_themes(GSList *themes)
     cons_alert();
 }
 
+void
+cons_show_scripts(GSList *scripts)
+{
+    cons_show("");
+
+    if (scripts == NULL) {
+        cons_show("No scripts available.");
+    } else {
+        cons_show("Scripts:");
+        while (scripts) {
+            cons_show(scripts->data);
+            scripts = g_slist_next(scripts);
+        }
+    }
+
+    cons_alert();
+}
+
 void
 cons_prefs(void)
 {
diff --git a/src/ui/ui.h b/src/ui/ui.h
index add38fb4..1a534012 100644
--- a/src/ui/ui.h
+++ b/src/ui/ui.h
@@ -278,6 +278,7 @@ void cons_show_status(const char * const barejid);
 void cons_show_info(PContact pcontact);
 void cons_show_caps(const char * const fulljid, resource_presence_t presence);
 void cons_show_themes(GSList *themes);
+void cons_show_scripts(GSList *scripts);
 void cons_show_aliases(GList *aliases);
 void cons_show_login_success(ProfAccount *account, int secured);
 void cons_show_software_version(const char * const jid,
diff --git a/tests/unittests/ui/stub_ui.c b/tests/unittests/ui/stub_ui.c
index a4d95bd1..ae959740 100644
--- a/tests/unittests/ui/stub_ui.c
+++ b/tests/unittests/ui/stub_ui.c
@@ -415,6 +415,7 @@ void cons_show_status(const char * const barejid) {}
 void cons_show_info(PContact pcontact) {}
 void cons_show_caps(const char * const fulljid, resource_presence_t presence) {}
 void cons_show_themes(GSList *themes) {}
+void cons_show_scripts(GSList *scripts) {}
 
 void cons_show_aliases(GList *aliases)
 {

From eca73909515a067725092f4464a12ad418e4b69a Mon Sep 17 00:00:00 2001
From: James Booth <boothj5@gmail.com>
Date: Sat, 17 Oct 2015 22:58:45 +0100
Subject: [PATCH 2/3] Implemented /script show

---
 src/command/commands.c       |  4 ++++
 src/config/scripts.c         | 40 +++++++++++++++++++++++++++++++++++-
 src/config/scripts.h         |  1 +
 src/ui/console.c             | 18 ++++++++++++++++
 src/ui/ui.h                  |  1 +
 tests/unittests/ui/stub_ui.c |  1 +
 6 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/src/command/commands.c b/src/command/commands.c
index 58f2a9b2..808f573e 100644
--- a/src/command/commands.c
+++ b/src/command/commands.c
@@ -702,6 +702,10 @@ cmd_script(ProfWin *window, const char * const command, gchar **args)
         GSList *scripts = scripts_list();
         cons_show_scripts(scripts);
         g_slist_free_full(scripts, g_free);
+    } else if ((g_strcmp0(args[0], "show") == 0) && args[1]) {
+        GSList *commands = scripts_read(args[1]);
+        cons_show_script(args[1], commands);
+        g_slist_free_full(commands, g_free);
     } else {
         cons_bad_cmd_usage(command);
     }
diff --git a/src/config/scripts.c b/src/config/scripts.c
index 916e292c..7d7caa4d 100644
--- a/src/config/scripts.c
+++ b/src/config/scripts.c
@@ -94,6 +94,44 @@ scripts_list(void)
     return result;
 }
 
+GSList*
+scripts_read(const char *const script)
+{
+    gchar *data_home = xdg_get_data_home();
+    GString *scriptpath = g_string_new(data_home);
+    free(data_home);
+
+    g_string_append(scriptpath, "/profanity/scripts/");
+    g_string_append(scriptpath, script);
+
+    FILE *scriptfile = g_fopen(scriptpath->str, "r");
+    if (!scriptfile) {
+        log_info("Script not found: %s", scriptpath->str);
+        g_string_free(scriptpath, TRUE);
+        return NULL;
+    }
+
+    g_string_free(scriptpath, TRUE);
+
+    char *line = NULL;
+    size_t len = 0;
+    ssize_t read;
+    GSList *result = NULL;
+
+    while ((read = getline(&line, &len, scriptfile)) != -1) {
+        if (g_str_has_suffix(line, "\n")) {
+            result = g_slist_append(result, g_strndup(line, strlen(line) -1));
+        } else {
+            result = g_slist_append(result, strdup(line));
+        }
+    }
+
+    fclose(scriptfile);
+    if (line) free(line);
+
+    return result;
+}
+
 gboolean
 scripts_exec(const char *const script)
 {
@@ -113,7 +151,7 @@ scripts_exec(const char *const script)
 
     g_string_free(scriptpath, TRUE);
 
-    char * line = NULL;
+    char *line = NULL;
     size_t len = 0;
     ssize_t read;
 
diff --git a/src/config/scripts.h b/src/config/scripts.h
index 9b56fac4..7ad19974 100644
--- a/src/config/scripts.h
+++ b/src/config/scripts.h
@@ -36,4 +36,5 @@
 
 void scripts_init(void);
 GSList* scripts_list(void);
+GSList* scripts_read(const char *const script);
 gboolean scripts_exec(const char *const script);
diff --git a/src/ui/console.c b/src/ui/console.c
index 2388e79b..37316d83 100644
--- a/src/ui/console.c
+++ b/src/ui/console.c
@@ -1599,6 +1599,24 @@ cons_show_scripts(GSList *scripts)
     cons_alert();
 }
 
+void
+cons_show_script(const char *const script, GSList *commands)
+{
+    cons_show("");
+
+    if (commands == NULL) {
+        cons_show("Script not found: %s", script);
+    } else {
+        cons_show("%s:", script);
+        while (commands) {
+            cons_show("  %s", commands->data);
+            commands = g_slist_next(commands);
+        }
+    }
+
+    cons_alert();
+}
+
 void
 cons_prefs(void)
 {
diff --git a/src/ui/ui.h b/src/ui/ui.h
index 1a534012..b7c7a8ae 100644
--- a/src/ui/ui.h
+++ b/src/ui/ui.h
@@ -279,6 +279,7 @@ void cons_show_info(PContact pcontact);
 void cons_show_caps(const char * const fulljid, resource_presence_t presence);
 void cons_show_themes(GSList *themes);
 void cons_show_scripts(GSList *scripts);
+void cons_show_script(const char *const script, GSList *commands);
 void cons_show_aliases(GList *aliases);
 void cons_show_login_success(ProfAccount *account, int secured);
 void cons_show_software_version(const char * const jid,
diff --git a/tests/unittests/ui/stub_ui.c b/tests/unittests/ui/stub_ui.c
index ae959740..99fe3007 100644
--- a/tests/unittests/ui/stub_ui.c
+++ b/tests/unittests/ui/stub_ui.c
@@ -416,6 +416,7 @@ void cons_show_info(PContact pcontact) {}
 void cons_show_caps(const char * const fulljid, resource_presence_t presence) {}
 void cons_show_themes(GSList *themes) {}
 void cons_show_scripts(GSList *scripts) {}
+void cons_show_script(const char *const script, GSList *commands) {}
 
 void cons_show_aliases(GList *aliases)
 {

From b8c08f85cc6e15519ba931915d652d4f3422df94 Mon Sep 17 00:00:00 2001
From: James Booth <boothj5@gmail.com>
Date: Sat, 17 Oct 2015 23:14:55 +0100
Subject: [PATCH 3/3] Added /script autocompletion

---
 src/command/command.c | 61 +++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 59 insertions(+), 2 deletions(-)

diff --git a/src/command/command.c b/src/command/command.c
index 35c2e32a..1b8def1a 100644
--- a/src/command/command.c
+++ b/src/command/command.c
@@ -51,6 +51,7 @@
 #include "config/preferences.h"
 #include "config/theme.h"
 #include "config/tlscerts.h"
+#include "config/scripts.h"
 #include "contact.h"
 #include "roster_list.h"
 #include "jid.h"
@@ -108,6 +109,7 @@ static char * _receipts_autocomplete(ProfWin *window, const char * const input);
 static char * _help_autocomplete(ProfWin *window, const char * const input);
 static char * _wins_autocomplete(ProfWin *window, const char * const input);
 static char * _tls_autocomplete(ProfWin *window, const char * const input);
+static char * _script_autocomplete(ProfWin *window, const char * const input);
 
 GHashTable *commands = NULL;
 
@@ -1776,6 +1778,7 @@ static Autocomplete pgp_log_ac;
 static Autocomplete tls_ac;
 static Autocomplete tls_certpath_ac;
 static Autocomplete script_ac;
+static Autocomplete script_show_ac;
 
 /*
  * Initialise command autocompleter and history
@@ -2201,6 +2204,8 @@ cmd_init(void)
     autocomplete_add(script_ac, "run");
     autocomplete_add(script_ac, "list");
     autocomplete_add(script_ac, "show");
+
+    script_show_ac = NULL;
 }
 
 void
@@ -2269,6 +2274,7 @@ cmd_uninit(void)
     autocomplete_free(tls_ac);
     autocomplete_free(tls_certpath_ac);
     autocomplete_free(script_ac);
+    autocomplete_free(script_show_ac);
 }
 
 gboolean
@@ -2454,6 +2460,10 @@ cmd_reset_autocomplete(ProfWin *window)
     autocomplete_reset(tls_ac);
     autocomplete_reset(tls_certpath_ac);
     autocomplete_reset(script_ac);
+    if (script_show_ac) {
+        autocomplete_free(script_show_ac);
+        script_show_ac = NULL;
+    }
 
     if (window->type == WIN_CHAT) {
         ProfChatWin *chatwin = (ProfChatWin*)window;
@@ -2666,8 +2676,8 @@ _cmd_complete_parameters(ProfWin *window, const char * const input)
         }
     }
 
-    gchar *cmds[] = { "/prefs", "/disco", "/close", "/subject", "/room", "/script" };
-    Autocomplete completers[] = { prefs_ac, disco_ac, close_ac, subject_ac, room_ac, script_ac };
+    gchar *cmds[] = { "/prefs", "/disco", "/close", "/subject", "/room" };
+    Autocomplete completers[] = { prefs_ac, disco_ac, close_ac, subject_ac, room_ac };
 
     for (i = 0; i < ARRAY_SIZE(cmds); i++) {
         result = autocomplete_param_with_ac(input, cmds[i], completers[i], TRUE);
@@ -2708,6 +2718,7 @@ _cmd_complete_parameters(ProfWin *window, const char * const input)
     g_hash_table_insert(ac_funcs, "/receipts",      _receipts_autocomplete);
     g_hash_table_insert(ac_funcs, "/wins",          _wins_autocomplete);
     g_hash_table_insert(ac_funcs, "/tls",           _tls_autocomplete);
+    g_hash_table_insert(ac_funcs, "/script",        _script_autocomplete);
 
     int len = strlen(input);
     char parsed[len+1];
@@ -3206,6 +3217,52 @@ _theme_autocomplete(ProfWin *window, const char * const input)
     return NULL;
 }
 
+static char *
+_script_autocomplete(ProfWin *window, const char * const input)
+{
+    char *result = NULL;
+    if ((strncmp(input, "/script show ", 13) == 0) && (strlen(input) > 13)) {
+        if (script_show_ac == NULL) {
+            script_show_ac = autocomplete_new();
+            GSList *scripts = scripts_list();
+            GSList *curr = scripts;
+            while (curr) {
+                autocomplete_add(script_show_ac, curr->data);
+                curr = g_slist_next(curr);
+            }
+            g_slist_free_full(scripts, g_free);
+        }
+        result = autocomplete_param_with_ac(input, "/script show", script_show_ac, TRUE);
+        if (result) {
+            return result;
+        }
+    }
+
+    if ((strncmp(input, "/script run ", 12) == 0) && (strlen(input) > 12)) {
+        if (script_show_ac == NULL) {
+            script_show_ac = autocomplete_new();
+            GSList *scripts = scripts_list();
+            GSList *curr = scripts;
+            while (curr) {
+                autocomplete_add(script_show_ac, curr->data);
+                curr = g_slist_next(curr);
+            }
+            g_slist_free_full(scripts, g_free);
+        }
+        result = autocomplete_param_with_ac(input, "/script run", script_show_ac, TRUE);
+        if (result) {
+            return result;
+        }
+    }
+
+    result = autocomplete_param_with_ac(input, "/script", script_ac, TRUE);
+    if (result) {
+        return result;
+    }
+
+    return NULL;
+}
+
 static char *
 _resource_autocomplete(ProfWin *window, const char * const input)
 {