From b8207207f46ce029ed428f4baf5918b6ee00f01d Mon Sep 17 00:00:00 2001 From: Stefan Kropp Date: Fri, 3 Jul 2020 18:47:16 +0200 Subject: [PATCH] Rework logging Changed default logging from INFO to WARN. Issue: #1353 --- src/log.c | 4 ++-- src/main.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/log.c b/src/log.c index 72654762..f8ef6bf6 100644 --- a/src/log.c +++ b/src/log.c @@ -232,8 +232,8 @@ log_level_from_string(char *log_level) return PROF_LEVEL_WARN; } else if (strcmp(log_level, "ERROR") == 0) { return PROF_LEVEL_ERROR; - } else { // default to info - return PROF_LEVEL_INFO; + } else { // default logging is warn + return PROF_LEVEL_WARN; } } diff --git a/src/main.c b/src/main.c index f87e8866..ef6dd26e 100644 --- a/src/main.c +++ b/src/main.c @@ -78,7 +78,7 @@ main(int argc, char **argv) { { "version", 'v', 0, G_OPTION_ARG_NONE, &version, "Show version information", NULL }, { "account", 'a', 0, G_OPTION_ARG_STRING, &account_name, "Auto connect to an account on startup" }, - { "log", 'l', 0, G_OPTION_ARG_STRING, &log, "Set logging levels, DEBUG, INFO (default), WARN, ERROR", "LEVEL" }, + { "log", 'l', 0, G_OPTION_ARG_STRING, &log, "Set logging levels, DEBUG, INFO, WARN (default), ERROR", "LEVEL" }, { "config", 'c', 0, G_OPTION_ARG_STRING, &config_file, "Use an alternative configuration file", NULL }, { "logfile", 'f', 0, G_OPTION_ARG_STRING, &log_file, "Specify log filename", NULL }, { "theme", 't', 0, G_OPTION_ARG_STRING, &theme_name, "Specify theme name", NULL }, @@ -177,7 +177,8 @@ main(int argc, char **argv) return 0; } - prof_run(log ? log : "INFO", account_name, config_file, log_file, theme_name); + /* Default logging WARN */ + prof_run(log ? log : "WARN", account_name, config_file, log_file, theme_name); /* Free resources allocated by GOptionContext */ g_free(log);