From 64df8630d4c9631625bccba8ffcdcbd05967e2cc Mon Sep 17 00:00:00 2001 From: Dmitry Podgorny Date: Fri, 9 Oct 2020 13:39:52 +0300 Subject: [PATCH] Fix use-after-free which is introduced in cons_alert() Commit f12161f fixes memory leak, but introduces use-after-free issue. Allocate new memory for win_name with g_strdup() since it is freed with g_free() later. --- src/ui/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/console.c b/src/ui/console.c index 8e06b290..a3797963 100644 --- a/src/ui/console.c +++ b/src/ui/console.c @@ -2408,7 +2408,7 @@ cons_alert(ProfWin* alert_origin_window) GList* item = g_list_find_custom(alert_list, win_name, (GCompareFunc)g_strcmp0); if (!item) { - alert_list = g_list_append(alert_list, win_name); + alert_list = g_list_append(alert_list, g_strdup(win_name)); } free(win_name);