aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2024-12-04 14:46:39 -05:00
Code

Merge pull request #919 from ailin-nemui/uafs

Browse Source 
Use-after-frees
This commit is contained in:
ailin-nemui 2018-09-04 09:35:47 +02:00 committed by GitHub
commit afb3daaf65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/modules.c
View File

@ -288,9 +288,10 @@ void modules_deinit(void)
g_hash_table_foreach(stridlookup, (GHFunc) uniq_get_modules, &list); g_hash_table_foreach(stridlookup, (GHFunc) uniq_get_modules, &list);
while (list != NULL) { while (list != NULL) {
void *tmp = list->data;
module_uniq_destroy(list->data); module_uniq_destroy(list->data);
g_free(list->data);
list = g_slist_remove(list, list->data); list = g_slist_remove(list, list->data);
g_free(tmp);
} }
g_hash_table_destroy(idlookup); g_hash_table_destroy(idlookup);

3
src/core/rawlog.c
View File

@ -64,9 +64,10 @@ static void rawlog_add(RAWLOG_REC *rawlog, char *str)
if (rawlog->nlines < rawlog_lines || rawlog_lines <= 2) if (rawlog->nlines < rawlog_lines || rawlog_lines <= 2)
rawlog->nlines++; rawlog->nlines++;
else { else {
g_free(rawlog->lines->data); void *tmp = rawlog->lines->data;
rawlog->lines = g_slist_remove(rawlog->lines, rawlog->lines = g_slist_remove(rawlog->lines,
rawlog->lines->data); rawlog->lines->data);
g_free(tmp);
} }
if (rawlog->logging) { if (rawlog->logging) {

2
src/core/special-vars.c
View File

@ -620,8 +620,8 @@ void eval_special_string(const char *cmd, const char *data,
/* FIXME: window item would need reference counting as well, /* FIXME: window item would need reference counting as well,
eg. "/EVAL win close;say hello" wouldn't work now.. */ eg. "/EVAL win close;say hello" wouldn't work now.. */
g_free(ret);
commands = g_slist_remove(commands, commands->data); commands = g_slist_remove(commands, commands->data);
g_free(ret);
} }
g_free(orig); g_free(orig);
} }

3
src/fe-common/core/themes.c
View File

@ -1424,8 +1424,9 @@ void themes_reload(void)
change_theme(settings_get_str("theme"), FALSE); change_theme(settings_get_str("theme"), FALSE);
while (refs != NULL) { while (refs != NULL) {
theme_unref(refs->data); void *tmp = refs->data;
refs = g_slist_remove(refs, refs->data); refs = g_slist_remove(refs, refs->data);
theme_unref(tmp);
} }
} }

3
src/irc/dcc/dcc.c
View File

@ -57,8 +57,9 @@ void dcc_unregister_type(const char *type)
pos = gslist_find_string(dcc_types, type); pos = gslist_find_string(dcc_types, type);
if (pos != NULL) { if (pos != NULL) {
g_free(pos->data); void *tmp = pos->data;
dcc_types = g_slist_remove(dcc_types, pos->data); dcc_types = g_slist_remove(dcc_types, pos->data);
g_free(tmp);
} }
} }