From 2e63374f31e933e9ca62d7174f9bc85bc943500d Mon Sep 17 00:00:00 2001 From: Emanuele Giaquinta Date: Sun, 2 Mar 2008 19:54:34 +0000 Subject: [PATCH] Use g_strchomp to remove trailing whitespace. This fixes an invalid read, when the string is empty, reported by Enrico Scholz. git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4717 dbcabf3a-b0e7-0310-adc4-f8d773084564 --- src/fe-common/core/fe-help.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/fe-common/core/fe-help.c b/src/fe-common/core/fe-help.c index 76e4c6d2..09485fac 100644 --- a/src/fe-common/core/fe-help.c +++ b/src/fe-common/core/fe-help.c @@ -252,12 +252,10 @@ static void show_help(const char *data) /* SYNTAX: HELP [] */ static void cmd_help(const char *data) { - char *cmd, *ptr; + char *cmd; cmd = g_strdup(data); - ptr = cmd+strlen(cmd); - while (ptr[-1] == ' ') ptr--; *ptr = '\0'; - + g_strchomp(cmd); g_strdown(cmd); show_help(cmd); g_free(cmd);