From 8c2fa0687ea5761d51e2783d903b103a42cce076 Mon Sep 17 00:00:00 2001 From: Ailin Nemui Date: Wed, 13 Sep 2023 21:31:11 +0200 Subject: [PATCH 1/3] silence clang perl warning on affected version --- .github/workflows/check.yml | 3 +++ meson.build | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 192e3204..f92e11e4 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -65,6 +65,9 @@ jobs: curl -SLf https://github.com/irssi-import/actions-irssi/raw/master/check-irssi/render.pl -o ~/render.pl && chmod +x ~/render.pl - name: unpack archive run: tar xaf artifact/irssi-*.tar.gz + - name: Setup local annotations + if: ${{ github.event_name == 'pull_request' }} + uses: irssi-import/actions-irssi/problem-matchers@master - name: build and install with meson run: | # ninja install diff --git a/meson.build b/meson.build index 07949e30..0d06c466 100644 --- a/meson.build +++ b/meson.build @@ -390,6 +390,11 @@ if want_perl if perl_version == UNSET perl_version = run_command(cross_perl, '-V::version:', check : true).stdout().split('\'')[1] endif + + # disable clang warning + if perl_version.version_compare('<5.35.2') + perl_cflags += cc.get_supported_arguments('-Wno-compound-token-split-by-macro') + endif perl_dep = declare_dependency(compile_args : perl_cflags, link_args : perl_ldflags, version : perl_version) From 4bc354d5e434300ca6c9362187627dd806b45273 Mon Sep 17 00:00:00 2001 From: Ailin Nemui Date: Wed, 13 Sep 2023 22:54:46 +0200 Subject: [PATCH 2/3] load all modules in the right order during check --- .github/workflows/check.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index f92e11e4..276e513e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -96,9 +96,14 @@ jobs: ^set -clear log_day_changed ^set -clear log_open_string ^set log_timestamp * - ^window log on' > irssi-test/startup - echo load perl >> irssi-test/startup - echo load proxy >> irssi-test/startup - echo ^quit >> irssi-test/startup + ^window log on + load irc + load dcc + load flood + load notifylist + load perl + load otr + load proxy + ^quit' > irssi-test/startup irssi-build/bin/irssi --home irssi-test | perl -Mutf8 -C ~/render.pl cat irc.log.* From 7c5b2db26974c671e65055b9b6749bc538186afd Mon Sep 17 00:00:00 2001 From: Ailin Nemui Date: Thu, 14 Sep 2023 15:21:55 +0200 Subject: [PATCH 3/3] add separate annotation-warnings step see https://github.com/actions/runner/blob/2908d82845c018193655e68f3c20a5ad03bc0efd/src/Runner.Worker/Handlers/OutputManager.cs#L320 see https://github.com/actions/runner/issues/763#issuecomment-1435735340 --- .github/workflows/check.yml | 55 +++++++++++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 276e513e..65f56b17 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -65,9 +65,6 @@ jobs: curl -SLf https://github.com/irssi-import/actions-irssi/raw/master/check-irssi/render.pl -o ~/render.pl && chmod +x ~/render.pl - name: unpack archive run: tar xaf artifact/irssi-*.tar.gz - - name: Setup local annotations - if: ${{ github.event_name == 'pull_request' }} - uses: irssi-import/actions-irssi/problem-matchers@master - name: build and install with meson run: | # ninja install @@ -107,3 +104,55 @@ jobs: ^quit' > irssi-test/startup irssi-build/bin/irssi --home irssi-test | perl -Mutf8 -C ~/render.pl cat irc.log.* + annotation-warnings: + runs-on: ubuntu-latest + if: ${{ github.event_name == 'pull_request' }} + env: + CC: clang + steps: + - name: prepare required software + run: | + sudo apt update && sudo apt install $apt_build_deps + - uses: actions/checkout@main + - name: Setup local annotations + uses: irssi-import/actions-irssi/problem-matchers@master + - name: set PATH + run: | + echo "$HOME/.local/bin" >> $GITHUB_PATH + - name: prepare required software + env: + meson_ver: ${{ matrix.meson_ver }} + setuptools_ver: ${{ matrix.setuptools_ver }} + run: | + sudo apt update && sudo apt install $apt_build_deps $apt_build_deps_meson + eval "$get_pip_build_deps_meson" + curl -SLf https://github.com/irssi-import/actions-irssi/raw/master/check-irssi/render.pl -o ~/render.pl && chmod +x ~/render.pl + - name: build and install with meson + run: | + meson Build $build_options_meson --prefix=${prefix/\~/~} + ninja -C Build + ninja -C Build install >/dev/null + - name: run launch test + env: + TERM: xterm + run: | + # automated irssi launch test + cd + mkdir irssi-test + echo 'echo automated irssi launch test + ^set settings_autosave off + ^set -clear log_close_string + ^set -clear log_day_changed + ^set -clear log_open_string + ^set log_timestamp * + ^window log on + load irc + load dcc + load flood + load notifylist + load perl + load otr + load proxy + ^quit' > irssi-test/startup + irssi-build/bin/irssi --home irssi-test | perl -Mutf8 -C ~/render.pl + cat irc.log.*