1
0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2024-12-04 14:46:30 -05:00
Commit Graph

1427 Commits

Author SHA1 Message Date
Marvin Scholz
271ef864ac Cleanup: Remove unused server block in directory
The director block for YP directories accepted a server block which
was completely unused in the whole codebase, so do not parse it in
the first place.
2020-04-23 03:00:32 +02:00
Philipp Schafft
dcdd96c000 Update: Make listensocket_container_get_by_id() public 2020-04-22 19:35:35 +00:00
Marvin Scholz
f898da63b8 Cleanup: YP: Narrow variable scope 2020-04-21 20:43:01 +02:00
Marvin Scholz
e534df86f8 Fix: YP: Improve error handling
In case the url written by client_get_baseurl exceeds the length and
the realloc failed, previously the truncated URL would have been used.

The error case (ret < 0) was not handled at all before.
2020-04-21 20:43:01 +02:00
Marvin Scholz
7563fe9e52 Fix: YP: Send correct listener URL in case of TLS 2020-04-21 20:12:22 +02:00
Marvin Scholz
2b56f73cfb Cleanup: Do not name variable same as hex function 2020-04-19 04:14:07 +02:00
Marvin Scholz
386a461016 Fix: Fixed check for icecast_kva_t value 2020-04-19 04:10:28 +02:00
Marvin Scholz
e6856c153e Cleanup: Fix order of arguments in forward declaration 2020-04-19 04:05:24 +02:00
Marvin Scholz
b93ac5a94e Fix: Fixed check for root node in reportxml 2020-04-19 03:58:31 +02:00
Marvin Scholz
0c3da2df86 Cleanup: Simplify client_complete
Instead of using a "have" variable which makes it a bit confusing
to understand whats going on, use a do {} while (0) and break from it
instead.
2020-04-19 03:43:27 +02:00
Marvin Scholz
4b2d38fcfc Cleanup: Remove duplicated check 2020-04-19 03:32:59 +02:00
Marvin Scholz
3352ddfb36 Cleanup: Remove redundant check
It's already checked earlier if auth is non-NULL, so this check
here is not needed.
2020-04-19 03:28:21 +02:00
Marvin Scholz
25f54db863 Fix: Reorder logging initialization to prevent race
Without this, the logging on the stats thread would race with the log
initialization on the main thread.
2020-04-19 03:09:49 +02:00
Marvin Scholz
d2b137a8ad Fix: Fixed memory leak on relay parsing failure 2020-04-19 03:02:03 +02:00
Philipp Schafft
2ffaa92ea6 Fix: Fixed two double-unlock errors 2020-02-14 14:05:01 +00:00
Philipp Schafft
97181fb112 Updated submodules 2020-02-12 11:13:46 +00:00
Philipp Schafft
6ca6283cb4 Fix: Fixed invalid locking.
* listensocket_get_listener() must always be called with a matching call
  to listensocket_release_listener
* No ticket for this, but may be related to #2372.
* Found an reported by Xogium on IRC.

See: #2372
2019-11-22 14:48:49 +00:00
Philipp Schafft
ddafdd971f Fix: Strange patch for ICY 2019-09-17 18:08:57 +00:00
Philipp Schafft
f83fe87ab9 Update: Added some debugging lines 2019-09-17 17:32:00 +00:00
Philipp Schafft
cf9c8cf9ad Fix: Fixed leak in codec Speex codec probing code.
Thanks to Xogium for finding and debugging this!

Fixes: #2377
2019-06-28 08:03:51 +00:00
Philipp Schafft
1b94dea420 Update: Improved connecting-the-dots regarding clients and object IDs 2019-06-26 08:23:29 +00:00
Philipp Schafft
3761582ab8 Update: Mark a few developer level debugging messages as such 2019-05-28 07:55:18 +00:00
Philipp Schafft
fff3a5c6a6 Update: Write a error level message on admin/ based metadata updates we reject 2019-05-28 07:52:47 +00:00
Philipp Schafft
e60a36bfb6 Fix: Corrected log output from <unknown< to <unknown> 2019-05-28 07:02:45 +00:00
Philipp Schafft
dbabf91510 Fix: Only send 100 on request and 200 only on SOURCE 2019-05-14 11:38:08 +00:00
Philipp Schafft
0288af5a93 Feature: Report SOURCE as deprecated in log on level DEBUG 2019-05-14 11:37:57 +00:00
Philipp Schafft
0467ef5657 Feature: Log HTTP method used to start a source 2019-05-14 11:37:06 +00:00
Marvin Scholz
8b68c462c4 Fix: Free strings with older OpenSSL versions 2019-04-24 18:52:41 +02:00
Marvin Scholz
e09f48a034 Update: Do not use SSLv23_server_method
...with OpenSSL 1.1.0 or newer

Instead use TLS_server_method and
SSL_CTX_set_min_proto_version to limit
the used protocol versions.
2019-04-24 18:52:41 +02:00
Marvin Scholz
e824e48fdf Cleanup: Remove unnecessary SSL_CTX_get_options
According to the documentation the current option state is not cleared
but the options are added to the current options, so gettin the
current options seems redundant to the behavior of SSL_CTX_set_options:

> SSL_CTX_set_options() adds the options set via bitmask in options
> to ctx. Options already set before are not cleared!
2019-04-24 18:52:41 +02:00
Marvin Scholz
14ba90fc93 Cleanup: Simplify adding SSL_OP_NO_COMPRESSION 2019-04-24 18:52:41 +02:00
Marvin Scholz
ed9a4e658c Cleanup: Simplify OpenSSL context initialisation
Assigning the return value of SSLv23_server_method to a variable is
not necessary here and not doing it can get us rid of a lot of
condition code given that the type of the return value changed
at some point.
2019-04-24 18:52:41 +02:00
Marvin Scholz
07304b5193 Update: Do not init OpenSSL since 1.1.0
Explicitly initializing the library is not longer needed since
OpenSSL 1.1.0 and the SSL_library_init function is deprecated.

Citing the manual:

> As of version 1.1.0 OpenSSL will automatically allocate all resources
> that it needs so no explicit initialisation is required. Similarly it
> will also automatically deinitialise as required.

Fix #2318
2019-04-24 18:52:41 +02:00
Philipp Schafft
001ac59127 Feature: Added auth backend "enforce_auth".
Closes: #2348
2019-01-16 14:11:03 +00:00
Philipp Schafft
8589c1a040 Feature: Actually disable developer only logging if --enable-devel-logging is not given 2019-01-09 15:39:55 +00:00
Philipp Schafft
e6122f13fb Feature: Marked spammy development only output as such
See: #2358
2019-01-09 15:04:16 +00:00
Philipp Schafft
bb6ecd31fd Cleanup: Use "match-method", not (deprecated) "methods" 2019-01-09 11:14:33 +00:00
Philipp Schafft
e196495008 Cleanup: Fixed spaces 2019-01-09 11:11:25 +00:00
Philipp Schafft
d85a0ded30 Feature: Move common methods into CONFIG_LEGACY_ALL_METHODS 2019-01-09 11:07:40 +00:00
Philipp Schafft
4fbde4b96c Update: Allow relay clients to use OPTIONS 2019-01-09 11:06:28 +00:00
Philipp Schafft
95405e406a Update: Allow source clients to use OPTIONS 2019-01-09 11:04:06 +00:00
Philipp Schafft
5a81e8afa2 Cleanup: Use less magic constants for __append_old_style_auth() 2019-01-09 10:49:00 +00:00
Philipp Schafft
a301a302ba Feature: Replaced free()-strdup() in event code with util_replace_string()
See: #2370
2019-01-09 09:30:31 +00:00
Philipp Schafft
edd3dcc60d Update: Renamed replace_string() to util_replace_string() 2019-01-09 09:18:50 +00:00
spr0cketeer
31da097922 Fix: Correct url event "action" option handling
Closes: #2370
2019-01-06 18:57:45 +00:00
Philipp Schafft
de4fdf6656 Fix: Corrected check for return value of tls_got_shutdown() 2018-12-24 16:29:22 +00:00
Philipp Schafft
0a026c8b45 Cleanup: Corrected code formating 2018-12-17 08:52:51 +00:00
Philipp Schafft
7fdc9ed11f Fix: Permit HTTP keep-alive for report XML based replys 2018-12-17 08:51:25 +00:00
Philipp Schafft
825f92d6e2 Feature: Support HTTP keep-alive for SOURCE connections if they give us a content-length (useful for pokes) 2018-12-17 08:46:52 +00:00
Philipp Schafft
b02f306521 Fix: Updated allowed method lists for legacy-global-source and legacy-mount-source
For legacy-global-source this adds POST to the list.
For legacy-mount-source this adds POST and DELETE to the list.
The lists are now sync.

Closes: #2366
Found while working on & See also: icecast-libshout#2303
2018-12-14 12:57:23 +00:00