aniani/icecast-server
1
0
Fork 0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2024-12-04 14:46:30 -05:00
Code

Fix: Ensure references are counted correctly in case reportxml_node_copy() fails

Browse Source
This commit is contained in:
Philipp Schafft 2018-06-08 08:47:37 +00:00
parent c4dca907ab
commit ae489acc93
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/reportxml.c
View File

@ -440,15 +440,18 @@ reportxml_node_t * reportxml_node_copy(reportxml_node_t *node)
} }
for (i = 0; i < (size_t)count; i++) { for (i = 0; i < (size_t)count; i++) {
reportxml_node_t *child = reportxml_node_copy(reportxml_node_get_child(node, i)); reportxml_node_t *child = reportxml_node_get_child(node, i);
reportxml_node_t *copy = reportxml_node_copy(child);
if (!child) { refobject_unref(child);
if (!copy) {
refobject_unref(ret); refobject_unref(ret);
return NULL; return NULL;
} }
if (reportxml_node_add_child(ret, child) != 0) { if (reportxml_node_add_child(ret, copy) != 0) {
refobject_unref(child); refobject_unref(copy);
refobject_unref(ret); refobject_unref(ret);
return NULL; return NULL;
} }