aniani/icecast-server
1
0
Fork 0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2024-12-04 14:46:30 -05:00
Code

Fix for evil format string vulnerability - people, don't DO THIS!

Browse Source 
Fix from Emil Styrke <emil@lysator.liu.se>

svn path=/trunk/icecast/; revision=3341
This commit is contained in:
Michael Smith 2002-06-03 09:12:50 +00:00
parent 92bb45ddc7
commit 8a4ae84dce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/format_vorbis.c
View File

@ -141,11 +141,11 @@ int format_vorbis_get_buffer(format_plugin_t *self, char *data, unsigned long le
/* put known comments in the stats */
tag = vorbis_comment_query(&state->vc, "TITLE", 0);
if (tag) stats_event_args(self->mount, "title", tag);
else stats_event_args(self->mount, "title", "unknown");
if (tag) stats_event(self->mount, "title", tag);
else stats_event(self->mount, "title", "unknown");
tag = vorbis_comment_query(&state->vc, "ARTIST", 0);
if (tag) stats_event_args(self->mount, "artist", tag);
else stats_event_args(self->mount, "artist", "unknown");
if (tag) stats_event(self->mount, "artist", tag);
else stats_event(self->mount, "artist", "unknown");
/* don't need these now */
ogg_stream_clear(&state->os);