From 0e414f6142026e230136b41cd48e6eb19ca409a8 Mon Sep 17 00:00:00 2001 From: Moritz Grimm Date: Thu, 28 Sep 2017 12:40:52 +0200 Subject: [PATCH] Remove unused variable and change out_len to unsigned --- src/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util.c b/src/util.c index ad84464..36ee935 100644 --- a/src/util.c +++ b/src/util.c @@ -301,8 +301,7 @@ char * util_shellquote(const char *in, size_t outlen_max) { char *out, *out_p; - ssize_t out_len; - size_t out_siz; + size_t out_len; const char *in_p; if (!outlen_max || outlen_max > SHELLQUOTE_OUTLEN_MAX) @@ -321,7 +320,7 @@ util_shellquote(const char *in, size_t outlen_max) switch (*in_p) { case '\'': - if (out_len > 4) { + if (4 < out_len) { *out_p++ = '\''; *out_p++ = '\\'; *out_p++ = '\''; @@ -338,6 +337,7 @@ util_shellquote(const char *in, size_t outlen_max) out_len--; } *out_p++ = '\''; + out_len--; return (out); }